Removed propagation of UV changes across boundary of selection #116914

Closed
Jonas Dichelle wants to merge 4 commits from JonasDichelle:jonasdichelle-patch-1 into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Contributor

Removed propagation of UV changes across boundary of selection.
This caused unwanted stretching behavior as descriped here:
#115432

Removed propagation of UV changes across boundary of selection. This caused unwanted stretching behavior as descriped here: https://projects.blender.org/blender/blender/issues/115432
Jonas Dichelle added 1 commit 2024-01-08 22:46:31 +01:00
# Propagate UV changes across boundary of selection.

Removed propagation of UV changes across boundary of selection.
This caused unwanted stretching behavior as descriped here:
#115432
Jonas Dichelle added 1 commit 2024-01-08 23:28:17 +01:00
Added the propagate loop of @Chris_Blackbourn back in with the option to toggle it using a boolean "Rip Modified UVs" in the operator
Jonas Dichelle added 1 commit 2024-01-08 23:51:09 +01:00
revert Update scripts/startup/bl_operators/uvcalc_follow_active.py

Added the propagate loop of @Chris_Blackbourn back in with the option to toggle it using a boolean "Rip Modified UVs" in the operator
Jonas Dichelle added 1 commit 2024-01-09 00:09:18 +01:00
Added the propagate loop of @Chris_Blackbourn back in with the option to toggle it using a boolean "Rip Modified UVs" in the operator.
Author
Contributor

I added the ability to pick the desired behavior, using a boolean "Rip Modified UVs".
Disabling it enables the propagation loop added in e0e3650495, enabling it uses the old behavior before that commit.

I added the ability to pick the desired behavior, using a boolean "Rip Modified UVs". Disabling it enables the propagation loop added in e0e3650495, enabling it uses the old behavior before that commit.
Iliya Katushenock added this to the Modeling project 2024-01-09 00:22:52 +01:00
Iliya Katushenock added the
Interest
Python API
Interest
UV Editing
labels 2024-01-09 00:22:59 +01:00

@JonasDichelle thanks for looking into this, to resolve #115432 I've reverted e0e3650495, see: 71af74622f.
Partly because

Was there an important use-case to propagate the changes to adjacent UV's? Or was this option added mainly to restore previous behavior?

@JonasDichelle thanks for looking into this, to resolve #115432 I've reverted e0e36504950e42507cef8dc95d36bf93d03d636f, see: 71af74622f771867c049c2bd79047089077271eb. Partly because Was there an important use-case to propagate the changes to adjacent UV's? Or was this option added mainly to restore previous behavior?
Author
Contributor

@ideasman42 Thank you, for resolving the issue!

Yes, I added the option to choose the behavior mainly because I didn't want to completely undo what @Chris_Blackbourn had done.
I'm guessing he added the behavior because users might not expect the operator to disconnect bounding quads while alligning them.
So I think I understand the intentions of the change.
But reverting it is probably just fine.

@ideasman42 Thank you, for resolving the issue! Yes, I added the option to choose the behavior mainly because I didn't want to completely undo what @Chris_Blackbourn had done. I'm guessing he added the behavior because users might not expect the operator to disconnect bounding quads while alligning them. So I think I understand the intentions of the change. But reverting it is probably just fine.

In that case did you want to update this PR, otherwise it could be closed.

In that case did you want to update this PR, otherwise it could be closed.
Author
Contributor

Not necessarily, closing it is fine by me.

Not necessarily, closing it is fine by me.
Jonas Dichelle closed this pull request 2024-01-10 02:57:51 +01:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116914
No description provided.