Removed propagation of UV changes across boundary of selection #116914

Closed

Jonas Dichelle wants to merge 4 commits from JonasDichelle:jonasdichelle-patch-1 into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Jonas Dichelle commented

2024-01-08 22:46:23 +01:00

Contributor

Removed propagation of UV changes across boundary of selection.
This caused unwanted stretching behavior as descriped here:
#115432

Removed propagation of UV changes across boundary of selection. This caused unwanted stretching behavior as descriped here: https://projects.blender.org/blender/blender/issues/115432

Jonas Dichelle added 1 commit 2024-01-08 22:46:31 +01:00

41809aabc4 Update scripts/startup/bl_operators/uvcalc_follow_active.py

# Propagate UV changes across boundary of selection.

Removed propagation of UV changes across boundary of selection.
This caused unwanted stretching behavior as descriped here:
#115432

Jonas Dichelle added 1 commit 2024-01-08 23:28:17 +01:00

6996b8e00d Update scripts/startup/bl_operators/uvcalc_follow_active.py

Added the propagate loop of @Chris_Blackbourn back in with the option to toggle it using a boolean "Rip Modified UVs" in the operator

Jonas Dichelle added 1 commit 2024-01-08 23:51:09 +01:00

6321c7106c revert 6996b8e00d

revert Update scripts/startup/bl_operators/uvcalc_follow_active.py

Added the propagate loop of @Chris_Blackbourn back in with the option to toggle it using a boolean "Rip Modified UVs" in the operator

Jonas Dichelle added 1 commit 2024-01-09 00:09:18 +01:00

ab612709a8 Update scripts/startup/bl_operators/uvcalc_follow_active.py

Added the propagate loop of @Chris_Blackbourn back in with the option to toggle it using a boolean "Rip Modified UVs" in the operator.

Jonas Dichelle commented

2024-01-09 00:22:16 +01:00

Author

Contributor

I added the ability to pick the desired behavior, using a boolean "Rip Modified UVs".
Disabling it enables the propagation loop added in e0e3650495, enabling it uses the old behavior before that commit.

I added the ability to pick the desired behavior, using a boolean "Rip Modified UVs". Disabling it enables the propagation loop added in e0e3650495, enabling it uses the old behavior before that commit.

blender_o1Q2p4uq7S.png

21 KiB

Iliya Katushenock added this to the Modeling project 2024-01-09 00:22:52 +01:00

Iliya Katushenock added the

labels 2024-01-09 00:22:59 +01:00

~~Jonas Dichelle referenced this pull request 2024-01-09 00:25:23 +01:00~~

Regression: UV Follow Active Quads operator moves unselected vertices in UV editor #115432

Campbell Barton commented

2024-01-09 06:57:03 +01:00

Owner

@JonasDichelle thanks for looking into this, to resolve #115432 I've reverted e0e3650495, see: 71af74622f.
Partly because

Was there an important use-case to propagate the changes to adjacent UV's? Or was this option added mainly to restore previous behavior?

@JonasDichelle thanks for looking into this, to resolve #115432 I've reverted e0e36504950e42507cef8dc95d36bf93d03d636f, see: 71af74622f771867c049c2bd79047089077271eb. Partly because Was there an important use-case to propagate the changes to adjacent UV's? Or was this option added mainly to restore previous behavior?

Jonas Dichelle commented

2024-01-09 07:54:59 +01:00

Author

Contributor

@ideasman42 Thank you, for resolving the issue!

Yes, I added the option to choose the behavior mainly because I didn't want to completely undo what @Chris_Blackbourn had done.
I'm guessing he added the behavior because users might not expect the operator to disconnect bounding quads while alligning them.
So I think I understand the intentions of the change.
But reverting it is probably just fine.

@ideasman42 Thank you, for resolving the issue! Yes, I added the option to choose the behavior mainly because I didn't want to completely undo what @Chris_Blackbourn had done. I'm guessing he added the behavior because users might not expect the operator to disconnect bounding quads while alligning them. So I think I understand the intentions of the change. But reverting it is probably just fine.

Campbell Barton commented

2024-01-10 02:37:10 +01:00

Owner

In that case did you want to update this PR, otherwise it could be closed.

In that case did you want to update this PR, otherwise it could be closed.

Jonas Dichelle commented

2024-01-10 02:52:54 +01:00

Author

Contributor

Not necessarily, closing it is fine by me.

Not necessarily, closing it is fine by me.

Jonas Dichelle closed this pull request

2024-01-10 02:57:51 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116914

No description provided.