Fix #73524: Autokey inserts keyframes into the driver FCurve #116927

Christoph Lendenfeld · 2024-01-09T10:52:09+01:00

2024-01-09 10:52:09 +01:00

When autokeying a property with a driver, the code added
the keyframe into the drivers FCurve.

Judging by the code the intention was to be able to quickly
set up driven keys by modifying the driven value and have that
reflected in the driver curve.

However that idea was blocked by the fact that you can't actually
change the value of a property that is driven.
In addition to that it's quite unexpected and the result is hardly
communicated to the user.

The solution is to not insert keyframes to drivers using the
autokeying system.

Also Fixes #95866

This was discussed in the A&R module meeting and the consensus was the feature to set up driven keys would be great, but since it's not working at all currently it's better to get rid of the bugs.

When autokeying a property with a driver, the code added the keyframe into the drivers FCurve. Judging by the code the intention was to be able to quickly set up driven keys by modifying the driven value and have that reflected in the driver curve. However that idea was blocked by the fact that you can't actually change the value of a property that is driven. In addition to that it's quite unexpected and the result is hardly communicated to the user. The solution is to not insert keyframes to drivers using the autokeying system. Also Fixes #95866 ------ This was discussed in the [A&R module meeting](https://devtalk.blender.org/t/2024-01-11-animation-rigging-module-meeting/32888#patch-review-decision-time-5) and the consensus was the feature to set up driven keys would be great, but since it's not working at all currently it's better to get rid of the bugs.

👍 1

Christoph Lendenfeld added the

Module

Animation & Rigging

label 2024-01-09 10:52:09 +01:00

Christoph Lendenfeld added 1 commit 2024-01-09 10:52:19 +01:00

7c65fa7cd3 the fix

Christoph Lendenfeld referenced this pull request

2024-01-09 11:04:39 +01:00

Refactor: remove driver dependency in keying code #116823

Christoph Lendenfeld requested review from Sybren A. Stüvel 2024-01-12 10:03:28 +01:00

Sybren A. Stüvel approved these changes 2024-01-12 16:04:53 +01:00