Refactoring: Geometry Nodes: Vectors of indices for zone socket mapping #116939

Merged
Jacques Lucke merged 6 commits from mod_moder/blender:tmp_indices_in_zones into main 2024-01-09 18:16:51 +01:00

No response

_No response_
Iliya Katushenock added the
Interest
Geometry Nodes
label 2024-01-09 12:49:31 +01:00
Iliya Katushenock added 4 commits 2024-01-09 12:49:41 +01:00
cleanup
Some checks failed
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
d198f09f2f
Merge branch 'main' into tmp_indices_in_zones
Some checks failed
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
c2429957ec
Iliya Katushenock added this to the Nodes & Physics project 2024-01-09 12:53:07 +01:00
Member

Looks pretty good! The main thing I wonder is whether we should avoid the intermediate index variable in many cases.

const int output_usage_index = lf_body_inputs.append_and_get_index(&lf_output_usage);
body_fn.indices.inputs.output_usages.append(output_usage_index);
-->
body_fn.indices.inputs.output_usages.append(
  lf_body_inputs.append_and_get_index(&lf_output_usage));

Not sure if the intermediate variable name really helps. What do you think?

Looks pretty good! The main thing I wonder is whether we should avoid the intermediate index variable in many cases. ```cpp const int output_usage_index = lf_body_inputs.append_and_get_index(&lf_output_usage); body_fn.indices.inputs.output_usages.append(output_usage_index); --> body_fn.indices.inputs.output_usages.append( lf_body_inputs.append_and_get_index(&lf_output_usage)); ``` Not sure if the intermediate variable name really helps. What do you think?
Author
Member

For me this makes things shorter (less function call sequence).

For me this makes things shorter (less function call sequence).
Member

So you prefer having two separate statements?

@blender-bot build

So you prefer having two separate statements? @blender-bot build
Iliya Katushenock added 2 commits 2024-01-09 15:13:24 +01:00
delete tempolar values
Some checks failed
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
39375ce8f2
Jacques Lucke approved these changes 2024-01-09 17:38:56 +01:00
Member

@blender-bot build

@blender-bot build
Member

The issues on the buildbot all look kinda unrelated to this patch. Not sure what's going on there. Will merge this now. If the issues persist in main, we can revert/fix it there.

The issues on the buildbot all look kinda unrelated to this patch. Not sure what's going on there. Will merge this now. If the issues persist in `main`, we can revert/fix it there.
Jacques Lucke merged commit b6f8e1396b into main 2024-01-09 18:16:51 +01:00
Iliya Katushenock deleted branch tmp_indices_in_zones 2024-01-09 18:23:03 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116939
No description provided.