WIP: Fix #116029: Undo restores the wrong brush in vertex paint mode #117055

Campbell Barton · 2024-01-12T08:37:38+01:00

Campbell Barton commented

2024-01-12 08:37:38 +01:00

This is a proof of concept fix for #116029.

The change ensures ID_RECALC_COPY_ON_WRITE runs when the brush is changed,
the main down side is all callers to BKE_paint_brush_set need to check the return value and call DEG_id_tag_update(..) on the scene, when the Paint struct is from a scene.

Possible changes:

The owner ID could be passed in as an argument instead.
We could be less struct on ensuring ID_RECALC_COPY_ON_WRITE runs on the scene, only concerning ourselves with mode switching for e.g. however it seems likely that bugs like #116029 could occur, just in more obscure cases.

This is a proof of concept fix for #116029. The change ensures ID_RECALC_COPY_ON_WRITE runs when the brush is changed, the main down side is all callers to BKE_paint_brush_set need to check the return value and call DEG_id_tag_update(..) on the scene, when the `Paint` struct is from a scene. Possible changes: - The owner ID could be passed in as an argument instead. - We could be less struct on ensuring ID_RECALC_COPY_ON_WRITE runs on the scene, only concerning ourselves with mode switching for e.g. however it seems likely that bugs like #116029 could occur, just in more obscure cases.

Campbell Barton added 1 commit 2024-01-12 08:37:49 +01:00

190a185479 Fix #116029 : Undo restores the wrong brush in vertex paint mode

Campbell Barton referenced this pull request

2024-01-12 08:40:05 +01:00

Regression: Ctrl+Z breaks vertex paint #116029

Campbell Barton commented

2024-01-12 13:54:41 +01:00

Note that an earlier version of this PR seemed to work in my tests but this doesn't fix the bug.

Campbell Barton closed this pull request

2024-01-12 13:54:42 +01:00