Fix AttributeError in node groups when custom socket has no 'draw' function #117061

Merged

Jacques Lucke merged 2 commits from povmaniac/blender:povmaniac into main

2024-01-16 15:41:13 +01:00

Pedro A. commented

2024-01-12 13:05:50 +01:00

Contributor

This are a fix for the error "AttributeError: 'NodeTreeInterfaceSocket' object does not have 'draw' attribute" when the side panel in the Node Editor try to show the properties of a custom node groups created from external engines. This check is similar to the other one added on line 731 in the same space_node.py file

This are a fix for the error "AttributeError: 'NodeTreeInterfaceSocket' object does not have 'draw' attribute" when the side panel in the Node Editor try to show the properties of a custom node groups created from external engines. This check is similar to the other one added on line 731 in the same space_node.py file

Pedro A. added 2 commits 2024-01-12 13:06:00 +01:00

063c6f1e27 Fixed 'AttributeError: 'NodeTreeInterfaceSocket' object does not have 'draw' attribute in custom node groups created from external engines. This check is similar to the other one added on line 731 in the same space_node.py file

355909ef71 Merge branch 'main' of https://projects.blender.org/blender/blender into povmaniac

Iliya Katushenock added this to the Nodes & Physics project 2024-01-12 13:08:07 +01:00

Iliya Katushenock added the

label 2024-01-12 13:08:15 +01:00

Brecht Van Lommel commented

2024-01-12 14:19:15 +01:00

Owner

Note the WIP prefix means you do not consider it ready to be reviewed and are still planning changes. If that's not the case, best to remove it.

Note the WIP prefix means you do not consider it ready to be reviewed and are still planning changes. If that's not the case, best to remove it.

Brecht Van Lommel requested review from Lukas Tönne 2024-01-12 15:05:44 +01:00

Brecht Van Lommel requested review from Jacques Lucke 2024-01-12 15:05:44 +01:00

Brecht Van Lommel commented

2024-01-12 15:06:06 +01:00

Owner

I'm not sure if this is new, and if so what caused it. So just guessed some reviewers.

I'm not sure if this is new, and if so what caused it. So just guessed some reviewers.

Pedro A. commented

2024-01-12 15:19:25 +01:00

Author

Contributor

I added the WIP prefix since I don't know if this is the best approach to fix, but I can remove it.

I added the WIP prefix since I don't know if this is the best approach to fix, but I can remove it.

Pedro A. changed title from ~~WIP: fix error "AttributeError: 'NodeTreeInterfaceSocket' object does not have 'draw' attribute"~~ to fix error "AttributeError: 'NodeTreeInterfaceSocket' object does not have 'draw' attribute"

2024-01-12 18:22:43 +01:00

Lukas Tönne commented

2024-01-15 12:32:58 +01:00

Member

This seems fine to me. The draw function of socket types is optional. All internal socket types have this callback, which is why the error didn't come up earlier. It only happens for node groups with custom socket types that don't register this function. The same check is also done in the node properties sidebar panel:
3feeede7bb/scripts/startup/bl_ui/space_node.py (L732)

This seems fine to me. The `draw` function of socket types is optional. All internal socket types have this callback, which is why the error didn't come up earlier. It only happens for node groups with custom socket types that don't register this function. The same check is also done in the node properties sidebar panel: https://projects.blender.org/blender/blender/src/commit/3feeede7bb1edb5edd1e71773a6346c1d3d52668/scripts/startup/bl_ui/space_node.py#L732

Lukas Tönne changed title from ~~fix error "AttributeError: 'NodeTreeInterfaceSocket' object does not have 'draw' attribute"~~ to Fix AttributeError in node groups when custom socket has no 'draw' function

2024-01-15 12:33:59 +01:00

Lukas Tönne approved these changes 2024-01-15 12:34:13 +01:00

Jacques Lucke approved these changes 2024-01-16 15:39:30 +01:00

Jacques Lucke merged commit 6d63da40ee into main

2024-01-16 15:41:13 +01:00

Jacques Lucke referenced this issue from a commit

2024-01-16 15:41:13 +01:00

Fix: error when custom socket has no 'draw' function

Pedro A. deleted branch povmaniac

2024-01-16 16:50:18 +01:00

Hans Goudey referenced this issue from a commit

2024-01-17 16:39:23 +01:00

Fix: error when custom socket has no 'draw' function

Arye Ramaty referenced this issue from a commit

2024-01-21 15:37:41 +01:00

Fix: error when custom socket has no 'draw' function

Jonas Dichelle referenced this issue from a commit

2024-02-08 17:29:02 +01:00

Fix: error when custom socket has no 'draw' function

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117061

No description provided.