Fix #114244: Smooth operators destroy sharp edge tags #117069

Hans Goudey · 2024-01-12T17:01:15+01:00

Hans Goudey commented

2024-01-12 17:01:15 +01:00

After the replacement of auto smooth with a modifier, sharp edges are
always used, so the "shade smooth", "shade flat", and "smooth by angle"
operators cleared the attribute. However, often users spend significant
time manually tagging edges sharp, and the operators make it too easy to
lose that data.

To keep the old behavior by default, add an option called "Keep Sharp
Edges". Though this can make the operators "ineffective" at their goal
of changing the way the meshes look, or result in redundant data stored
on the mesh, it's a much safer default, especially as users get used to
the new workflow.

After the replacement of auto smooth with a modifier, sharp edges are always used, so the "shade smooth", "shade flat", and "smooth by angle" operators cleared the attribute. However, often users spend significant time manually tagging edges sharp, and the operators make it too easy to lose that data. To keep the old behavior by default, add an option called "Keep Sharp Edges". Though this can make the operators "ineffective" at their goal of changing the way the meshes look, or result in redundant data stored on the mesh, it's a much safer default, especially as users get used to the new workflow. --- ![image](/attachments/84bfe803-368b-42d6-a46a-263ab9c82315) ![image](/attachments/c86e796b-d8c7-4a37-bf49-3fc80d6d6f50)

image.png

99 KiB

image.png

38 KiB

Hans Goudey added 1 commit 2024-01-12 17:01:24 +01:00

7bd393b2f9 Fix #114244 : Smooth operators destroy sharp edge tags

After the replacement of auto smooth with a modifier, sharp edges are
always used, so the "shade smooth", "shade flat", and "smooth by angle"
operators cleared the attribute. However, often users spend significant
time manually tagging edges sharp, and the operators make it too easy to
lose that data.

To keep the old behavior by default, add an option called "Keep Sharp
Edges". Though this can make the operators "ineffective" at their goal
of changing the way the meshes look, or result in redundant data stored
on the mesh, it's a much safer default, especially as users get used to
the new workflow.

Hans Goudey added this to the Modeling project 2024-01-12 17:04:25 +01:00

Hans Goudey requested review from Campbell Barton 2024-01-12 17:04:36 +01:00

Hans Goudey requested review from Julien Kaspar 2024-01-12 17:04:37 +01:00

Campbell Barton approved these changes 2024-01-14 01:52:40 +01:00

Julien Kaspar approved these changes 2024-01-15 11:49:36 +01:00

Julien Kaspar left a comment

I think this works great on the user side! This should resolve the current issue.

Hans Goudey merged commit f9fbf832f5 into main

2024-01-15 14:05:34 +01:00

Hans Goudey deleted branch shade-keep-sharp-edges

2024-01-15 14:05:36 +01:00

Hans Goudey referenced this issue from a commit