Fix #114244: Smooth operators destroy sharp edge tags #117069

Merged
Hans Goudey merged 1 commits from HooglyBoogly/blender:shade-keep-sharp-edges into main 2024-01-15 14:05:34 +01:00
Member

After the replacement of auto smooth with a modifier, sharp edges are
always used, so the "shade smooth", "shade flat", and "smooth by angle"
operators cleared the attribute. However, often users spend significant
time manually tagging edges sharp, and the operators make it too easy to
lose that data.

To keep the old behavior by default, add an option called "Keep Sharp
Edges". Though this can make the operators "ineffective" at their goal
of changing the way the meshes look, or result in redundant data stored
on the mesh, it's a much safer default, especially as users get used to
the new workflow.


image
image

After the replacement of auto smooth with a modifier, sharp edges are always used, so the "shade smooth", "shade flat", and "smooth by angle" operators cleared the attribute. However, often users spend significant time manually tagging edges sharp, and the operators make it too easy to lose that data. To keep the old behavior by default, add an option called "Keep Sharp Edges". Though this can make the operators "ineffective" at their goal of changing the way the meshes look, or result in redundant data stored on the mesh, it's a much safer default, especially as users get used to the new workflow. --- ![image](/attachments/84bfe803-368b-42d6-a46a-263ab9c82315) ![image](/attachments/c86e796b-d8c7-4a37-bf49-3fc80d6d6f50)
Hans Goudey added 1 commit 2024-01-12 17:01:24 +01:00
After the replacement of auto smooth with a modifier, sharp edges are
always used, so the "shade smooth", "shade flat", and "smooth by angle"
operators cleared the attribute. However, often users spend significant
time manually tagging edges sharp, and the operators make it too easy to
lose that data.

To keep the old behavior by default, add an option called "Keep Sharp
Edges". Though this can make the operators "ineffective" at their goal
of changing the way the meshes look, or result in redundant data stored
on the mesh, it's a much safer default, especially as users get used to
the new workflow.
Hans Goudey added this to the Modeling project 2024-01-12 17:04:25 +01:00
Hans Goudey requested review from Campbell Barton 2024-01-12 17:04:36 +01:00
Hans Goudey requested review from Julien Kaspar 2024-01-12 17:04:37 +01:00
Campbell Barton approved these changes 2024-01-14 01:52:40 +01:00
Julien Kaspar approved these changes 2024-01-15 11:49:36 +01:00
Julien Kaspar left a comment
Member

I think this works great on the user side! This should resolve the current issue.

I think this works great on the user side! This should resolve the current issue.
Hans Goudey merged commit f9fbf832f5 into main 2024-01-15 14:05:34 +01:00
Hans Goudey deleted branch shade-keep-sharp-edges 2024-01-15 14:05:36 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117069
No description provided.