WIP: UI: Camera View Drawing #117117

Harley Acheson · 2024-01-14T21:37:30+01:00

Harley Acheson commented

2024-01-14 21:37:30 +01:00

Incomplete. Changes to drawing while in Camera View.

Current samples. Unselected camera and showing safe guides:

Selected (active) camera and also showing third guides.

Selected camera, locked to view, with center guides.

Incomplete. Changes to drawing while in Camera View. --- Current samples. Unselected camera and showing safe guides: ![image](/attachments/0736b7f4-4b3f-40dd-a867-4cdf79c14fee) Selected (active) camera and also showing third guides. ![image](/attachments/bee25d1e-3a5d-49d4-ae5d-14a95e186b58) Selected camera, locked to view, with center guides. ![image](/attachments/850a4703-b7b7-4e91-a6d2-85c21ac3439f)

image.png

802 KiB

image.png

800 KiB

image.png

803 KiB

👍 5 ❤️ 7 🎉 1

Harley Acheson added 1 commit 2024-01-14 21:37:39 +01:00

05bf66596e WIP: UI: Camera View Drawing

Incomplete. Changes to drawing while in Camera View.

Harley Acheson added this to the User Interface project 2024-01-14 21:38:27 +01:00

Nika Kutsniashvili commented

2024-01-14 22:18:20 +01:00

Weekend Harley is different beast!

Early feedback: Compositional guides and safe areas should always be fully drawn lines, and never curved. They're very technical and necessary in that form, while this looks cooler its very impractical and isn't gonna stand well with animation studios.

Weekend Harley is different beast! Early feedback: Compositional guides and safe areas should always be fully drawn lines, and never curved. They're very technical and necessary in that form, while this looks cooler its very impractical and isn't gonna stand well with animation studios.

Harley Acheson added 2 commits 2024-01-14 23:02:16 +01:00

8826b02e86 Merge branch 'main' of projects.blender.org:blender/blender into CameraView

816102bde0 remove roundness from safe guides

Harley Acheson commented

2024-01-14 23:04:03 +01:00

@nickberckley - Compositional guides and safe areas should always be fully drawn lines, and never curved.

Fixed. Thanks!!

> @nickberckley - Compositional guides and safe areas should always be fully drawn lines, and never curved. Fixed. Thanks!!

❤️ 1

Nika Kutsniashvili commented

2024-01-14 23:23:13 +01:00

Sorry it maybe images aren't updated yet but by fully drawn lines I meant like this. Safe areas can be dashed still its standard.

Some workflows and studios have very strict requirements about centering / splitting stuff in frame, and eyeballing things isnt good in that case. It can be optional but its important for some in my experience.

But I really love lines going over the border. Overscanned guides and very important too

Sorry it maybe images aren't updated yet but by fully drawn lines I meant like this. Safe areas can be dashed still its standard. ![image](/attachments/9f8b3215-d4d4-4fca-9ab6-654c9f5db197) Some workflows and studios have very strict requirements about centering / splitting stuff in frame, and eyeballing things isnt good in that case. It can be optional but its important for some in my experience. But I really love lines going over the border. Overscanned guides and very important too

image.png

820 KiB

Duarte Farrajota Ramos commented

2024-01-14 23:40:58 +01:00

First-time contributor

Are the orange corners just for visibility purposes, or are they functional somehow?
As it stands they look draggable like a gizmo to adjust something, but I don't know what they'd be useful for.
For render resolution doesn't seem adequate, render region already has gizmos. Maybe for camera Focal Length or FOV adjustment, perhaps?

Gizmos for Dolly and Roll camera would actually be useful though. I think I've seen a patch for that somewhere before.

Are the orange corners just for visibility purposes, or are they functional somehow? As it stands they look draggable like a gizmo to adjust something, but I don't know what they'd be useful for. For render resolution doesn't seem adequate, render region already has gizmos. Maybe for camera _Focal Length_ or _FOV_ adjustment, perhaps? Gizmos for _Dolly_ and _Roll_ camera would actually be useful though. I think I've seen a patch for that somewhere before.

👍 1

Harley Acheson added 1 commit 2024-01-15 01:49:53 +01:00

17c3fa11ab Changes suggested by review

Harley Acheson commented

2024-01-15 01:53:25 +01:00

@nickberckley - by fully drawn lines I meant like this

I think I stole that idea from a camera monitor display. But no worries. Fixed and I updated the captures.

@DuarteRamos

Are the orange corners just for visibility purposes, or are they functional somehow?

Trying to find some way of differentiating between active (selected) and locked, in some way that combines well. As in I don't want a red outline around a gold outline.

> @nickberckley - by fully drawn lines I meant like this I think I stole that idea from a camera monitor display. But no worries. Fixed and I updated the captures. @DuarteRamos > Are the orange corners just for visibility purposes, or are they functional somehow? Trying to find some way of differentiating between active (selected) and locked, in some way that combines well. As in I don't want a red outline around a gold outline.

👍 3

Duarte Farrajota Ramos commented

2024-01-15 10:29:45 +01:00

First-time contributor

Trying to find some way of differentiating between active (selected) and locked, in some way that combines well. As in I don't want a red outline around a gold outline.

A few alternative suggestions

To differentiate between selected active and unselected, maybe use a triangle marker like the regular camera object, colored or black

Other suggestion a small cursor icon to the side select the camera, the color indicates whether it is active or not.
Dreaming out loud, gizmos for Dolly, Roll, and FOV camera. I think it was you who proposed a similar patch for those a while ago.

Maybe to keep things consistent those should be drawn on the right side of the viewport along with other navigation gizmos, only when in camera view, rather than by the camera object frame as illustrated.

> Trying to find some way of differentiating between active (selected) and locked, in some way that combines well. As in I don't want a red outline around a gold outline. A few alternative suggestions To differentiate between selected active and unselected, maybe use a triangle marker like the regular camera object, colored or black ![20240115_092103.png](/attachments/6d5e20df-5d50-42de-ab66-3bb346126b52) ![20240115_092119.png](/attachments/b84ccbba-84a6-4bc1-85ea-ca44366e0823) Other suggestion a small cursor icon to the side select the camera, the color indicates whether it is active or not. Dreaming out loud, gizmos for Dolly, Roll, and FOV camera. I think it was you who proposed a similar patch for those a while ago. ![20240115_092356.png](/attachments/bd8274f2-fe6f-4f05-8406-8b388844d07d) Maybe to keep things consistent those should be drawn on the right side of the viewport along with other navigation gizmos, only when in camera view, rather than by the camera object frame as illustrated.

20240115_092103.png

1.7 MiB

20240115_092119.png

1.7 MiB

20240115_092356.png

1.7 MiB

Harley Acheson commented

2024-01-15 22:14:33 +01:00

@DuarteRamos - maybe use a triangle marker like the regular camera object

Oh, that might work and would be nicely consistent. Although I have been trying hard to take inspiration from camera viewfinders and monitors so it looks more familiar to camera operators.

Dreaming out loud, gizmos for Dolly, Roll, and FOV camera. I think it was you who proposed a similar patch for those a while ago.

I would love that but struggle with a way to add this for a proper camera view.

The first problem is the navigate icons on the right. We can't just remove them while in such a mode otherwise you are clicking the "Camera" one and then having it disappear. So then you think of ways of extending those to include camera operations and I only get a big mess.

A weird thing is just to imagine an icon in that list that looks like a camera viewfinder. Makes sense, you click on that and get lots of camera controls. But that would be backwards from the current perp/ortho button which shows you the current state, not the one you would enter. This means this camera view mode would be entered by clicking on an icon that somehow means "not viewfinder"? Yikes.

Another consideration is that there are quite a large number of potential camera operations that would be put there, so any plan has to potentially support that. "Dolly" forward and back, "Truck" left and right, "Pedestal" camera up and down, "Pan" to twist left/right in same location, "Tilt" up and down in the same location, "roll", and "zoom" to change focal length.

Mockups definitely welcome.

> @DuarteRamos - maybe use a triangle marker like the regular camera object Oh, that might work and would be nicely consistent. Although I have been trying hard to take inspiration from camera viewfinders and monitors so it looks more familiar to camera operators. > Dreaming out loud, gizmos for Dolly, Roll, and FOV camera. I think it was you who proposed a similar patch for those a while ago. I would love that but struggle with a way to add this for a proper camera view. The first problem is the navigate icons on the right. We can't just remove them while in such a mode otherwise you are clicking the "Camera" one and then having it disappear. So then you think of ways of extending those to include camera operations and I only get a big mess. A weird thing is just to imagine an icon in that list that looks like a camera viewfinder. Makes sense, you click on that and get lots of camera controls. But that would be backwards from the current perp/ortho button which shows you the current state, not the one you would enter. This means this camera view mode would be entered by clicking on an icon that somehow means "not viewfinder"? Yikes. Another consideration is that there are quite a large number of potential camera operations that would be put there, so any plan has to potentially support that. "Dolly" forward and back, "Truck" left and right, "Pedestal" camera up and down, "Pan" to twist left/right in same location, "Tilt" up and down in the same location, "roll", and "zoom" to change focal length. Mockups definitely welcome.

👍 2

Duarte Farrajota Ramos commented

2024-01-16 12:44:21 +01:00

First-time contributor

Oh, that might work and would be nicely consistent. Although I have been trying hard to take inspiration from camera viewfinders and monitors so it looks more familiar to camera operators.

Yours does look sleeker and more "camera like" though. The upwards arrow informs about camera direction for an object, not so useful in camera view. Maybe just making them slimmer would suffice to make them look less conspicuous.

A weird thing is just to imagine an icon in that list that looks like a camera viewfinder. Makes sense, you click on that and get lots of camera controls. But that would be backwards from the current perp/ortho button which shows you the current state, not the one you would enter. This means this camera view mode would be entered by clicking on an icon that somehow means "not viewfinder"? Yikes.

Maybe we can change the current camera icon to also show state. An outline would show User view, clicking it would activate the camera

Another consideration is that there are quite a large number of potential camera operations that would be put there, so any plan has to potentially support that. "Dolly" forward and back, "Truck" left and right, "Pedestal" camera up and down, "Pan" to twist left/right in same location, "Tilt" up and down in the same location, "roll", and "zoom" to change focal length.

Indeed there are quite a few to the point where showing all possibilities may be too much. Just call them all "Pan" and be done with it 😝

_{Image stolen from Streamsemester.com}

Joking aside, maybe leave selecting the camera to the camera frames, just make them slimmer.

Then get a bunch of camera control icons to conditionally appear when in camera view, replacing the Perspective/Ortho one. Here is a quick mockup.

One conceptual issue this rises is that all current navigation gizmos affect the viewport only, while these actually alter your scene. They'd also have to take into account any transform locks on the camera object.

> Oh, that might work and would be nicely consistent. Although I have been trying hard to take inspiration from camera viewfinders and monitors so it looks more familiar to camera operators. Yours does look sleeker and more "camera like" though. The upwards arrow informs about camera direction for an object, not so useful in camera view. Maybe just making them slimmer would suffice to make them look less conspicuous. > A weird thing is just to imagine an icon in that list that looks like a camera viewfinder. Makes sense, you click on that and get lots of camera controls. But that would be backwards from the current perp/ortho button which shows you the current state, not the one you would enter. This means this camera view mode would be entered by clicking on an icon that somehow means "not viewfinder"? Yikes. Maybe we can change the current camera icon to also show state. An outline would show _User_ view, clicking it would activate the camera > Another consideration is that there are quite a large number of potential camera operations that would be put there, so any plan has to potentially support that. "Dolly" forward and back, "Truck" left and right, "Pedestal" camera up and down, "Pan" to twist left/right in same location, "Tilt" up and down in the same location, "roll", and "zoom" to change focal length. Indeed there are quite a few to the point where showing all possibilities may be too much. Just call them all "Pan" and be done with it 😝 <img src="https://images.squarespace-cdn.com/content/v1/5e3f5968f10c10417724f328/1581891053491-I2TXUIAZTDV1DVDDLZUP/9-basic-camera-moves.jpg" width="300px"/> <sub>Image stolen from [Streamsemester.com](https://www.streamsemester.com/articles/9-basic-camera-moves) </sub> Joking aside, maybe leave selecting the camera to the camera frames, just make them slimmer. ![20240116_103526.png](/attachments/a3c444c8-dbc3-4f4c-9523-9a638ee2784f) Then get a bunch of camera control icons to conditionally appear when in camera view, replacing the Perspective/Ortho one. Here is a quick mockup. ![BlenderCameraIcons.png](/attachments/bc7362d3-da24-4dbf-a6e3-89da998a1c08) One conceptual issue this rises is that all current navigation gizmos affect the viewport only, while these actually alter your scene. They'd also have to take into account any transform locks on the camera object.

20240116_103526.png

282 KiB

BlenderCameraIcons.png

24 KiB

❤️ 2

thorn-neverwake commented

2024-01-16 21:47:14 +01:00

First-time contributor

Trying to find some way of differentiating between active (selected) and locked, in some way that combines well. As in I don't want a red outline around a gold outline.

I would prefer something far less visually dominant than brightly-colored corners. When spending a good deal of time in a camera view, doing eval on "does everything look good, shading, lighting, etc" - having bright markers in the view would be rather distracting to the task at hand.

get a bunch of camera control icons to conditionally appear when in camera view

As to "6 camera control buttons for pan / roll / tilt / etc" - feels like very much overkill, especially given that we're lacking the most basic option at present of lock camera to view.

>Trying to find some way of differentiating between active (selected) and locked, in some way that combines well. As in I don't want a red outline around a gold outline. I would prefer something *far* less visually dominant than brightly-colored corners. When spending a good deal of time in a camera view, doing eval on "does everything look good, shading, lighting, etc" - having bright markers in the view would be rather distracting to the task at hand. >get a bunch of camera control icons to conditionally appear when in camera view As to "6 camera control buttons for pan / roll / tilt / etc" - feels like very much overkill, especially given that we're lacking the most basic option at present of lock camera to view.

👍 1

Harley Acheson commented

2024-01-16 22:21:03 +01:00

@thorn-neverwake - ...prefer something far less visually dominant than brightly-colored corners...

Any suggestions? A mockup would be wonderful.

> @thorn-neverwake - ...prefer something *far* less visually dominant than brightly-colored corners... Any suggestions? A mockup would be wonderful.

thorn-neverwake commented

2024-01-16 22:50:26 +01:00

First-time contributor

First attempt at a mockup. I very much like your solid lines.

Inner lines (thirds, safe title) at 1 pixel, solid.
Outer border (lens) at 2 pixels, solid.

I do not believe the outer border needs to change color, when the camera object itself is selected. (Others might disagree, but I don't see the reason).

For "Camera is Locked to View", which I believe was the intent of the orange corners - i believe a simple non-intrusive (instead of a color change) would be to just append the work "locked" to the name of the camera.

_(As an aside - related but unrelated: having a pulldown for Safe Areas, a pulldown for Viewport Display, with another pulldown within for Compositional Guides - is more pulldowns than life needs. One gets lost trying to find the magic pulldown for Thirds)

Would be nice if at least Safe Area and Comp Guides were grouped in the same dropdown.)_

First attempt at a mockup. I very much like your solid lines. Inner lines (thirds, safe title) at 1 pixel, solid. Outer border (lens) at 2 pixels, solid. I do not believe the outer border needs to change color, when the camera object itself is selected. (Others might disagree, but I don't see the reason). For "Camera is Locked to View", which I believe was the intent of the orange corners - i believe a simple non-intrusive (instead of a color change) would be to just append the work "locked" to the name of the camera. _(As an aside - related but unrelated: having a pulldown for Safe Areas, a pulldown for Viewport Display, with another pulldown within for Compositional Guides - is more pulldowns than life needs. One gets lost trying to find the magic pulldown for Thirds) Would be nice if at least Safe Area and Comp Guides were grouped in the same dropdown.)_

camera-overlays.png

818 KiB

Harley Acheson commented

2024-01-17 21:53:31 +01:00

First attempt at a mockup.

Awesome. Thanks!

I do not believe the outer border needs to change color, when the camera object itself is selected. (Others might disagree, but I don't see the reason).

Possibly. But what is the reasoning behind that? Is the color, or change of color intrusive?

For "Camera is Locked to View", which I believe was the intent of the orange corners

In this PR as it is currently, the corner pieces change from grey to orange as the camera is selected. The red border is shown when camera is locked to view. Note that I really don't like the red at all, but that is just what we have now. Well, currently a dotted red border.

i believe a simple non-intrusive (instead of a color change) would be to just append the work "locked" to the name of the camera.

Currently the display of camera name is an option, so it isn't always shown. Of course that could change. I always thought it would be nice to show the camera name along with buttons to go to next/previous cameras.

(As an aside - related but unrelated: having a pulldown for Safe Areas, a pulldown for Viewport Display, with another pulldown within for Compositional Guides - is more pulldowns than life needs. One gets lost trying to find the magic pulldown for Thirds) Would be nice if at least Safe Area and Comp Guides were grouped in the same dropdown.)

Yes, I've noticed that too while making demos of this. It would be really nice to have those guides together.

> First attempt at a mockup. Awesome. Thanks! > I do not believe the outer border needs to change color, when the camera object itself is selected. (Others might disagree, but I don't see the reason). Possibly. But what is the reasoning behind that? Is the color, or change of color intrusive? > For "Camera is Locked to View", which I believe was the intent of the orange corners In this PR as it is currently, the corner pieces change from grey to orange as the camera is selected. The red border is shown when camera is locked to view. Note that I really don't like the red at all, but that is just what we have now. Well, currently a dotted red border. > i believe a simple non-intrusive (instead of a color change) would be to just append the work "locked" to the name of the camera. Currently the display of camera name is an option, so it isn't always shown. Of course that could change. I always thought it would be nice to show the camera name along with buttons to go to next/previous cameras. > _(As an aside - related but unrelated: having a pulldown for Safe Areas, a pulldown for Viewport Display, with another pulldown within for Compositional Guides - is more pulldowns than life needs. One gets lost trying to find the magic pulldown for Thirds) Would be nice if at least Safe Area and Comp Guides were grouped in the same dropdown.)_ Yes, I've noticed that too while making demos of this. It would be really nice to have those guides together.

thorn-neverwake commented

2024-01-18 04:29:47 +01:00

First-time contributor

Possibly. But what is the reasoning behind that? Is the color, or change of color intrusive?

It's a feeling of - just visually not necessary. If i'm view locked, then it doesn't matter if the camera is selected or not - rotating with the mouse, will move the camera. If i am not view locked, the mouse rotate action - well, it rotates the camera, but certainly not in any way that's useful.

So, the visual border of "camera is selected" - i don't see the functional reason, so it feels like just visual clutter (whether thick corners, or a different color).

If it were a decision of "Nope, we need to have something indicate it's selected" - then I would choose something rather ... not brightly shocking. A darker blue, or darker green, perhaps.

Currently the display of camera name is an option, so it isn't always shown. Of course that could change. I always thought it would be nice to show the camera name along with buttons to go to next/previous cameras.

Actually, when I did the label on the mockup - it did occur to me that the camera name might not be present, if the user unclicked that box. So i debated what label to type. Perhaps

CAMERA 1 | LOCKED (if camera name activated)
LOCKED (and if not)

> Possibly. But what is the reasoning behind that? Is the color, or change of color intrusive? It's a feeling of - just visually not necessary. If i'm view locked, then it doesn't matter if the camera is selected or not - rotating with the mouse, will move the camera. If i am not view locked, the mouse rotate action - well, it rotates the camera, but certainly not in any way that's useful. So, the visual border of "camera is selected" - i don't see the functional reason, so it feels like just visual clutter (whether thick corners, or a different color). If it were a decision of "Nope, we need to have something indicate it's selected" - then I would choose something rather ... not brightly shocking. A darker blue, or darker green, perhaps. > Currently the display of camera name is an option, so it isn't always shown. Of course that could change. I always thought it would be nice to show the camera name along with buttons to go to next/previous cameras. Actually, when I did the label on the mockup - it did occur to me that the camera name might not be present, if the user unclicked that box. So i debated what label to type. Perhaps CAMERA 1 | LOCKED (if camera name activated) LOCKED (and if not)

This pull request has changes conflicting with the target branch.

source/blender/editors/space_view3d/drawobject.cc
source/blender/editors/space_view3d/view3d_intern.h

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u CameraView:Harley-CameraView

git checkout Harley-CameraView

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: UI: Camera View Drawing #117117

Checkout