Fix #117108: Memory leak report with static select engine data #117147

Hans Goudey · 2024-01-15T21:53:10+01:00

Hans Goudey commented

2024-01-15 21:53:10 +01:00

Now that the select engine data uses non-trivial objects in its global
data, storing it at the global scope causes trouble due to arbitrary
construction and destruction order. Instead use the construct on first use
idiom to make the order clear. Though this struct probably shouldn't be
static at all, it does simplify memory management as well, it's nice to
remove the need to manually clear the arrays.

Now that the select engine data uses non-trivial objects in its global data, storing it at the global scope causes trouble due to arbitrary construction and destruction order. Instead use the construct on first use idiom to make the order clear. Though this struct probably shouldn't be static at all, it does simplify memory management as well, it's nice to remove the need to manually clear the arrays.

Hans Goudey added 1 commit 2024-01-15 21:53:19 +01:00

Fix: Memory leak report with static select engine data 55228a5d1d

Now that the select engine data uses non-trivial objects in its global
data, storing the data at the global scope causes more trouble than it's
worth. Instead use the construct on first use idiom to make it clear
when the data is first constructed or destructed. Though this struct
probably shouldn't be static at all, it does simplify memory management
as well, removing the need to manually clear the arrays causing the issue.

Germano Cavalcante approved these changes 2024-01-15 22:41:17 +01:00

Germano Cavalcante left a comment

It's a little strange, but it seems to work well. Even with --debug and WITH_CXX_GUARDEDALLOC Blender's leak detector does not detect the memory of these arrays.

A little unsure if this is just hiding the problem. But it seems to be an efficient solution.

Maybe there could be a comment explaining why this is so.

It's a little strange, but it seems to work well. Even with `--debug` and `WITH_CXX_GUARDEDALLOC` Blender's leak detector does not detect the memory of these arrays. A little unsure if this is just hiding the problem. But it seems to be an efficient solution. Maybe there could be a comment explaining why this is so.

Hans Goudey commented

2024-01-16 01:53:17 +01:00

Maybe there could be a comment explaining why this is so.

Not sure, it would just be a description of how static variables work, and this pattern is used commonly across Blender code for this reason.

>Maybe there could be a comment explaining why this is so. Not sure, it would just be a description of how static variables work, and this pattern is used commonly across Blender code for this reason.

Hans Goudey merged commit 17040a0b24 into main

2024-01-16 01:55:27 +01:00

Hans Goudey deleted branch fix-select-engine-global-leak

2024-01-16 01:55:29 +01:00

Hans Goudey referenced this issue from a commit

2024-01-16 01:55:32 +01:00

Fix #117108: Memory leak report with static select engine data

Kazashi Yoshioka referenced this issue from a commit

2024-01-16 14:55:05 +01:00

Fix #117108: Memory leak report with static select engine data

Arye Ramaty referenced this issue from a commit

2024-01-21 15:37:41 +01:00