Fix: incorrect configuration of imbuf used for render passes #117184

Sergey Sharybin · 2024-01-16T20:30:22+01:00

Sergey Sharybin commented

2024-01-16 20:30:22 +01:00

Some areas in Blender expect planes to set to a proper value, and also the float buffer color space is checked to make decisions. This PR contains 2 commits which addresses these two aspects.

In practice this solves assert failure in the GPU compositor code which checks expected and actual imbuf texture format when viewing Depth pass coming from multilayer EXR (it probably also fixes assert when the pass comes from the render result, but that is a bit more tricky yo check in the debug build).

Some areas in Blender expect planes to set to a proper value, and also the float buffer color space is checked to make decisions. This PR contains 2 commits which addresses these two aspects. In practice this solves assert failure in the GPU compositor code which checks expected and actual imbuf texture format when viewing Depth pass coming from multilayer EXR (it probably also fixes assert when the pass comes from the render result, but that is a bit more tricky yo check in the debug build).

Sergey Sharybin added 2 commits 2024-01-16 20:30:31 +01:00

02633498fd Fix incorrect number of planes for ImBuf used for render passes

Set the number of planes based on the number of pass channels.

If the pass contains 2 passes or more than 4 passes set the number
of planes to the previously used value of 32.

This is needed because quite some areas check for the number of
planes for various optimizations. For example, this is one of the
factors which make IMB_create_gpu_texture() to choose the texture
format. If the number of planes for the depth pass is set to the
previously used this function will never consider using single
channel GPU texture.

Unfortunately, this change is not enough to make the GPU texture
to use single channel format as the color space of the image
buffer is also checked, and that is nullptr which means scene linear.

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

3208a1818a Render: Set non-color colorspace for ImBuf of data passes

This allows code outside of the render pipeline to make proper
decisions about how the imbuf of render passes are to be handled.

For example, IMB_create_gpu_texture() will now properly select
single channel grayscale texture format for depth pass coming from
multilayer EXR, additionally solving assert in the GPU compositor
code which verifies expected and actual imbuf texture format.

Sergey Sharybin commented

2024-01-16 20:32:07 +01:00

@blender-bot build

Sergey Sharybin added the

Module

Render & Cycles

label 2024-01-16 20:32:16 +01:00

Sergey Sharybin requested review from Brecht Van Lommel 2024-01-16 20:32:31 +01:00

Hans Goudey changed title from ~~Fix incorrect configuration of imbuf used for render passes~~ to Fix: incorrect configuration of imbuf used for render passes

2024-01-16 20:45:51 +01:00

Brecht Van Lommel approved these changes 2024-01-16 20:49:50 +01:00

Sergey Sharybin merged commit 11c2028795 into main

2024-01-17 10:03:09 +01:00

Sergey Sharybin referenced this issue from a commit

2024-01-17 10:03:10 +01:00

Render: Set non-color colorspace for ImBuf of data passes

Sergey Sharybin deleted branch fix_render_result_planes

2024-01-17 10:03:11 +01:00

Hans Goudey referenced this issue from a commit

2024-01-17 16:39:23 +01:00

Render: Set non-color colorspace for ImBuf of data passes