Text Editor: Search text highlight #117254

Guillermo Venegas · 2024-01-17T20:12:08+01:00

Guillermo Venegas commented

2024-01-17 20:12:08 +01:00

The search string is highlighted in all occurrences
in the open text file, navigation between searches
is also improved (reverse navigation is now allowed).

Also when searching is enabled for all text datablocks,
a panel is displayed with the overall count of text occurrences.

The search panel have been modified to give a modern find and replace
user experience, but icons can be improved.

Part of #115428

Performance impact

If search is active while editing text, it does not seem to significantly affect performance
Only for cases that text are too large (more that 20k lines and with short search string):

Reopen from #115417 since had a lot of merge problems

The search string is highlighted in all occurrences in the open text file, navigation between searches is also improved (reverse navigation is now allowed). Also when searching is enabled for all text datablocks, a panel is displayed with the overall count of text occurrences. The search panel have been modified to give a modern find and replace user experience, but icons can be improved. Part of https://projects.blender.org/blender/blender/issues/115428 __________________ <video src="/attachments/9b3a35d7-6103-453e-bcd6-aaa0c1b4b4d3" title="2024-01-17 13-03-51.mp4" controls></video> __________________ ### Performance impact If search is active while editing text, it does not seem to significantly affect performance Only for cases that text are too large (more that 20k lines and with short search string): <video src="https://projects.blender.org/attachments/1d72db7c-901f-4e6e-9748-4b5446054abe" controls></video> __________________ Reopen from https://projects.blender.org/blender/blender/pulls/115417 since had a lot of merge problems

2024-01-17 13-03-51.mp4

8.5 MiB

❤️ 2

Guillermo Venegas added 2 commits 2024-01-17 20:12:15 +01:00

e06543a801 init

4d63d93c54 add missing notification

Campbell Barton commented

2024-01-18 03:07:58 +01:00

Given the complexity this adds to the code, I'd rather not support this functionality.

In the future it would be good to discuss features before spending time on development.

Given the complexity this adds to the code, I'd rather not support this functionality. In the future it would be good to discuss features before spending time on development.

Duarte Farrajota Ramos commented

2024-01-18 11:32:57 +01:00

First-time contributor

This would be a really welcome addition though

This pull request has changes conflicting with the target branch.

scripts/startup/bl_ui/space_text.py
source/blender/editors/space_text/space_text.cc
source/blender/editors/space_text/text_ops.cc

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u text-search-2:guishe-text-search-2

git checkout guishe-text-search-2

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Text Editor: Search text highlight #117254

Performance impact

Checkout