Text Editor: Search text highlight #117254

Open
Guillermo Venegas wants to merge 2 commits from guishe/blender:text-search-2 into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Contributor

The search string is highlighted in all occurrences
in the open text file, navigation between searches
is also improved (reverse navigation is now allowed).

Also when searching is enabled for all text datablocks,
a panel is displayed with the overall count of text occurrences.

The search panel have been modified to give a modern find and replace
user experience, but icons can be improved.

Part of #115428



Performance impact

If search is active while editing text, it does not seem to significantly affect performance
Only for cases that text are too large (more that 20k lines and with short search string):


Reopen from #115417 since had a lot of merge problems

The search string is highlighted in all occurrences in the open text file, navigation between searches is also improved (reverse navigation is now allowed). Also when searching is enabled for all text datablocks, a panel is displayed with the overall count of text occurrences. The search panel have been modified to give a modern find and replace user experience, but icons can be improved. Part of https://projects.blender.org/blender/blender/issues/115428 __________________ <video src="/attachments/9b3a35d7-6103-453e-bcd6-aaa0c1b4b4d3" title="2024-01-17 13-03-51.mp4" controls></video> __________________ ### Performance impact If search is active while editing text, it does not seem to significantly affect performance Only for cases that text are too large (more that 20k lines and with short search string): <video src="https://projects.blender.org/attachments/1d72db7c-901f-4e6e-9748-4b5446054abe" controls></video> __________________ Reopen from https://projects.blender.org/blender/blender/pulls/115417 since had a lot of merge problems
Guillermo Venegas added 2 commits 2024-01-17 20:12:15 +01:00

Given the complexity this adds to the code, I'd rather not support this functionality.

In the future it would be good to discuss features before spending time on development.

Given the complexity this adds to the code, I'd rather not support this functionality. In the future it would be good to discuss features before spending time on development.
First-time contributor

This would be a really welcome addition though

This would be a really welcome addition though
This pull request has changes conflicting with the target branch.
  • scripts/startup/bl_ui/space_text.py
  • source/blender/editors/space_text/space_text.cc
  • source/blender/editors/space_text/text_ops.cc

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u text-search-2:guishe-text-search-2
git checkout guishe-text-search-2
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117254
No description provided.