Anim: Add Sharpness to Ease operator #117287
No reviewers
Sybren A. Stüvel
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#117287
Loading…
Reference in New Issue
No description provided.
Delete Branch "ChrisLend/blender:graph_slider_ease_ease"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR extends the existing
Easeoperator with a sharpness property.This means it has two parameters:
During modal operation it is possible to switch the slider between those two by pressing
TAB.Test Build
https://builder.blender.org/download/patch/PR117287/
This basically merges the "Ease Ease" operator from Ares Deveaux #106525: Animation: ease-ease slider with the existing "Ease" operator.
Compared to the original PR I changed the sigmoid function a bit to avoid creating jumps in the animation at the ends of the segments.
Visual comparison between the old and new Ease operator (old result in gray). With the new operator to match the old one, the "Curve Bend" needs to be either -1 or 1. After that you can play with the "Sharpness" parameter.
@blender-bot package
Package build started. Download here when ready.
The code LGTM, apart from a seemingly out of date comment.
Let's wait with landing this PR until we know whether it can replace the Ease operator.
@ -704,1 +704,4 @@static float s_curve(const float x, const float width, const float shift){/* Formula for 'S' curve we use for the "ease" sliders. The shift values move the curve verticalyThis comment seems to be out of sync with the parameters.
Love the new ease to ease slider! Would it be possible to add a button to toggle the width setting while using the slider instead of having to apply the ease, then open up the menu? One of the benefits of the old ease slider is that with its easing at 0 you can quickly make a bunch of keys move in a linear speed with one click. With the ease to ease slider, you need to apply the operator, open the menu, and turn the width down to 0. I'd imagine having a button to toggle the width would make that faster.
Cheers!
@Raymond-Luc thanks for the feedback. I wasn't aware that the
Easeoperator is used to align keys in a straight line.Toggling the width is a bit tricky. Since it's a factor it would ideally be on the scroll wheel, but that would leave out tablet users.
We could add two buttons, one for shrinking the width and one for growing it.
Or have a button that toggles the property affected by the slider. E.g. it would default to "Sharpness" but by pressing
Dit would then affect "Width". We've never done such a concept before though.Considering BCon3 (feature freeze) is approaching, we might want to keep both operators so we have a chance of landing this.
in the recent Animation & Rigging module meeting we decided to postpone this feature to 4.2 so we can have time to implement a functionality that toggles which property the slider affects.
E.g. by default it would affect the sharpness, but pressing TAB it would affect the width. The sharpness value would stay at the current value.
Anim: Ease to Ease operatorto Anim: Add Sharpness to Ease operator@blender-bot package
@Raymond-Luc a new build for you to test. Pressing
TABduring the modal operation now switches which property the slider affectsPackage build started. Download here when ready.
I like the
TABto switch between the parameters. It feels intuitive to me, as typically in some form you'd also use the same key to toggle the input focus between different parameters.When changing the sharpness, it goes up to
1000%. That's quite different from the PR description, where it's shown as a factor (4.0). Are these numerically equivalent? As in, is the4.0image actually a400%sharpness? In that case I think it's fine, just want to check.What are the numbers for, actually? 0% sharpness being linear makes sense to me, but what does 100% represent?
Good point, changed it so that with sharpness we have no unit and it goes from 0.0 to 10.0
Hey Christoph!
Sorry for the delay, its been a busy past week haha. I really like the new changes you've implemented! I did run into a issue where if you are in the modify sharpness part of the tool and hold ctrl while moving the slider to the left, I think you end up diving the curve by 0.
Steps to reproduce:
added a video and blendfile with the issue.
@Raymond-Luc thanks for testing and finding that issue.
It's actually a bug with the slider itself, so I made a separate PR to fix it (which can land in 4.1)
#119367: Fix: Slider not respecting bounds when snapping to increments
Also on a tangent: You mentioned you quickly want to align curves in a line. The quickest way to do this now is to use
Push-Pulland slide all the way to the left.@blender-bot package
new build with the divide by 0 issue now resolved
Package build started. Download here when ready.
As discussed in a module meeting (a while ago), it would be nice to show which setting is being modified:
This is for a followup commit, as it would impact all slider operators. Just wanted to mention it here to have it recorded in this PR ;-)