Fix #117280: Cycles: Lights from instancer not working randomly #117301

Sergey Sharybin · 2024-01-18T19:39:57+01:00

Sergey Sharybin commented

2024-01-18 19:39:57 +01:00

The issue was caused by light and shadow linking runtime data not
evaluated first time for lights linked to scene indirectly.

Simple solution is to hook up shading component to the instance
operation, so that visibility flag is properly propagated to the
shading component, and the light linking is evaluated.

Do it as non-flushing operation to prevent possible unwanted
re-evaluated of instancers.

The issue was caused by light and shadow linking runtime data not evaluated first time for lights linked to scene indirectly. Simple solution is to hook up shading component to the instance operation, so that visibility flag is properly propagated to the shading component, and the light linking is evaluated. Do it as non-flushing operation to prevent possible unwanted re-evaluated of instancers.

Sergey Sharybin added 4 commits 2024-01-18 19:40:05 +01:00

bce75bd4a2 Depsgraph: Add explicit object shading exit operation

Currently there is no functional changes.

In the future it allows to more easily hook the shading component
to other nodes to ensure the visibility flow.

Note that since the operation is not used by any relation it will
appear disconnected in the graphviz debugger. This is due to the
current behavior of deg_graph_remove_unused_noops().

4b38a353a2 Cleanup: Make duplication node and ocmponent name more clear

Follow the new terminology of instancing, and make it clear what
side it is (instancer or instancee).

4f761b0810 Cleanup: Simplify tracking of relations for instancing

Instead of having a set of hardcoded rules in the collection and
object instance collection builder introduce new node on object's
INSTANCING component which is to be hooked up to the node which is
duplicating the object.

Should be no functional changes.

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

1424cc7ab8 Fix #117280 : Cycles: Lights from instancer not working randomly

The issue was caused by light and shadow linking runtime data not
evaluated first time for lights linked to scene indirectly.

Simple solution is to hook up shading component to the instance
operation, so that visibility flag is properly propagated to the
shading component, and the light linking is evaluated.

Do it as non-flushing operation to prevent possible unwanted
re-evaluated of instancers.

Sergey Sharybin commented

2024-01-18 19:41:25 +01:00

@blender-bot build

Sergey Sharybin merged commit 1dfb41bc75 into main

2024-01-19 09:25:07 +01:00

Sergey Sharybin deleted branch fix_light_linking

2024-01-19 09:25:09 +01:00

Sergey Sharybin referenced this issue from a commit

2024-01-19 09:25:12 +01:00

Fix #117280: Cycles: Lights from instancer not working randomly

Arye Ramaty referenced this issue from a commit

2024-01-21 15:37:42 +01:00