Core: rename Session UUID to Session UID #117350

Jacques Lucke · 2024-01-19T21:11:22+01:00

Jacques Lucke commented

2024-01-19 21:11:22 +01:00

UUID generally stands for "universally unique identifier". The session identifier that we use is neither universally unique, nor does it follow the standard. Therefor, the term "session uuid" is confusing and should be replaced.

In #116888 we briefly talked about a better name and ended up with "session uid". The reason for "uid" instead of "id" is that the latter is a very overloaded term in Blender already.

This patch changes all uses of "uuid" to "uid" where it's used in the context of a "session uid". It's not always trivial to see whether a specific mention of "uuid" refers to an actual uuid or something else. Therefore, I might have missed some renames. I can't think of an automated way to differentiate the case.

BMesh also uses the term "uuid" sometimes in a the wrong context (e.g. UUIDFaceStepItem) but there it also does not mean "session uid", so it's not changed by this patch.

`UUID` generally stands for "[universally unique identifier](https://en.wikipedia.org/wiki/Universally_unique_identifier)". The session identifier that we use is neither universally unique, nor does it follow the standard. Therefor, the term "session uuid" is confusing and should be replaced. In #116888 we briefly talked about a better name and ended up with "session uid". The reason for "uid" instead of "id" is that the latter is a very overloaded term in Blender already. This patch changes all uses of "uuid" to "uid" where it's used in the context of a "session uid". It's not always trivial to see whether a specific mention of "uuid" refers to an actual uuid or something else. Therefore, I might have missed some renames. I can't think of an automated way to differentiate the case. BMesh also uses the term "uuid" sometimes in a the wrong context (e.g. `UUIDFaceStepItem`) but there it also does not mean "session uid", so it's *not* changed by this patch.

Jacques Lucke added 2 commits 2024-01-19 21:11:34 +01:00

4daff70589 rename session-uuid to session-uid

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

26ffd6bbf4 rename more places

Jacques Lucke requested review from Brecht Van Lommel 2024-01-19 21:12:27 +01:00

Jacques Lucke requested review from Bastien Montagne 2024-01-19 21:12:27 +01:00

Jacques Lucke commented

2024-01-19 21:23:56 +01:00

@blender-bot build

Bastien Montagne approved these changes 2024-01-19 21:51:15 +01:00

Bastien Montagne left a comment

Only did a quick overview check, changes LGTM (besides the typo noted below). clang-format also seems to complain here (unless it's not related to the patch itself).

No need for further review from me once these details are fixed.

Nice to get rid of this long-standing semantic glitch in our code!

Only did a quick overview check, changes LGTM (besides the typo noted below). clang-format also seems to complain here (unless it's not related to the patch itself). No need for further review from me once these details are fixed. Nice to get rid of this long-standing semantic glitch in our code!

source/blender/sequencer/intern/strip_relations.cc Outdated

						
				@ -419,3 +418,1 @@

				  const SessionUUID *session_uuid = &seq->runtime.session_uuid;

				  if (!BLI_session_uuid_is_generated(session_uuid)) {

				    printf("Sequence %s does not have UUID generated.\n", seq->name);

				  GSet *used_uuds = (GSet *)user_data;