UI: Show folders when selecting font #117389

Richard Antalik · 2024-01-21T21:05:46+01:00

Richard Antalik commented

2024-01-21 21:05:46 +01:00

On some systems, fonts may be categorized in folders, in which case user
sees nothing by default.

For example on my system:

On some systems, fonts may be categorized in folders, in which case user sees nothing by default. For example on my system: ![Screenshot_2024-01-21_21-05-11.png](/attachments/3151fbfc-b6c6-4e51-96d9-f4283d477bde)

👍 2

Richard Antalik added 1 commit 2024-01-21 21:05:58 +01:00

aaa4677356 UI: Show folders when selecting font

On some systems, fonts may be categorized in folders, in which case user
sees nothing by default.

Richard Antalik requested review from Harley Acheson 2024-01-21 21:07:57 +01:00

TheRedWaxPolice commented

2024-01-21 21:18:54 +01:00

First-time contributor

Yo, error "Image not found"...

Harley Acheson commented

2024-01-21 21:28:09 +01:00

Oh I'm guessing this is Linux?

In this situation where there are subfolders of fonts, how does it look to also show recursive so see them all in the same list?

diff --git a/source/blender/editors/space_buttons/buttons_ops.cc b/source/blender/editors/space_buttons/buttons_ops.cc
index ea711d27fba..8738942e848 100644
--- a/source/blender/editors/space_buttons/buttons_ops.cc
+++ b/source/blender/editors/space_buttons/buttons_ops.cc
@@ -351,6 +351,8 @@ static int file_browse_invoke(bContext *C, wmOperator *op, const wmEvent *event)
       }
       RNA_boolean_set(op->ptr, "filter_font", true);
       RNA_enum_set(op->ptr, "display_type", FILE_IMGDISPLAY);
+      RNA_boolean_set(op->ptr, "filter_folder", true);
+      RNA_int_set(op->ptr, "recursion_level", 2);
       RNA_enum_set(op->ptr, "sort_method", FILE_SORT_ALPHA);
     }
     else {

Oh I'm guessing this is Linux? In this situation where there are subfolders of fonts, how does it look to also show recursive so see them all in the same list? ``` diff --git a/source/blender/editors/space_buttons/buttons_ops.cc b/source/blender/editors/space_buttons/buttons_ops.cc index ea711d27fba..8738942e848 100644 --- a/source/blender/editors/space_buttons/buttons_ops.cc +++ b/source/blender/editors/space_buttons/buttons_ops.cc @@ -351,6 +351,8 @@ static int file_browse_invoke(bContext *C, wmOperator *op, const wmEvent *event) } RNA_boolean_set(op->ptr, "filter_font", true); RNA_enum_set(op->ptr, "display_type", FILE_IMGDISPLAY); + RNA_boolean_set(op->ptr, "filter_folder", true); + RNA_int_set(op->ptr, "recursion_level", 2); RNA_enum_set(op->ptr, "sort_method", FILE_SORT_ALPHA); } else { ```

Richard Antalik commented

2024-01-21 21:52:09 +01:00

Yo, error "Image not found"...

Interesting... Will try to fix, but not sure what to believe.

Oh I'm guessing this is Linux?

In this situation where there are subfolders of fonts, how does it look to also show recursive so see them all in the same list?

Three recursions is not quite enough, but that would be better solution probably...

Perhaps recursion + folders would (+ optionally sorting fonts first) would provide better UX?

> Yo, error "Image not found"... Interesting... Will try to fix, but not sure what to believe. ![Screenshot_2024-01-21_21-46-16.png](/attachments/d746238e-6600-4a3d-b48f-1ee5ac7f050e) > Oh I'm guessing this is Linux? > > In this situation where there are subfolders of fonts, how does it look to also show recursive so see them all in the same list? Three recursions is not quite enough, but that would be better solution probably... ![Screenshot_2024-01-21_21-51-13.png](/attachments/4e8e2ad3-f2cd-42df-ad8c-1df1dd4bd0c1) Perhaps recursion + folders would (+ optionally sorting fonts first) would provide better UX?

Screenshot_2024-01-21_21-46-16.png

47 KiB

Screenshot_2024-01-21_21-51-13.png

65 KiB

Screenshot_2024-01-21_21-05-11.png

24 KiB

Harley Acheson commented

2024-01-21 21:59:29 +01:00

Sorry, I only use Windows. But those captures makes me think that what you want is recursions on but folders off. That way you'd see all the fonts together but without the redundant folders.

TheRedWaxPolice commented

2024-01-21 22:17:22 +01:00

First-time contributor

Interesting... Will try to fix, but not sure what to believe.

It's fixed now...
Gitea has a bug... you probably copied and pasted the image from clipboard directly in the text field, right?
When you do that, the image only show up for you... on everyone else it says "not found"...

> Interesting... Will try to fix, but not sure what to believe. It's fixed now... Gitea has a bug... you probably copied and pasted the image from clipboard directly in the text field, right? When you do that, the image only show up for you... on everyone else it says "not found"...

Harley Acheson commented

2024-01-22 20:47:19 +01:00

@iss

My gut feeling is that you'd want either filter_folder or recursion_level, but not both. But I am happy with whatever you prefer. Just nice to have someone with Linux looking at this.

@iss My gut feeling is that you'd want either `filter_folder` or `recursion_level`, but not both. But I am happy with whatever you prefer. Just nice to have someone with Linux looking at this.

Richard Antalik commented

2024-01-23 16:05:07 +01:00

Sorry, I only use Windows. But those captures makes me think that what you want is recursions on but folders off. That way you'd see all the fonts together but without the redundant folders.

It's not linux only issue technically. Even though on windows, you would probably want to have your fonts installed for whole system. But if you for whatever reason don't do that, you need to navigate to your fonts, so you want to see the folders. That is my reasoning at least.

@JulianEisel , @lichtwerk Can you share your opinion?

> Sorry, I only use Windows. But those captures makes me think that what you want is recursions on but folders off. That way you'd see all the fonts together but without the redundant folders. It's not linux only issue technically. Even though on windows, you would probably want to have your fonts installed for whole system. But if you for whatever reason don't do that, you need to navigate to your fonts, so you want to see the folders. That is my reasoning at least. @JulianEisel , @lichtwerk Can you share your opinion?

Philipp Oeser commented

2024-01-23 17:00:35 +01:00

No strong opinion here, first I thought to be careful with recursion level (who knows if someone browses the root folder), but I think we are doing it elsewhere as well.

Since this can be arbitrary though (unless you set it extremely high as FILE_SELECT_MAX_RECURSIONS), this could still fail, so I would definitely include folders (probably without recursion).

Everything is better than the current default :)

No strong opinion here, first I thought to be careful with recursion level (who knows if someone browses the root folder), but I think we are doing it elsewhere as well. Since this can be arbitrary though (unless you set it extremely high as `FILE_SELECT_MAX_RECURSIONS`), this _could_ still fail, so I would definitely include folders (probably without recursion). Everything is better than the current default :)

Harley Acheson commented

2024-01-23 17:03:26 +01:00

With filter_folder and without recursions is probably the simplest and safest route.

Harley Acheson approved these changes 2024-01-29 00:16:30 +01:00

Richard Antalik merged commit 048cece74d into main

2024-01-31 18:56:34 +01:00

Richard Antalik referenced this issue from a commit

2024-01-31 18:56:36 +01:00

UI: Show folders when selecting font

Richard Antalik deleted branch font-ui-folder

2024-01-31 18:56:36 +01:00

Harley Acheson added this to the User Interface project 2024-01-31 22:07:02 +01:00