UI: Update default mask icon #117467
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#117467
Loading…
Reference in New Issue
No description provided.
Delete Branch "Sean-Kim/blender:102585-mask-icon"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Based on the design of #102585.
This PR replaces the MOD_MASK icon with the CLIP_UVDEHLT icon to better communicate the intent of masking across many areas of Blender. It also changes the Grease Pencil
invert
icons to avoid conflicts with the CLIPUV_DEHLT & CLIPUV_HLT now being used to indicate mask usage for Grease Pencil layers.Changes
Automasking
Top Bar
Grease Pencil
Image Edit
Modifier
Addresses part of #102585
So far this looks good to me.
The only unfortunate thing is that the new mask modifier icon has more weight when compared to all other modifier icons. It sticks out and breaks visual cohesion a bit.
But IMO it's a minor issue.
This PR could also get the other changes for completion of #102585.
@JulienKaspar I decided to split this work and the work to get the toggleable state for the Auto-Masking icon into separate PRs since they seemed to be different enough issues and easier to review separately - if you think it's more beneficial for them to be shipped together then I can plan on including it here instead.
I'm fine with it being separated into two PRs.
But it's good to keep in mind that having a mask icon with an on & off state is the primary reason behind updating the icon.
In that case there are still a couple things missing in this PR:
CLIPUV_DEHLT
andCLIPUV_HLT
for thelayers.use_mask_layer
toggle.select_intersect
andselect_subtract
icons for thelayers.mask_layers.invert
toggleUI: Replace MOD_MASK icon with CLIP_UVDEHLTto UI: Update default mask iconUpdated the PR with the changes to the Grease Pencil layers & mask invert toggle. Added a few gifs of the toggle into the description.
As a note, the icons being used to match the visual representation in the original task are
SELECT_INTERSECT
andSELECT_DIFFFERENCE
To me this PR is complete and looks great!
Especially for the grease pencil masks and layers it fits in very well and communicates the functionality much better than the original.
Thanks for working on it!
Looking at the code it seems the mask icon is still called
CLIPUV_DEHLT
, shouldn't that be updated as part of this PR?@pablovazquez , Had a brief talk with @Harley in the ui module chat a week or so ago about this and he recommended keeping the icon names static to avoid disruption to scripters:
I see. So is it just changing which icons are used internally?
There seem to be many (unintended?) changes:
release/datafiles/alert_icons.png
is wider evenIs the change to
blender_icons.svg
even needed then?An alternative could be to just change any usage of
ICON_MOD_MASK
toICON_CLIPUV_HLT
instead of changing the blender_icons.svg, though I assume the reasoning is to ensure the icon is consistent for future usage and to reduce confusion on naming for contributors - @JulienKaspar would have to weigh in more on that.As for the unintended changes, that's something I didn't notice with my PR; I'll investigate this more but I'm currently clueless as to why they happened. Thanks for pointing them out.
@pablovazquez @Harley I would be fine with either way. I think you should decide on this.
Keeping the icon names for consistency on addons is good.
But I'd also be fine with renaming icons like
ICON_CLIPUV_HLT
toICON_MASK_HLT
for clarity.Updated to fix the unintended changes, I had to manually revert the
icon32_mod_explode.dat
andprvicons.png
- still unsure at the moment as to why they change on my laptop when runningmake icons
, but I put that into a separate issue for now (#117683).Thanks for the update!
It's good to go now, but I would like a confirmation from the Grease Pencil team that this icon change is ok with them. cc: @mendio
looks great, from our side is ok to go ahead with the icon change
Great! Design-wise this is ready.
@Harley do you see anything in the code that needs changing or would it be good to go?
No, the code changes are fine. And glad we are not renaming any icons. We have so many with bad names but it is a burden on addon makers if the names change.
However....
I would like to be the person who merges this so I can make sure there are no versioning issues with the SVG with recent changes and some pending changes. In fact I might do a separate merge of all the icon changes together so there are less incremental changes to that file.
I'd be doing this today.
Thanks! All yours!
b13f619dfa
todea0e36f5f
Thanks @Sean-Kim !!