Fix #117520: Data Transfer modifier not working with Vertex Groups #117538

Philipp Oeser · 2024-01-26T11:23:21+01:00

Philipp Oeser commented

2024-01-26 11:23:21 +01:00

This was the case for custom normals.

There was an optimization in 91b4f9f1f6 that was skipping computation of
existing normals if the Mix Factor in the UI was at 1.0 (under the
assumption that in this case no old normals would be needed.

Problem is that the resulting mix factor is the product of the Mix
Factor in the UI and the weights, so just doing the check as in the
culprit commit is not enough.

Need to consider if weights are used.

This was the case for custom normals. There was an optimization in 91b4f9f1f6 that was skipping computation of existing normals if the Mix Factor in the UI was at 1.0 (under the assumption that in this case no old normals would be needed. Problem is that the resulting mix factor is the product of the Mix Factor in the UI and the weights, so just doing the check as in the culprit commit is not enough. Need to consider if weights are used.

Philipp Oeser added 1 commit 2024-01-26 11:23:36 +01:00

c92927bf99 Fix #117520 : Data Transfer modifier not working with Vertex Groups

This was the case for custom normals.

There was an optimization in 91b4f9f1f6 that was skipping computation of
existing normals if the Mix Factor in the UI was at 1.0 (under the
assumption that in this case no old normals would be needed.

Problem is that the resulting mix factor is the product of the Mix
Factor in the UI and the weights, so just doing the check as in the
culprit commit is not enough.

Need to consider if weights are used.

Philipp Oeser requested review from Hans Goudey 2024-01-26 11:23:49 +01:00

Philipp Oeser added this to the Modeling project 2024-01-26 11:23:56 +01:00

Hans Goudey approved these changes 2024-01-26 15:02:21 +01:00

Hans Goudey left a comment

Thanks! I'm glad it was something simple like this.

source/blender/blenkernel/intern/data_transfer.cc Outdated

						
				@ -1061,3 +1061,3 @@

				            &me_dst->corner_data, CD_NORMAL, CD_SET_DEFAULT, me_dst->corners_num));

				      }

				      if (mix_factor != 1.0f) {

				      if ((mix_factor != 1.0f) || mix_weights) {