UI: TreeView Changes #117654

Merged
Harley Acheson merged 3 commits from Harley/blender:TreeViewLineChanges into main 2024-02-02 19:40:37 +01:00
Member

TreeView changes including change of disclosure icon, decreased indent,
indented items without children, lowered line opacity.


Incorporating changes since UI Module. Chevron disclosure and without elbow, but with decreased indent.

TreeView.gif

TreeView changes including change of disclosure icon, decreased indent, indented items without children, lowered line opacity. --- Incorporating changes since UI Module. Chevron disclosure and without elbow, but with decreased indent. ![TreeView.gif](/attachments/a9bf04c3-c681-4987-b53a-0f2372328abc)
Harley Acheson added this to the User Interface project 2024-01-30 00:53:12 +01:00
Harley Acheson requested review from Julian Eisel 2024-01-30 00:53:20 +01:00
Harley Acheson requested review from Sybren A. Stüvel 2024-01-30 00:53:52 +01:00
First-time contributor

This looks better.
Is the elbow always curved? Not sure if its possible to make it follow some theme parameter like UI corner radius, so it doesn't look off in themes without rounding.

This looks better. Is the elbow always curved? Not sure if its possible to make it follow some theme parameter like UI corner radius, so it doesn't look off in themes without rounding.

I'm not sure why we are still hanging on to the curved elbow idea, it was a workaround for improper indentation. It doesn't seem worth the extra visual noise, nor is it standard in UI designs.

I'm not sure why we are still hanging on to the curved elbow idea, it was a workaround for improper indentation. It doesn't seem worth the extra visual noise, nor is it standard in UI designs.

@brecht wrote:

I'm not sure why we are still hanging on to the curved elbow idea, it was a workaround for improper indentation. It doesn't seem worth the extra visual noise, nor is it standard in UI designs.

For me the straight lines down (i.e. Blender's current design) keep being visually confusing, and actually add more noise than this proposal. I'm also not aware of any other application that shows hierarchy trees like this, so I wouldn't argue that that is a standard UI design either.

This is what I wrote in my original PR earlier:

For me it becomes clearer that the elbows are actually a good idea. The currently-in-main straight lines always feel like "pointing down" to elements that may not be directly related (f.e. "Arm.L (Tweak)" has a line pointing to Arm.R"). The little elbow at the bottom say more "this is grouped together", and demarking a clear end of that group. With the rounded elbows of @jenkm this is even stronger.

> @brecht wrote: > > I'm not sure why we are still hanging on to the curved elbow idea, it was a workaround for improper indentation. It doesn't seem worth the extra visual noise, nor is it standard in UI designs. For me the straight lines down (i.e. Blender's current design) keep being visually confusing, and actually add more noise than this proposal. I'm also not aware of any other application that shows hierarchy trees like this, so I wouldn't argue that that is a standard UI design either. This is what I [wrote in my original PR](https://projects.blender.org/blender/blender/pulls/116200#issuecomment-1109468) earlier: > For me it becomes clearer that the elbows are actually a good idea. The currently-in-main straight lines always feel like "pointing down" to elements that may not be directly related (f.e. "Arm.L (Tweak)" has a line pointing to Arm.R"). The little elbow at the bottom say more "this is grouped together", and demarking a clear end of that group. With the rounded elbows of @jenkm this is even stronger.

GitHub uses the same design with straight lines, but indeed it's not very common.
https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/pull/1730/files

Anyway, I don't want to hold up this change over a minor design thing like this.

GitHub uses the same design with straight lines, but indeed it's not very common. https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/pull/1730/files Anyway, I don't want to hold up this change over a minor design thing like this.
Member

Module meeting consensus was to try the padding proposed in this patch, no elbows, and chevrons from #116240

Module meeting consensus was to try the padding proposed in this patch, no elbows, and chevrons from #116240
Harley Acheson changed title from UI: TreeView Changes Including Curved Elbow to UI: TreeView Changes 2024-01-30 23:53:55 +01:00
Author
Member

@dr.sybren @brecht @pablovazquez

I updated the PR and the capture in the first comment. This indents childless items the same as ones with children, the amount of indentation is reduced, but keeps the straight line, and with new chevron.

The animated GIF could be difficult to examine well, so here is a still image:

image

#7 definitely looks to be a sibling of #8, rather than a parent. And #9 looks to be a child of #8, rather than a sibling.

@dr.sybren @brecht @pablovazquez I updated the PR and the capture in the first comment. This indents childless items the same as ones with children, the amount of indentation is reduced, but keeps the straight line, and with new chevron. The animated GIF could be difficult to examine well, so here is a still image: ![image](/attachments/0750cf6b-270c-490d-9023-2583f5838e56) #7 definitely looks to be a sibling of #8, rather than a parent. And #9 looks to be a child of #8, rather than a sibling.
Pablo Vazquez approved these changes 2024-01-31 00:35:58 +01:00
Pablo Vazquez left a comment
Member

Definitely an improvement. +1 design-wise.

Thanks Harley!

Definitely an improvement. +1 design-wise. Thanks Harley!
Brecht Van Lommel approved these changes 2024-01-31 20:42:14 +01:00
Brecht Van Lommel left a comment
Owner

Code looks fine to me.

Code looks fine to me.
Author
Member

@JulianEisel

I think you wanted a chance to look at this first. Or I could merge it and we could look at everything holistically? Whatever you wish.

@JulianEisel I think you wanted a chance to look at this first. Or I could merge it and we could look at everything holistically? Whatever you wish.
Sybren A. Stüvel approved these changes 2024-02-02 11:30:54 +01:00
Sybren A. Stüvel left a comment
Member

Thanks Harley, this is definitely an improvement. Sad to see the elbows go, but if that's necessary to move forward, let's move forward.

Thanks Harley, this is definitely an improvement. Sad to see the elbows go, but if that's necessary to move forward, let's move forward.
Julian Eisel approved these changes 2024-02-02 11:53:45 +01:00
Author
Member

This PR is not currently showing my last changes. I suspect that I merged in the changes to main because of the new use of chevron disclosures, then did other work, took screen shots, but did not commit that last work. Although that does not explain why my local code does not match the captures. Oh well, will recreate.

This PR is not currently showing my last changes. I suspect that I merged in the changes to main because of the new use of chevron disclosures, then did other work, took screen shots, but did not commit that last work. Although that does not explain why my local code does not match the captures. Oh well, will recreate.
Harley Acheson force-pushed TreeViewLineChanges from 551c457e79 to bc0cdf9c65 2024-02-02 17:50:44 +01:00 Compare
Harley Acheson added 1 commit 2024-02-02 17:59:26 +01:00
Harley Acheson added 1 commit 2024-02-02 18:04:01 +01:00
The current comment should stay in.
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
1e5a6968d9
Author
Member

@blender-bot build

@blender-bot build
Harley Acheson merged commit 2e02c0c515 into main 2024-02-02 19:40:37 +01:00
Harley Acheson referenced this issue from a commit 2024-02-02 19:40:39 +01:00
Harley Acheson deleted branch TreeViewLineChanges 2024-02-02 19:40:40 +01:00
YimingWu referenced this issue from a commit 2024-02-05 10:56:06 +01:00
Jonas Dichelle referenced this issue from a commit 2024-02-08 17:29:08 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117654
No description provided.