Cleanup: Move BKE_node.h to C++ #117773

Iliya Katushenock · 2024-02-03T00:11:38+01:00

Iliya Katushenock commented

2024-02-03 00:11:38 +01:00

No response

_No response_

LastTest.log

1.3 MiB

tests_result.txt

51 KiB

Iliya Katushenock added 5 commits 2024-02-03 00:11:48 +01:00

init 615d0b2efb

fix d720d99cff

progress 6ba76b8d52

first build!

cleanup fc30776906

make format 269cbfaa7c

Iliya Katushenock added 2 commits 2024-02-03 00:25:29 +01:00

celet old file 022c4b541f

cleanup 55d56ae7af

license

Iliya Katushenock added 1 commit 2024-02-03 00:27:00 +01:00

cleanup 3ec6e0cdbe

Iliya Katushenock added 1 commit 2024-02-03 00:43:05 +01:00

cleanup 2ca05518c5

delete typedef for structres, struct keywords and (void)s

Hans Goudey reviewed 2024-02-03 01:38:35 +01:00

Hans Goudey left a comment

I like where you're headed with this, but first, before changing any of the functions (moving them to a namespace, organizing them, etc) I'd hope for one PR/commit that's just the very simple change of moving the contents of BKE_node.h to the end of BKE_node.hh and removing the old header.

I like where you're headed with this, but first, before changing any of the functions (moving them to a namespace, organizing them, etc) I'd hope for one PR/commit that's just the very simple change of moving the contents of `BKE_node.h` to the end of `BKE_node.hh` and removing the old header.

Iliya Katushenock commented

2024-02-03 01:57:53 +01:00

I like where you're headed with this, but first, before changing any of the functions (moving them to a namespace, organizing them, etc) I'd hope for one PR/commit that's just the very simple change of moving the contents of BKE_node.h to the end of BKE_node.hh and removing the old header.

There is one issue with small-change approach in this case: all functions and its comments is located in some certain zones (splitted by another comments). Initially i did splitting according to the just the fact if function is used in C code or no. But in result, there is was just many randomly distributed parts of old file in new one.
For now, i reimplement old BKE_node.c version of file (with code structure) and inserting small C++ part back into existing file structure (and manually apply next changes as well).
To achieve the same structure, but doing this step-by-step, everything need to be backed to C version and next be copied by lines sets (and this might be done on the fly, via just taking some C lines of code and moving them to C++ header, and changing other lines of C++ header to consider correct structure of code).
I just have choose more easier way to me.

> I like where you're headed with this, but first, before changing any of the functions (moving them to a namespace, organizing them, etc) I'd hope for one PR/commit that's just the very simple change of moving the contents of BKE_node.h to the end of BKE_node.hh and removing the old header. There is one issue with small-change approach in this case: all functions and its comments is located in some certain zones (splitted by another comments). Initially i did splitting according to the just the fact if function is used in C code or no. But in result, there is was just many randomly distributed parts of old file in new one. For now, i reimplement old BKE_node.c version of file (with code structure) and inserting small C++ part back into existing file structure (and manually apply next changes as well). To achieve the same structure, but doing this step-by-step, everything need to be backed to C version and next be copied by lines sets (and this might be done on the fly, via just taking some C lines of code and moving them to C++ header, and changing other lines of C++ header to consider correct structure of code). I just have choose more easier way to me.

Iliya Katushenock added 1 commit 2024-02-03 02:04:49 +01:00

progress 83e1a91d4a