VSE: default to new "Auto" image filter for strips #117853

Merged
Aras Pranckevicius merged 1 commits from aras_p/blender:vse_auto_filter into main 2024-02-05 20:09:37 +01:00

Part of "improve filtering situation" (#116980), now strip scaling filter defaults to "Auto" which has logic like:

  • No scale, no rotation, integer positions: Nearest (fastest)
  • Scaling up by more than 2x: Cubic Mitchell, so you get nicer blending between pixels than with bilinear,
  • Scaling down by more than 2x: Box, so that many pixels are averaged properly without too much aliasing,
  • Otherwise: Bilinear

Existing strips that use Bilinear (which is default) get switched to Auto when loading older files.

All of this has an advantage that unless you have some special needs for your look, you can leave it at default and it will look decently good at either large up-scaling or large down-scaling, but not waste performance if you don't use any scaling at all. Previously none of the choices were good in "all cases": box (née subsampled3x3) only looks good when scaling down, cubic only looks good when scaling up, default bilinear leaves performance on the table when you don't use any scale/rotation, etc.

On something like Gold movie current edit, most of the strips effectively use Nearest now, except some that are translated into non-integer pixel positions; those stay effectively Bilinear.

Part of "improve filtering situation" (#116980), now strip scaling filter defaults to "Auto" which has logic like: - No scale, no rotation, integer positions: Nearest (fastest) - Scaling up by more than 2x: Cubic Mitchell, so you get nicer blending between pixels than with bilinear, - Scaling down by more than 2x: Box, so that many pixels are averaged properly without too much aliasing, - Otherwise: Bilinear Existing strips that use Bilinear (which is default) get switched to Auto when loading older files. All of this has an advantage that unless you have some special needs for your look, you can leave it at default and it will look decently good at either large up-scaling or large down-scaling, but not waste performance if you don't use any scaling at all. Previously none of the choices were good in "all cases": box (née subsampled3x3) only looks good when scaling down, cubic only looks good when scaling up, default bilinear leaves performance on the table when you don't use any scale/rotation, etc. On something like Gold movie current edit, most of the strips effectively use Nearest now, except some that are translated into non-integer pixel positions; those stay effectively Bilinear.
Aras Pranckevicius added 1 commit 2024-02-05 16:00:00 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
aa194529d6
VSE: default to new "Auto" image filter for strips
Part of "improve filtering situation" (#116980), now strip scaling
filter defaults to "Auto" which has logic like:
- No scale, no rotation, integer positions: Nearest (fastest)
- Scaling up by more than 2x: Cubic Mitchell, so you get nicer
  blending between pixels than with bilinear,
- Scaling down by more than 2x: Box, so that many pixels are averaged
  properly without too much aliasing,
- Otherwise: Bilinear

Existing strips that use Bilinear (which is default) get switched
to Auto when loading older files.
Aras Pranckevicius requested review from Sergey Sharybin 2024-02-05 16:00:52 +01:00
Aras Pranckevicius added this to the Video Sequencer project 2024-02-05 16:00:57 +01:00

@blender-bot build

@blender-bot build
Sergey Sharybin approved these changes 2024-02-05 18:20:54 +01:00
Sergey Sharybin left a comment
Owner

On the code side seems fine.
Just make sure the code compiles on all platforms and land it (perhaps updating the reference images when/if needed).

On the code side seems fine. Just make sure the code compiles on all platforms and land it (perhaps updating the reference images when/if needed).
Aras Pranckevicius merged commit e1f8775807 into main 2024-02-05 20:09:37 +01:00
Aras Pranckevicius deleted branch vse_auto_filter 2024-02-05 20:09:39 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117853
No description provided.