VSE: default to new "Auto" image filter for strips #117853

Aras Pranckevicius · 2024-02-05T15:59:50+01:00

2024-02-05 15:59:50 +01:00

Part of "improve filtering situation" (#116980), now strip scaling filter defaults to "Auto" which has logic like:

No scale, no rotation, integer positions: Nearest (fastest)
Scaling up by more than 2x: Cubic Mitchell, so you get nicer blending between pixels than with bilinear,
Scaling down by more than 2x: Box, so that many pixels are averaged properly without too much aliasing,
Otherwise: Bilinear

Existing strips that use Bilinear (which is default) get switched to Auto when loading older files.

All of this has an advantage that unless you have some special needs for your look, you can leave it at default and it will look decently good at either large up-scaling or large down-scaling, but not waste performance if you don't use any scaling at all. Previously none of the choices were good in "all cases": box (née subsampled3x3) only looks good when scaling down, cubic only looks good when scaling up, default bilinear leaves performance on the table when you don't use any scale/rotation, etc.

On something like Gold movie current edit, most of the strips effectively use Nearest now, except some that are translated into non-integer pixel positions; those stay effectively Bilinear.

Part of "improve filtering situation" (#116980), now strip scaling filter defaults to "Auto" which has logic like: - No scale, no rotation, integer positions: Nearest (fastest) - Scaling up by more than 2x: Cubic Mitchell, so you get nicer blending between pixels than with bilinear, - Scaling down by more than 2x: Box, so that many pixels are averaged properly without too much aliasing, - Otherwise: Bilinear Existing strips that use Bilinear (which is default) get switched to Auto when loading older files. All of this has an advantage that unless you have some special needs for your look, you can leave it at default and it will look decently good at either large up-scaling or large down-scaling, but not waste performance if you don't use any scaling at all. Previously none of the choices were good in "all cases": box (née subsampled3x3) only looks good when scaling down, cubic only looks good when scaling up, default bilinear leaves performance on the table when you don't use any scale/rotation, etc. On something like Gold movie current edit, most of the strips effectively use Nearest now, except some that are translated into non-integer pixel positions; those stay effectively Bilinear.

Aras Pranckevicius added 1 commit 2024-02-05 16:00:00 +01:00

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

aa194529d6 VSE: default to new "Auto" image filter for strips

Part of "improve filtering situation" (#116980), now strip scaling
filter defaults to "Auto" which has logic like:
- No scale, no rotation, integer positions: Nearest (fastest)
- Scaling up by more than 2x: Cubic Mitchell, so you get nicer
  blending between pixels than with bilinear,
- Scaling down by more than 2x: Box, so that many pixels are averaged
  properly without too much aliasing,
- Otherwise: Bilinear

Existing strips that use Bilinear (which is default) get switched
to Auto when loading older files.

Aras Pranckevicius referenced this pull request

2024-02-05 16:00:31 +01:00

VSE: Improve image filtering defaults/options #116980

Aras Pranckevicius requested review from Sergey Sharybin 2024-02-05 16:00:52 +01:00

Aras Pranckevicius added this to the Video Sequencer project 2024-02-05 16:00:57 +01:00

Sergey Sharybin commented

2024-02-05 18:14:29 +01:00

@blender-bot build

Sergey Sharybin approved these changes 2024-02-05 18:20:54 +01:00

Sergey Sharybin left a comment

On the code side seems fine.
Just make sure the code compiles on all platforms and land it (perhaps updating the reference images when/if needed).

On the code side seems fine. Just make sure the code compiles on all platforms and land it (perhaps updating the reference images when/if needed).