Mesh: Add "Set Sharpness by Angle" operator #117918

Merged
Hans Goudey merged 4 commits from HooglyBoogly/blender:mesh-set-sharpness-by-angle into blender-v4.1-release 2024-02-07 14:17:23 +01:00
Member

This simple operator set the edge sharpness attribute on edges,
either extending the existing values or replacing them completely.
It's meant to make it more convenient to manually control the
sharpness now that there can be more reason to do that after
auto smooth became a modifier.


Screenshot from 2024-02-06 14-30-21

This simple operator set the edge sharpness attribute on edges, either extending the existing values or replacing them completely. It's meant to make it more convenient to manually control the sharpness now that there can be more reason to do that after auto smooth became a modifier. --- ![Screenshot from 2024-02-06 14-30-21](/attachments/0006a81f-0ff9-4da9-b8c0-465f5c0a566d)
Hans Goudey added 1 commit 2024-02-06 21:43:44 +01:00
1a4662d7a7 Mesh: Add "Set Sharpness by Angle" operator
This simple  operator set the edge sharpness attribute on edges,
either extending the existing values or replacing them completely.
It's meant to make it more convenient to manually control the
sharpness now that there can be more reason to do that after
auto smooth became a modifier.
Hans Goudey added this to the Modeling project 2024-02-06 21:44:35 +01:00
Hans Goudey requested review from Campbell Barton 2024-02-06 21:44:41 +01:00
Hans Goudey added this to the 4.1 milestone 2024-02-06 21:44:45 +01:00
Campbell Barton approved these changes 2024-02-07 10:59:42 +01:00
Campbell Barton left a comment
Owner

Accepting with minor requests.

Accepting with minor requests.
@ -0,0 +1,94 @@
/* SPDX-FileCopyrightText: 2024 Blender Authors
*
* SPDX-License-Identifier: GPL-2.0-or-later */

Missing

/** \file
 * \ingroup edmesh
 */
Missing ``` /** \file * \ingroup edmesh */ ```
HooglyBoogly marked this conversation as resolved
@ -0,0 +34,4 @@
CTX_data_scene(C), CTX_data_view_layer(C), CTX_wm_view3d(C));
for (Object *object : objects) {
Mesh &mesh = *static_cast<Mesh *>(object->data);

The changed state can be tracked, skip updates if no changes are made. Avoiding redundant updates when no changes are made.

The `changed` state can be tracked, skip updates if no changes are made. Avoiding redundant updates when no changes are made.
HooglyBoogly marked this conversation as resolved
HooglyBoogly changed target branch from main to blender-v4.1-release 2024-02-07 13:48:47 +01:00
Hans Goudey added 3 commits 2024-02-07 14:01:09 +01:00
Hans Goudey merged commit 78963b466b into blender-v4.1-release 2024-02-07 14:17:23 +01:00
Hans Goudey deleted branch mesh-set-sharpness-by-angle 2024-02-07 14:17:25 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117918
No description provided.