Geometry Nodes: Move instance reference indices to a builtin attribute #117951

Merged

Hans Goudey merged 2 commits from HooglyBoogly/blender:instances-index-attribute into blender-v4.1-release

2024-02-08 20:55:42 +01:00

Hans Goudey commented

2024-02-07 17:44:42 +01:00

Member

This means the array can be shared between geometries when unchanged,
reducing memory usage and increasing performance. It also means that
handling the data can be done more generically using the attribute
system. In the future the transforms can become attributes too.

Two other changes are related here:

The "almost unique ids" are cached with a shared cache so they
are shared too.
The reference indices are baked as an attribute now, making the process
more generic and potentially easier to optimize in the future.

This means the array can be shared between geometries when unchanged, reducing memory usage and increasing performance. It also means that handling the data can be done more generically using the attribute system. In the future the transforms can become attributes too. Two other changes are related here: - The "almost unique ids" are cached with a shared cache so they are shared too. - The reference indices are baked as an attribute now, making the process more generic and potentially easier to optimize in the future.

Hans Goudey requested review from Jacques Lucke 2024-02-07 17:45:01 +01:00

Hans Goudey added the

label 2024-02-07 17:45:05 +01:00

Hans Goudey added this to the Nodes & Physics project 2024-02-07 17:45:18 +01:00

Hans Goudey commented

2024-02-07 17:45:24 +01:00

Author

Member

@blender-bot build

@blender-bot build

Jacques Lucke requested changes 2024-02-08 16:35:11 +01:00

Jacques Lucke left a comment

Member

I think this might result in crashes when loading existing bakes, because there is no check if the new attribute is actually initialized anymore. It won't be initialized when loading old bake data. You could check if the attribute exists after the call to load_attributes in try_load_instances. It would be even better if the code could also load the handles explicitly if the .reference_index attribute didn't exist in the bake. This should be easy enough and avoids unnecessary breakages.

I think this can still go into 4.1. Better than making bake files incompatible between main and 4.1 now already.

I think this might result in crashes when loading existing bakes, because there is no check if the new attribute is actually initialized anymore. It won't be initialized when loading old bake data. You could check if the attribute exists after the call to `load_attributes` in `try_load_instances`. It would be even better if the code could also load the `handles` explicitly if the `.reference_index` attribute didn't exist in the bake. This should be easy enough and avoids unnecessary breakages. I think this can still go into 4.1. Better than making bake files incompatible between `main` and `4.1` now already.

HooglyBoogly changed target branch from main to blender-v4.1-release

2024-02-08 16:39:36 +01:00

Hans Goudey force-pushed instances-index-attribute from 807ddeaa83 to 7fe06b0624

2024-02-08 16:55:39 +01:00

Compare

Hans Goudey commented

2024-02-08 16:56:26 +01:00

Author

Member

It would be even better if the code could also load the handles explicitly if the .reference_index attribute didn't exist in the bake. This should be easy enough and avoids unnecessary breakages.

Good point. I added support for reading the old format too. Tested with an old bake.

>It would be even better if the code could also load the handles explicitly if the .reference_index attribute didn't exist in the bake. This should be easy enough and avoids unnecessary breakages. Good point. I added support for reading the old format too. Tested with an old bake.

Hans Goudey requested review from Jacques Lucke 2024-02-08 16:56:32 +01:00

Jacques Lucke approved these changes 2024-02-08 20:02:48 +01:00

Jacques Lucke left a comment

Member

@blender-bot build

@blender-bot build

Hans Goudey merged commit 2e6223d90f into blender-v4.1-release

2024-02-08 20:55:42 +01:00

Hans Goudey referenced this issue from a commit

2024-02-08 20:55:43 +01:00

Geometry Nodes: Move instance reference indices to a builtin attribute

Hans Goudey deleted branch instances-index-attribute

2024-02-08 20:55:45 +01:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117951

No description provided.