blender
/
blender
134
398
Fork 580
Code Issues 6.3k Pull Requests 759 Projects 19 Wiki Activity

GPv3: Duplicate layer #117974

Merged
Falk David merged 9 commits from PratikPB2123/blender:gpv3-duplicate-layer into main 2024-02-16 14:07:39 +01:00
Conversation 2 Commits 9 Files Changed 2 +62 -1
Pratik Borhade commented 2024-02-08 07:01:30 +01:00
Member
Copy Link

Port legacy layer duplicate operator

Port legacy layer duplicate operator
Pratik Borhade added 1 commit 2024-02-08 07:01:40 +01:00
Pratik Borhade added 1 commit 2024-02-08 08:08:23 +01:00
Iliya Katushenock added this to the Grease Pencil project 2024-02-08 08:16:06 +01:00
Pratik Borhade requested review from Falk David 2024-02-08 08:51:43 +01:00
Pratik Borhade requested review from Amélie Fondevilla 2024-02-08 08:51:43 +01:00
Pratik Borhade added the
Module
Grease Pencil
 label 2024-02-08 08:51:53 +01:00
Falk David requested changes 2024-02-08 10:35:47 +01:00
Falk David left a comment
Member
Copy Link

Thanks, added some comments.

Thanks, added some comments.
source/blender/editors/grease_pencil/intern/grease_pencil_layers.cc Outdated
@ -429,0 +440,4 @@
return OPERATOR_CANCELLED;
}
Layer *active_layer = grease_pencil.get_active_layer();
Falk David commented 2024-02-08 10:25:13 +01:00
Member
Copy Link

This can be a Layer & since you checked if there is an active layer before.

This can be a `Layer &` since you checked if there is an active layer before.
filedescriptor marked this conversation as resolved
source/blender/editors/grease_pencil/intern/grease_pencil_layers.cc Outdated
@ -429,0 +445,4 @@
const Array<int> frame_numbers = active_layer->sorted_keys();
for (int frame : frame_numbers) {
grease_pencil.insert_blank_frame(new_layer, frame, 0, BEZT_KEYTYPE_KEYFRAME);
Falk David commented 2024-02-08 10:35:27 +01:00
Member
Copy Link

Instead of iterating over the keys here, iterate over active_layer->frames() like so:

for (const auto &[key, frame], active_layer->frames().items()) {

This means we can use the frame.type so we can pass it to insert_blank_frame.
Also use active_layer->get_frame_duration_at(key) to get the duration.

Instead of iterating over the keys here, iterate over `active_layer->frames()` like so: ``` for (const auto &[key, frame], active_layer->frames().items()) { ``` This means we can use the `frame.type` so we can pass it to `insert_blank_frame`. Also use `active_layer->get_frame_duration_at(key)` to get the duration.
Pratik Borhade commented 2024-02-08 11:14:18 +01:00
Author
Member
Copy Link

Thanks. Updated the PR
get_frame_duration_at looks bit faulty. Calculating wrong duration value (causing assert hit)

Thanks. Updated the PR `get_frame_duration_at` looks bit faulty. Calculating wrong duration value (causing assert hit)
Falk David commented 2024-02-08 11:18:29 +01:00
Member
Copy Link

Can you paste the error you get? 🤔

Can you paste the error you get? 🤔
Pratik Borhade commented 2024-02-08 11:30:44 +01:00
Author
Member
Copy Link

Sure: Assert hit at BLI_assert(duration >= 0); in add_frame()
I think frames returned by frames() are not sorted

Call Stack 
>	blender.exe!_BLI_assert_abort() Line 49	C
 	blender.exe!blender::bke::greasepencil::Layer::add_frame(int key, int drawing_index, int duration) Line 768	C++
 	blender.exe!GreasePencil::insert_blank_frame(blender::bke::greasepencil::Layer & layer, int frame_number, int duration, eBezTriple_KeyframeType keytype) Line 1754	C++
 	blender.exe!blender::ed::greasepencil::grease_pencil_layer_duplicate_exec(bContext * C, wmOperator * op) Line 452	C++
 	blender.exe!wm_operator_invoke(bContext * C, wmOperatorType * ot, const wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1563	C++
 	blender.exe!wm_operator_call_internal(bContext * C, wmOperatorType * ot, PointerRNA * properties, ReportList * reports, const wmOperatorCallContext context, const bool poll_only, const wmEvent * event) Line 1752	C++
 	blender.exe!WM_operator_name_call_ptr(bContext * C, wmOperatorType * ot, wmOperatorCallContext context, PointerRNA * properties, const wmEvent * event) Line 1801	C++
 	blender.exe!WM_operator_name_call_ptr_with_depends_on_cursor(bContext * C, wmOperatorType * ot, wmOperatorCallContext opcontext, PointerRNA * properties, const wmEvent * event, const char * drawstr) Line 1990	C++
 	blender.exe!ui_apply_but_funcs_after(bContext * C) Line 1048	C++
 	blender.exe!ui_handler_region_menu(bContext * C, const wmEvent * event, void * __formal) Line 11687	C++
 	blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, const bool always_pass) Line 834	C++
 	blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3325	C++
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3444	C++
 	blender.exe!wm_event_do_handlers(bContext * C) Line 4071	C++
 	blender.exe!WM_main(bContext * C) Line 616	C++
 	blender.exe!main(int argc, const char * * __formal) Line 578	C++

Test file: duplicate-layer.blend

Sure: Assert hit at ` BLI_assert(duration >= 0);` in `add_frame()` I think frames returned by `frames()` are not sorted <details> <summary> Call Stack </summary> ``` > blender.exe!_BLI_assert_abort() Line 49 C blender.exe!blender::bke::greasepencil::Layer::add_frame(int key, int drawing_index, int duration) Line 768 C++ blender.exe!GreasePencil::insert_blank_frame(blender::bke::greasepencil::Layer & layer, int frame_number, int duration, eBezTriple_KeyframeType keytype) Line 1754 C++ blender.exe!blender::ed::greasepencil::grease_pencil_layer_duplicate_exec(bContext * C, wmOperator * op) Line 452 C++ blender.exe!wm_operator_invoke(bContext * C, wmOperatorType * ot, const wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1563 C++ blender.exe!wm_operator_call_internal(bContext * C, wmOperatorType * ot, PointerRNA * properties, ReportList * reports, const wmOperatorCallContext context, const bool poll_only, const wmEvent * event) Line 1752 C++ blender.exe!WM_operator_name_call_ptr(bContext * C, wmOperatorType * ot, wmOperatorCallContext context, PointerRNA * properties, const wmEvent * event) Line 1801 C++ blender.exe!WM_operator_name_call_ptr_with_depends_on_cursor(bContext * C, wmOperatorType * ot, wmOperatorCallContext opcontext, PointerRNA * properties, const wmEvent * event, const char * drawstr) Line 1990 C++ blender.exe!ui_apply_but_funcs_after(bContext * C) Line 1048 C++ blender.exe!ui_handler_region_menu(bContext * C, const wmEvent * event, void * __formal) Line 11687 C++ blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, const bool always_pass) Line 834 C++ blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3325 C++ blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3444 C++ blender.exe!wm_event_do_handlers(bContext * C) Line 4071 C++ blender.exe!WM_main(bContext * C) Line 616 C++ blender.exe!main(int argc, const char * * __formal) Line 578 C++ ``` </details> Test file: [duplicate-layer.blend](/attachments/589adf78-d5d4-45df-a51c-11c9023fe45f)
Falk David commented 2024-02-08 12:45:50 +01:00
Member
Copy Link

Ah sorry, the correct way to do this is:

const int duration = frame.is_implicit_hold() ? 0 : layer.get_frame_duration_at(key);
Ah sorry, the correct way to do this is: ``` const int duration = frame.is_implicit_hold() ? 0 : layer.get_frame_duration_at(key); ```
👍 1
Pratik Borhade commented 2024-02-08 13:02:30 +01:00
Author
Member
Copy Link

So get_frame_duration_at is correct indeed 🙂

So `get_frame_duration_at` is correct indeed 🙂
filedescriptor marked this conversation as resolved
source/blender/editors/grease_pencil/intern/grease_pencil_layers.cc Outdated
@ -429,0 +450,4 @@
if (!empty_keyframes) {
for (const int frame_number : frame_numbers) {
const Drawing *drawing = grease_pencil.get_drawing_at(*active_layer, frame_number);
Falk David commented 2024-02-08 10:23:41 +01:00
Member
Copy Link

This can be a const Drawing &

This can be a `const Drawing &`
filedescriptor marked this conversation as resolved
Pratik Borhade added 1 commit 2024-02-08 11:13:11 +01:00
Pratik Borhade added 1 commit 2024-02-08 13:01:39 +01:00
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
5ece69e311 Use is_implicit_hold
Falk David approved these changes 2024-02-08 13:04:25 +01:00
Falk David left a comment
Member
Copy Link

Looks good now, thanks.

Looks good now, thanks.
Falk David commented 2024-02-08 13:04:49 +01:00
Member
Copy Link

@blender-bot build

@blender-bot build
Hans Goudey reviewed 2024-02-08 16:10:03 +01:00
source/blender/editors/grease_pencil/intern/grease_pencil_layers.cc Outdated
@ -429,0 +436,4 @@
const bool empty_keyframes = RNA_boolean_get(op->ptr, "empty_keyframes");
if (!grease_pencil.has_active_layer()) {
BKE_reportf(op->reports, RPT_ERROR, "No Active Layer to duplicate");
Hans Goudey commented 2024-02-08 16:10:01 +01:00
Member
Copy Link

Active Layer -> active layer

Typically these sorts of things aren't capitalized in the UI

`Active Layer` -> `active layer` Typically these sorts of things aren't capitalized in the UI
source/blender/editors/grease_pencil/intern/grease_pencil_layers.cc Outdated
@ -429,0 +454,4 @@
for (const int frame_number : frame_numbers) {
const Drawing &drawing = *grease_pencil.get_drawing_at(active_layer, frame_number);
Drawing *new_drawing = grease_pencil.get_editable_drawing_at(new_layer, frame_number);
*new_drawing = *MEM_new<bke::greasepencil::Drawing>(__func__, drawing);
Hans Goudey commented 2024-02-08 16:09:21 +01:00
Member
Copy Link

Maybe I'm missing something, this looks odd to me though. It looks like it's a memory leak, since it's allocating space for a drawing, but then just copying its contents into the memory pointed to by new_drawing.

Does this work?

*new_drawing = bke::greasepencil::Drawing(drawing);
Maybe I'm missing something, this looks odd to me though. It looks like it's a memory leak, since it's allocating space for a drawing, but then just copying its contents into the memory pointed to by `new_drawing`. Does this work? ``` *new_drawing = bke::greasepencil::Drawing(drawing); ```
Pratik Borhade commented 2024-02-09 04:57:51 +01:00
Author
Member
Copy Link

I've tried this. Got crash in constructor.
Dumb idea, I really didn't think about the memory leak, thanks 😅

Call stack 
 	blender.exe!std::_Atomic_storage<int,4>::load(const std::memory_order _Order) Line 1006	C++
 	blender.exe!blender::ImplicitSharingInfo::is_expired() Line 82	C++
 	blender.exe!blender::ImplicitSharingInfo::add_user() Line 88	C++
>	blender.exe!blender::bke::CurvesGeometry::CurvesGeometry(const blender::bke::CurvesGeometry & other) Line 99	C++
 	blender.exe!blender::bke::greasepencil::Drawing::Drawing(const blender::bke::greasepencil::Drawing & other) Line 298	C++
 	blender.exe!MEM_new<blender::bke::greasepencil::Drawing,blender::bke::greasepencil::Drawing const &>(const char * allocation_name, const blender::bke::greasepencil::Drawing & <args_0>) Line 277	C++
 	blender.exe!blender::bke::greasepencil::copy_drawing_array(blender::Span<GreasePencilDrawingBase const *> src_drawings, blender::MutableSpan<GreasePencilDrawingBase *> dst_drawings) Line 523	C++
 	blender.exe!BKE_grease_pencil_duplicate_drawing_array(const GreasePencil * grease_pencil_src, GreasePencil * grease_pencil_dst) Line 1420	C++
 	blender.exe!grease_pencil_copy_data(Main * __formal, ID * id_dst, const ID * id_src, const int __formal) Line 107	C++
 	blender.exe!BKE_id_copy_ex(Main * bmain, const ID * id, ID * * r_newid, int flag) Line 655	C++
 	blender.exe!blender::deg::`anonymous namespace'::id_copy_inplace_no_main(const ID * id, ID * newid) Line 286	C++
 	blender.exe!blender::deg::`anonymous namespace'::deg_expand_copy_on_write_datablock(const blender::deg::Depsgraph * depsgraph, const blender::deg::IDNode * id_node) Line 821	C++
 	blender.exe!blender::deg::deg_update_copy_on_write_datablock(const blender::deg::Depsgraph * depsgraph, const blender::deg::IDNode * id_node) Line 898	C++
 	blender.exe!blender::deg::deg_evaluate_copy_on_write(Depsgraph * graph, const blender::deg::IDNode * id_node) Line 1033	C++
 	blender.exe!blender::deg::DepsgraphNodeBuilder::add_id_node::__l11::<lambda>(Depsgraph * depsgraph) Line 182	C++
 	[External Code]	
 	blender.exe!blender::deg::`anonymous namespace'::evaluate_node(const blender::deg::`anonymous-namespace'::DepsgraphEvalState * state, blender::deg::OperationNode * operation_node) Line 108	C++
 	blender.exe!blender::deg::`anonymous namespace'::deg_task_run_func(TaskPool * pool, void * taskdata) Line 121	C++
 	blender.exe!Task::operator()() Line 167	C++
 	blender.exe!tbb_task_pool_run(TaskPool * pool, Task && task) Line 217	C++
 	blender.exe!tbb_task_pool_work_and_wait(TaskPool * pool) Line 229	C++
 	blender.exe!BLI_task_pool_work_and_wait(TaskPool * pool) Line 473	C++
 	blender.exe!blender::deg::`anonymous namespace'::evaluate_graph_threaded_stage(blender::deg::`anonymous-namespace'::DepsgraphEvalState * state, TaskPool * task_pool, const blender::deg::`anonymous-namespace'::EvaluationStage stage) Line 324	C++
 	blender.exe!blender::deg::deg_evaluate_on_refresh(blender::deg::Depsgraph * graph) Line 430	C++
 	blender.exe!deg_flush_updates_and_refresh(blender::deg::Depsgraph * deg_graph, const DepsgraphEvaluateSyncWriteback sync_writeback) Line 49	C++
 	blender.exe!DEG_evaluate_on_refresh(Depsgraph * graph, DepsgraphEvaluateSyncWriteback sync_writeback) Line 81	C++
 	blender.exe!scene_graph_update_tagged(Depsgraph * depsgraph, Main * bmain, bool only_if_tagged) Line 2575	C++
 	blender.exe!BKE_scene_graph_update_tagged(Depsgraph * depsgraph, Main * bmain) Line 2623	C++
 	blender.exe!wm_event_do_depsgraph(bContext * C, bool is_after_open_file) Line 486	C++
 	blender.exe!wm_event_do_refresh_wm_and_depsgraph(bContext * C) Line 509	C++
 	blender.exe!wm_event_do_notifiers(bContext * C) Line 734	C++
 	blender.exe!WM_main(bContext * C) Line 619	C++
 	blender.exe!main(int argc, const char * * __formal) Line 578	C++
I've tried this. Got crash in constructor. Dumb idea, I really didn't think about the memory leak, thanks 😅 <details> <summary> Call stack </summary> ``` blender.exe!std::_Atomic_storage<int,4>::load(const std::memory_order _Order) Line 1006 C++ blender.exe!blender::ImplicitSharingInfo::is_expired() Line 82 C++ blender.exe!blender::ImplicitSharingInfo::add_user() Line 88 C++ > blender.exe!blender::bke::CurvesGeometry::CurvesGeometry(const blender::bke::CurvesGeometry & other) Line 99 C++ blender.exe!blender::bke::greasepencil::Drawing::Drawing(const blender::bke::greasepencil::Drawing & other) Line 298 C++ blender.exe!MEM_new<blender::bke::greasepencil::Drawing,blender::bke::greasepencil::Drawing const &>(const char * allocation_name, const blender::bke::greasepencil::Drawing & <args_0>) Line 277 C++ blender.exe!blender::bke::greasepencil::copy_drawing_array(blender::Span<GreasePencilDrawingBase const *> src_drawings, blender::MutableSpan<GreasePencilDrawingBase *> dst_drawings) Line 523 C++ blender.exe!BKE_grease_pencil_duplicate_drawing_array(const GreasePencil * grease_pencil_src, GreasePencil * grease_pencil_dst) Line 1420 C++ blender.exe!grease_pencil_copy_data(Main * __formal, ID * id_dst, const ID * id_src, const int __formal) Line 107 C++ blender.exe!BKE_id_copy_ex(Main * bmain, const ID * id, ID * * r_newid, int flag) Line 655 C++ blender.exe!blender::deg::`anonymous namespace'::id_copy_inplace_no_main(const ID * id, ID * newid) Line 286 C++ blender.exe!blender::deg::`anonymous namespace'::deg_expand_copy_on_write_datablock(const blender::deg::Depsgraph * depsgraph, const blender::deg::IDNode * id_node) Line 821 C++ blender.exe!blender::deg::deg_update_copy_on_write_datablock(const blender::deg::Depsgraph * depsgraph, const blender::deg::IDNode * id_node) Line 898 C++ blender.exe!blender::deg::deg_evaluate_copy_on_write(Depsgraph * graph, const blender::deg::IDNode * id_node) Line 1033 C++ blender.exe!blender::deg::DepsgraphNodeBuilder::add_id_node::__l11::<lambda>(Depsgraph * depsgraph) Line 182 C++ [External Code] blender.exe!blender::deg::`anonymous namespace'::evaluate_node(const blender::deg::`anonymous-namespace'::DepsgraphEvalState * state, blender::deg::OperationNode * operation_node) Line 108 C++ blender.exe!blender::deg::`anonymous namespace'::deg_task_run_func(TaskPool * pool, void * taskdata) Line 121 C++ blender.exe!Task::operator()() Line 167 C++ blender.exe!tbb_task_pool_run(TaskPool * pool, Task && task) Line 217 C++ blender.exe!tbb_task_pool_work_and_wait(TaskPool * pool) Line 229 C++ blender.exe!BLI_task_pool_work_and_wait(TaskPool * pool) Line 473 C++ blender.exe!blender::deg::`anonymous namespace'::evaluate_graph_threaded_stage(blender::deg::`anonymous-namespace'::DepsgraphEvalState * state, TaskPool * task_pool, const blender::deg::`anonymous-namespace'::EvaluationStage stage) Line 324 C++ blender.exe!blender::deg::deg_evaluate_on_refresh(blender::deg::Depsgraph * graph) Line 430 C++ blender.exe!deg_flush_updates_and_refresh(blender::deg::Depsgraph * deg_graph, const DepsgraphEvaluateSyncWriteback sync_writeback) Line 49 C++ blender.exe!DEG_evaluate_on_refresh(Depsgraph * graph, DepsgraphEvaluateSyncWriteback sync_writeback) Line 81 C++ blender.exe!scene_graph_update_tagged(Depsgraph * depsgraph, Main * bmain, bool only_if_tagged) Line 2575 C++ blender.exe!BKE_scene_graph_update_tagged(Depsgraph * depsgraph, Main * bmain) Line 2623 C++ blender.exe!wm_event_do_depsgraph(bContext * C, bool is_after_open_file) Line 486 C++ blender.exe!wm_event_do_refresh_wm_and_depsgraph(bContext * C) Line 509 C++ blender.exe!wm_event_do_notifiers(bContext * C) Line 734 C++ blender.exe!WM_main(bContext * C) Line 619 C++ blender.exe!main(int argc, const char * * __formal) Line 578 C++ ``` </details>
Pratik Borhade commented 2024-02-09 11:19:46 +01:00
Author
Member
Copy Link

Also crashing sometimes in grease_pencil_blend_write
With current PR, I tried MEM_FreeN to avoid memory leak, but leak is still occurring somehow 👀

Also crashing sometimes in `grease_pencil_blend_write` With current PR, I tried `MEM_FreeN` to avoid memory leak, but leak is still occurring somehow 👀
Pratik Borhade commented 2024-02-11 07:31:29 +01:00
Author
Member
Copy Link

ok, so the crash in grease_pencil_blend_write was due to presence of vertex group.
Without them, crash still occurs but this time drawing->runtime memory is freed right after assigning bke::greasepencil::Drawing(drawing);
The destructor is called hence the memory is freed, then crash triggers due to accessing this freed memory in depsgraph evaluation.

ok, so the crash in `grease_pencil_blend_write` was due to presence of vertex group. Without them, crash still occurs but this time drawing->runtime memory is freed right after assigning `bke::greasepencil::Drawing(drawing);` The destructor is called hence the memory is freed, then crash triggers due to accessing this freed memory in depsgraph evaluation.
Pratik Borhade commented 2024-02-11 13:14:13 +01:00
Author
Member
Copy Link

Updated the PR to use add_duplicate_drawings() / add_empty_drawing() instead :)

Updated the PR to use `add_duplicate_drawings()` / `add_empty_drawing()` instead :)
Falk David commented 2024-02-12 12:00:19 +01:00
Member
Copy Link

Just to confirm @PratikPB2123, do you get crashes in main regarding the vertex groups?

Just to confirm @PratikPB2123, do you get crashes in `main` regarding the vertex groups?
Pratik Borhade commented 2024-02-12 12:34:50 +01:00
Author
Member
Copy Link

In main, no.

And now with this change, it's not crashing either with vgroups.

In main, no. And now with this change, it's not crashing either with vgroups.
👍 1
Pratik Borhade added 1 commit 2024-02-09 08:18:00 +01:00
Pratik Borhade added 1 commit 2024-02-11 13:12:08 +01:00
Pratik Borhade requested review from Falk David 2024-02-12 11:51:34 +01:00
Pratik Borhade requested review from Hans Goudey 2024-02-12 11:51:46 +01:00
Pratik Borhade added 2 commits 2024-02-12 12:48:32 +01:00
Pratik Borhade added 1 commit 2024-02-16 12:19:41 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
7fb6a69d2a Merge branch 'main' into gpv3-duplicate-layer and fix conflicts
Falk David approved these changes 2024-02-16 12:29:45 +01:00
Falk David commented 2024-02-16 12:29:58 +01:00
Member
Copy Link

@blender-bot build

@blender-bot build
Falk David merged commit 1077aebaa6 into main 2024-02-16 14:07:39 +01:00
Falk David referenced this issue from a commit 2024-02-16 14:07:40 +01:00
GPv3: Duplicate layer
Pratik Borhade deleted branch gpv3-duplicate-layer 2024-02-17 07:01:04 +01:00
Jeroen Bakker referenced this issue from a commit 2024-02-19 08:10:14 +01:00
GPv3: Duplicate layer
Sign in to join this conversation.
Reviewers
No reviewers
Amélie Fondevilla
Hans Goudey
Falk David
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Grease Pencil
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117974
No description provided.
Delete Branch "PratikPB2123/blender:gpv3-duplicate-layer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?