GPv3: Layer Adjustment Conversion #118149

Falk David · 2024-02-12T18:46:37+01:00

Falk David commented

2024-02-12 18:46:37 +01:00

This converts the "Layer Adjustments" from GPv2 into modifier setups in GPv3.

Before	After

This handles:

Layer tint
Layer thickness offset
Thickness factor (for the entire object)

Because the Thickness modifier has a factor instead of an offset, the thickness adjustment is converted to this geometry nodes modifier setup for each layer:

This converts the "Layer Adjustments" from GPv2 into modifier setups in GPv3. | Before | After | |------------|----------| | ![image](/attachments/fc3d21d0-daee-4b9d-90cb-53e171f22d41) | ![image](/attachments/a31a5f06-6d62-42b1-b1e8-2bed27d473bb) | This handles: * Layer tint * Layer thickness offset * Thickness factor (for the entire object) Because the Thickness modifier has a factor instead of an offset, the thickness adjustment is converted to this geometry nodes modifier setup for each layer: ![image](/attachments/a7c06222-5f0c-4913-a26e-7dfee238fe61) ![image](/attachments/d9aae99d-e325-4fd7-9b8e-bff8fe1ad5bb)

image.png

144 KiB

image.png

168 KiB

image.png

17 KiB

image.png

66 KiB

Falk David added 3 commits 2024-02-12 18:46:45 +01:00

22d78c3c70 WIP

cb2137b96e Merge branch 'main' into gpv3-layer-adjustments

0140395116 Convert thickness adjustment to geo nodes modifier

Falk David changed title from ~~GPv3: Layer Adjsu~~ to GPv3: Layer Adjustment Conversion

2024-02-12 18:46:59 +01:00

Falk David changed title from ~~GPv3: Layer Adjustment Conversion~~ to WIP: GPv3: Layer Adjustment Conversion

2024-02-12 18:47:36 +01:00

Falk David added this to the Grease Pencil project 2024-02-12 18:52:59 +01:00

Falk David added 1 commit 2024-02-12 19:01:33 +01:00

1279f98db9 Add subtype for offset to get length units

Falk David requested review from Hans Goudey 2024-02-13 11:10:00 +01:00

Falk David commented

2024-02-13 11:23:11 +01:00

@HooglyBoogly I'm wondering if it's worth it to create a geonodes setup for the tint modifier or if it's fine to use the exisitng tint modifier instead. Since we're going for the approach where we create one modifier per layer, it doesn't seem necessary to create a node setup for it. But maybe you think it is?

Falk David added 2 commits 2024-02-13 12:37:53 +01:00

f7ceb3f46b Merge branch 'main' into gpv3-layer-adjustments

38551d30b6 Convert thickness factor

Hans Goudey commented

2024-02-13 18:53:20 +01:00

it doesn't seem necessary to create a node setup for it. But maybe you think it is?

It's not really necessary either way, we just have to choose what gives better UX and aligns better with development goals. If the existing tint modifier works, that seems fine. If we'd have to change it/add features for this conversion, a geometry nodes setup may be better.

>it doesn't seem necessary to create a node setup for it. But maybe you think it is? It's not really necessary either way, we just have to choose what gives better UX and aligns better with development goals. If the existing tint modifier works, that seems fine. If we'd have to change it/add features for this conversion, a geometry nodes setup may be better.

Hans Goudey reviewed 2024-02-13 18:55:50 +01:00

source/blender/blenkernel/intern/grease_pencil_convert_legacy.cc Outdated

						
				@ -345,0 +468,4 @@

				                                    const bGPdata &src_object_data,

				                                    Object &dst_object)

				{

				  bNodeTree *offset_radius_node_tree = nullptr;

Hans Goudey commented

2024-02-13 18:55:50 +01:00

It will be important not to add one node tree per object in the future. I'm not sure if the conversion operator will remain once it's done by versioning code when loading files. If not, it may be fine to wait until then.

👍 1