Geometry Nodes: support group ids in Sample Nearest Surface node #118150
No reviewers
Simon Thommes
Hans Goudey
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#118150
Loading…
Reference in New Issue
No description provided.
Delete Branch "JacquesLucke/blender:sample-nearest-surface-group-ids"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This adds group ids to the
Sample Nearest Surfacenode. This allows e.g. finding the closest point on a specific mesh island.Three new sockets are added:
Group ID: Is evaluated on the face domain and splits the input mesh into multiple parts, each with its own id.Sample Group ID: Determines in which group the closest nearest surface is detected.Is Valid: Outputs true if a nearest surface was found, it's false if the group is empty.I think now we need an
Is Validoutput like the UV sampling node for cases where there is no match for Group ID.Other than that this looks good to me!
@ -107,0 +136,4 @@3, "Sample Position");MutableSpan<bool> is_valid_span = params.uninitialized_single_output<bool>(4, "Is Valid");mask.foreach_index([&](const int i) {It might be worth having a fallback for the simple case when
sample_idsis single?Seems like it could be worth it to support not allocating the is valid output too?
Though I'm sure those things are insignificant compared to the actual lookup, especially now...
I guess you don't think it's worth having a special case where we just call
get_closest_mesh_tris?Yeah, I don't really think that's necessary. If anything, I'd probably rather optimize for different cases in
SampleNearestSurfaceFunction::calldirectly.@blender-bot build
WIP: Geometry Nodes: support group ids in Sample Nearest Surface nodeto Geometry Nodes: support group ids in Sample Nearest Surface nodeI'm having some trouble understanding what the fallback output is derived from whenever the Group ID is not valid. It should probably just be 0 like it is for UV sampling, right now it is actually related to the input attribute.
I didn't notice this before, sorry. After this is fixed I'm pretty sure it's good to go from my end.
If we were using panels in builtin nodes, it might be nice to put all the new sockets in a new panel. But this probably isn't the first node we should do that to.
This mostly looks good to me, just a left a few inline comments.
@ -29,12 +29,17 @@ static void node_declare(NodeDeclarationBuilder &b)const eCustomDataType data_type = eCustomDataType(node->custom1);b.add_input(data_type, "Value").hide_value().field_on_all();}b.add_input<decl::Int>("Group ID").hide_value().field_on_all();Could you look into adding some descriptions for these inputs? That would probably really help people trying to figure it out for the first time.
@ -37,1 +39,4 @@}b.add_output<decl::Bool>("Is Valid").dependent_field({3, 4}).description("Whether the sampling was successfull");It would be nice to mention why the sampling might not be successful (or just be more specific here)
Hm, maybe we can do a pass over some nodes with optional group ids later and put them all in panels.
@blender-bot build
@ -97,0 +119,4 @@/* Construct BVH tree for each group. */bvh_trees_.reinitialize(groups_num);for (const int group_i : IndexRange(groups_num)) {It would probably be worth parallelizing this when there are lots of groups