Object: Move transform matrices to runtime struct #118210

Hans Goudey · 2024-02-13T16:59:40+01:00

Hans Goudey commented

2024-02-13 16:59:40 +01:00

The object_to_world and world_to_object matrices are set during
depsgraph evaluation, calculated from the object's animated location,
rotation, scale, parenting, and constraints. It's confusing and
unnecessary to store them with the original data in DNA.

This commit moves them to ObjectRuntime and moves the matrices to
use the C++ float4x4 type, giving the potential for simplified code
using the C++ abstractions. The matrices are accessible with functions
on Object directly since they are used so commonly. Though for write
access, directly using the runtime struct is necessary.

The inverse world_to_object matrix is often calculated before it's
used, even though it's calculated as part of depsgraph evaluation.
Long term we might not want to store this in ObjectRuntime at all,
and just calculate it on demand. Or at least we should remove the
redundant caluclations. That should be done separately though.

Also, we should probably change constinv in the
same way. But I'd prefer to consider those separately too.

The `object_to_world` and `world_to_object` matrices are set during depsgraph evaluation, calculated from the object's animated location, rotation, scale, parenting, and constraints. It's confusing and unnecessary to store them with the original data in DNA. This commit moves them to `ObjectRuntime` and moves the matrices to use the C++ `float4x4` type, giving the potential for simplified code using the C++ abstractions. The matrices are accessible with functions on `Object` directly since they are used so commonly. Though for write access, directly using the runtime struct is necessary. The inverse `world_to_object` matrix is often calculated before it's used, even though it's calculated as part of depsgraph evaluation. Long term we might not want to store this in `ObjectRuntime` at all, and just calculate it on demand. Or at least we should remove the redundant caluclations. That should be done separately though. --- Also, we should probably change `constinv` in the same way. But I'd prefer to consider those separately too.

👍 2 ❤️ 1

Hans Goudey added 1 commit 2024-02-13 16:59:50 +01:00

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

ff6a72ca12 Object: Move transform matrices to runtime struct

The `object_to_world` and `world_to_object` matrices are set during
depsgraph evaluation, calculated from the object's animated location,
rotation, scale, parenting, and constraints. It's confusing and
unnecessary to store them with the original data in DNA.

This commit moves them to `ObjectRuntime` and moves the matrices to
use the C++ `float4x4` type, giving the potential for simplified code
using the C++ abstractions. The matrices are accessible with functions
on `Object` directly since they are used so commonly. Though for write
access, directly using the runtime struct is necessary.

The inverse `world_to_object` matrix is often calculated before it's
used, even though it's calculated as part of depsgraph evaluation.
Long term we might not want to store this in `ObjectRuntime` at all,
and just calculate it on demand. Or at least we should remove the
redundant caluclations. That should be done separately though.

Hans Goudey requested review from Brecht Van Lommel 2024-02-13 17:01:06 +01:00

Hans Goudey requested review from Sergey Sharybin 2024-02-13 17:01:06 +01:00

Hans Goudey requested review from Jacques Lucke 2024-02-13 17:01:07 +01:00

Hans Goudey added this to the Core project 2024-02-13 17:01:13 +01:00

Sergey Sharybin commented

2024-02-13 17:21:23 +01:00

@blender-bot build

Hans Goudey added 1 commit 2024-02-13 17:23:20 +01:00