Fix #118225 possible crash double clicking on certain anim channels #118251

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:118225 into blender-v4.1-release 2024-02-16 12:28:22 +01:00
Member

The intend in the report was to rename a linked object in the NLA
channels. The operator to rename actually does everything right, it
detects that the object is linked and passes through to other operators.

The crash then happens in the attempt to select keyframes of channels
(also doubleclick n the keymap) -- in select_anim_channel_keys.

The problem is that bAnimListElem key_data cannot be expected to be
an FCurve in all cases. Code does though, it always casts, but this is
unreliable, basically this would fail for all of the "summary" channels
or any channel type (e.g. mask layers etc.), either it is NULL or
garbage data.

So to resolve, we just check the bAnimListElem type -- if it is not
ALE_FCURVE we can early out (preventing the crash).

NOTE: this changes behavior of double clicking on a summary channel that
cannot be renamed slightly in that it will not deselect its keys anymore
(it was not selecting any keys anyways, this is actually more in line of
what would happen if you just select another channel -- this also leaves
key selection alone -- so this is actually an improvement as well imho)

The intend in the report was to rename a linked object in the NLA channels. The operator to rename actually does everything right, it detects that the object is linked and passes through to other operators. The crash then happens in the attempt to select keyframes of channels (also doubleclick n the keymap) -- in `select_anim_channel_keys`. The problem is that `bAnimListElem` `key_data` cannot be expected to be an `FCurve` in all cases. Code does though, it always casts, but this is unreliable, basically this would fail for all of the "summary" channels or any channel type (e.g. mask layers etc.), either it is NULL or garbage data. So to resolve, we just check the `bAnimListElem` type -- if it is not ALE_FCURVE we can early out (preventing the crash). NOTE: this changes behavior of double clicking on a summary channel that cannot be renamed slightly in that it will not deselect its keys anymore (it was not selecting any keys anyways, this is actually more in line of what would happen if you just select another channel -- this also leaves key selection alone -- so this is actually an improvement as well imho)
Philipp Oeser added 1 commit 2024-02-14 11:50:38 +01:00
62e4923e53 Fix #118225 possible crash double clicking on certain anim channels
The intend in the report was to rename a linked object in the NLA
channels. The operator to rename actually does everything right, it
detects that the object is linked and passes through to other operators.

The crash then happens in the attempt to select keyframes of channels
(also doubleclick n the keymap) -- in `select_anim_channel_keys`.

The problem is that `bAnimListElem` `key_data` cannot be expected to be
an `FCurve` in all cases. Code does though, it always casts, but this is
unreliable, basically this would fail for all of the "summary" channels
or any channel type (e.g. mask layers etc.), either it is NULL or
garbage data.

So to resolve, we just check the `bAnimListElem` type -- if it is not
ALE_FCURVE we can early out (preventing the crash).

NOTE: this changes behavior of double clicking on a summary channel that
cannot be renamed slightly in that it will not deselect its keys anymore
(it was not selecting any keys anyways, this is actually more in line of
what would happen if you just select another channel -- this also leaves
key selection alone -- so this is actually an improvement as well imho)
Philipp Oeser added this to the Animation & Rigging project 2024-02-14 11:50:51 +01:00
Philipp Oeser requested review from Christoph Lendenfeld 2024-02-14 11:51:02 +01:00
Philipp Oeser requested review from Sybren A. Stüvel 2024-02-14 11:51:11 +01:00
Christoph Lendenfeld approved these changes 2024-02-15 10:23:52 +01:00
Christoph Lendenfeld left a comment
Member

good to know that ANIMFILTER_FCURVESONLY does not actually return only fcurves.
Thanks for the fix

good to know that `ANIMFILTER_FCURVESONLY` does not actually return only fcurves. Thanks for the fix
Author
Member

good to know that ANIMFILTER_FCURVESONLY does not actually return only fcurves.
Thanks for the fix

That is due to 92d7f9ac56

A new Animation Filter flag was added: ANIMFILTER_FCURVESONLY. For now
this only filters out Grease Pencil Layer channels.

> good to know that `ANIMFILTER_FCURVESONLY` does not actually return only fcurves. > Thanks for the fix That is due to 92d7f9ac56e0ff1e65c364487542dfb7c32a0a67 >A new Animation Filter flag was added: `ANIMFILTER_FCURVESONLY`. For now this only filters out Grease Pencil Layer channels.
Sybren A. Stüvel approved these changes 2024-02-16 11:55:05 +01:00
Sybren A. Stüvel left a comment
Member

good to know that ANIMFILTER_FCURVESONLY does not actually return only fcurves.

Oh that looks like an excellent footgun.

This fix looks fine, thanks for that.

> good to know that `ANIMFILTER_FCURVESONLY` does not actually return only fcurves. Oh that looks like an excellent footgun. This fix looks fine, thanks for that.
Philipp Oeser merged commit 1a2edde400 into blender-v4.1-release 2024-02-16 12:28:22 +01:00
Philipp Oeser deleted branch 118225 2024-02-16 12:28:29 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118251
No description provided.