tmp-core-refactors #118283

Bastien Montagne · 2024-02-14T17:02:54+01:00

Bastien Montagne commented

2024-02-14 17:02:54 +01:00

No response

_No response_

Bastien Montagne added 1 commit 2024-02-14 17:03:05 +01:00

35727a4fec Core: IDRemapper: Refactor handling of 'never null' ID usages.

Existing code would allow tagging on request IDs which had a 'never
null' usage potentially cleared by the remapping operation (e.g. if an
Object obdata would have been set to `nullptr`).

While this worked for the current extremely restricted usecase (ID
deletion), this was not the best design, as it forced the ID remapping
user code to be very careful about its own usages of the `LIB_TAG_DOIT`
tag.

This commit replaces internal tagging by adding such IDs to a Set in
`IDRemapper` class, which user code can then use to find which IDs
(would have) had a 'never null' ID pointer cleared.

There are two additional changes induced by this commit:
* `BKE_libblock_unlink` `do_flag_never_null` parameter is removed.
  As it is not used in current codebase, simpler to remove than update
  the code to support it.
* `ID_REMAP_FLAG_NEVER_NULL_USAGE` option is renamed to
  `ID_REMAP_STORE_NEVER_NULL_USAGE`.
  In addition, its behavior is slightly modified:
  * Before, the owner ID would systematically be tagged if it had such
    'never null' ID usages, regardless of whether said ID usages (would)
    have actually been remapped to `nullptr`.
  * Now, the owner ID is only added to the `never_null_users` set if its
    'never null' usages (would) have been cleared.

Bastien Montagne commented

2024-02-14 17:03:33 +01:00

@blender-bot build

Bastien Montagne force-pushed tmp-core-refactors from aca783e572 to b7d8a86598

2024-02-14 17:11:20 +01:00

Compare

Bastien Montagne merged commit f2e481a519 into main

2024-02-15 10:16:42 +01:00

Bastien Montagne referenced this issue from a commit

2024-02-15 10:16:43 +01:00

Core: Refactor id_delete.

Bastien Montagne deleted branch tmp-core-refactors