EEVEE-Next: Add Volume Probe > Blending Size setting #118342

Closed
Miguel Pozo wants to merge 3 commits from pragma37/blender:pull-eevee-grid-blending-setting into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

Allow the user to control the size of the irradiance grid blending.

Allow the user to control the size of the irradiance grid blending.
Miguel Pozo added the
Interest
EEVEE
Module
EEVEE & Viewport
labels 2024-02-15 19:16:12 +01:00
Miguel Pozo added 1 commit 2024-02-15 19:16:22 +01:00
Miguel Pozo requested review from Clément Foucault 2024-02-15 19:16:39 +01:00
Clément Foucault reviewed 2024-02-21 11:44:22 +01:00
Clément Foucault left a comment
Member

I think we should reuse LightProbe::falloff for that property instead of adding another one. To me it is doing almost the same thing. It just changes behavior for EEVEE-Next.

But that pauses the question of backward compatibility (we would have to patch older file). So I'm not sure.

I think we should reuse `LightProbe::falloff` for that property instead of adding another one. To me it is doing almost the same thing. It just changes behavior for EEVEE-Next. But that pauses the question of backward compatibility (we would have to patch older file). So I'm not sure.
Author
Member

Even if they're kept as separate rna properties so they don't have to share docstring and the min-max range, I don't know if there would be a way to use different default values based on probe type.
Also, I don't know if setting a >1.0 value on a volume probe and changing the type to sphere would break the expected falloff range.

For backward compatibility, I think it could be handled by checking the probe type.

So, it may be doable, but I'm not sure it's worth the trouble.

Even if they're kept as separate rna properties so they don't have to share docstring and the min-max range, I don't know if there would be a way to use different default values based on probe type. Also, I don't know if setting a >1.0 value on a volume probe and changing the type to sphere would break the expected falloff range. For backward compatibility, I think it could be handled by checking the probe type. So, it may be doable, but I'm not sure it's worth the trouble.
Miguel Pozo added 1 commit 2024-02-21 16:03:20 +01:00
Miguel Pozo added 1 commit 2024-02-21 18:53:06 +01:00
Clément Foucault requested changes 2024-02-25 18:24:42 +01:00
Clément Foucault left a comment
Member

After experimenting, I think adding a Blending Size setting is not worth it for now and opens a different can of worms to avoid light bleeding and what space is best for blending. For now, we can settle on reducing the blending to a half voxel blending (that doesn't overlap the data).

Blending with surrounding probes will be implemented in another way which should be more efficient and noise free (see #118725 but with blending added at volume upload time on more than 1 voxel).

So keep this PR to remove the random remapping and reduce the blending to half a voxel (so that it ends at the border samples locations), but remove the addition of a new parameter.

After experimenting, I think adding a Blending Size setting is not worth it for now and opens a different can of worms to avoid light bleeding and what space is best for blending. For now, we can settle on reducing the blending to a half voxel blending (that doesn't overlap the data). Blending with surrounding probes will be implemented in another way which should be more efficient and noise free (see #118725 but with blending added at volume upload time on more than 1 voxel). So keep this PR to remove the random remapping and reduce the blending to half a voxel (so that it ends at the border samples locations), but remove the addition of a new parameter.
Author
Member

I've committed the requested changes directly (3560f7ec41).
Closing this.

I've committed the requested changes directly (3560f7ec41). Closing this.
Miguel Pozo closed this pull request 2024-02-27 18:55:45 +01:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118342
No description provided.