UI Test: Dialog Title Move Hand Cursor #118358

Harley Acheson · 2024-02-16T02:16:23+01:00

Harley Acheson commented

2024-02-16 02:16:23 +01:00

Mouse cursor changes to a "Hand" to indicate that popup blocks can be
moved by dragging the title region.

@pablovazquez wanted to try this.

Mouse cursor changes to a "Hand" to indicate that popup blocks can be moved by dragging the title region. --- @pablovazquez wanted to try this. ![image](/attachments/2659521a-7bd1-4289-88d7-21f967ef514a)

MoveHand.gif

335 KiB

Harley Acheson added 1 commit 2024-02-16 02:16:34 +01:00

0517d5a157 UI Test: Dialog Title Move Hand Cursor

Mouse cursor changes to a "Hand" to indicate that popup blocks can be
moved by dragging the title region.

Harley Acheson added this to the User Interface project 2024-02-16 02:18:07 +01:00

Harley Acheson requested review from Pablo Vazquez 2024-02-16 17:19:08 +01:00

Pablo Vazquez commented

2024-02-16 18:23:27 +01:00

Thanks for trying it out!

That is one ugly cursor, Windows. Testing on macOS it seems to use the wrong cursor (this one is used for links):

It should (if possible) use the open hand icon on hover, and closed hand on drag:

From https://support.apple.com/en-mt/guide/mac-help/mh35695/mac

Thanks for trying it out! That is one ugly cursor, Windows. Testing on macOS it seems to use the wrong cursor (this one is used for links): <video src="/attachments/0375e2fd-de07-404f-a9e7-087717a71b39" title="Screen Recording 2024-02-16 at 18.17.10.mov" controls></video> It should (if possible) use the open hand icon on hover, and closed hand on drag: ![macos Cursors](/attachments/6d76e8d9-0600-495b-b3f3-a91f4b560f91) From https://support.apple.com/en-mt/guide/mac-help/mh35695/mac

Screen Recording 2024-02-16 at 18.17.10.mov

2.0 MiB

image.png

13 KiB

Harley Acheson commented

2024-02-17 21:25:35 +01:00

Testing on macOS it seems to use the wrong cursor (this one is used for links):

Oh, we should treat that as a bug. We hardly use that cursor for anything so haven't noticed that. gpencil uses that somewhere, but is for a move not a point or selection.

We only have one hand cursor defined in our source, WM_CURSOR_HAND, and that maps to a ghost cursor type of GHOST_kStandardCursorMove, which makes sense. But the Mac source - GHOST_WindowCocoa.mm - that is now using pointingHandCursor when I think it should be openHandCursor

It should (if possible) use the open hand icon on hover, and closed hand on drag

On Windows we don't have this supplied by the OS, but it is something we made for Blender. But we only made "open hand" not "closed hand". Not that we couldn't make it.

> Testing on macOS it seems to use the wrong cursor (this one is used for links): Oh, we should treat that as a bug. We hardly use that cursor for anything so haven't noticed that. gpencil uses that somewhere, but is for a move not a point or selection. We only have one hand cursor defined in our source, WM_CURSOR_HAND, and that maps to a ghost cursor type of GHOST_kStandardCursorMove, which makes sense. But the Mac source - GHOST_WindowCocoa.mm - that is now using pointingHandCursor when I think it should be openHandCursor > It should (if possible) use the open hand icon on hover, and closed hand on drag On Windows we don't have this supplied by the OS, but it is something we made for Blender. But we only made "open hand" not "closed hand". Not that we couldn't make it.

Harley Acheson commented

2024-02-18 00:08:15 +01:00

@pablovazquez - Testing on macOS it seems to use the wrong cursor (this one is used for links):

There is now a PR for that but requires a Mac dev to test: #118423

> @pablovazquez - Testing on macOS it seems to use the wrong cursor (this one is used for links): There is now a PR for that but requires a Mac dev to test: #118423

👍 1

Pablo Vazquez commented

2024-02-18 22:55:11 +01:00

On Windows we don't have this supplied by the OS, but it is something we made for Blender. But we only made "open hand" not "closed hand".

Just noticed the Image Viewer actually has an open/close hand pointer. But probably made ad-hoc for the image viewer? Not sure which other Windows apps have such a feature to compare.

Not that we couldn't make it.

If we do I'd go for something smaller like macOS'.

> On Windows we don't have this supplied by the OS, but it is something we made for Blender. But we only made "open hand" not "closed hand". Just noticed the Image Viewer actually has an open/close hand pointer. But probably made ad-hoc for the image viewer? Not sure which other Windows apps have such a feature to compare. <video src="/attachments/2dd6ed01-f30a-4de7-b3cc-8270d1dafd89" title="Recording 2024-02-18 225045.mp4" controls></video> > Not that we couldn't make it. If we do I'd go for something smaller like macOS'.

Recording 2024-02-18 225045.mp4

1.0 MiB

Harley Acheson commented

2024-02-18 23:18:05 +01:00

Just noticed the Image Viewer actually has an open/close hand pointer. But probably made ad-hoc for the image viewer? Not sure which other Windows apps have such a feature to compare.

Yes, we have the ability use custom cursors, but the OS doesn't supply many on its own. Those were just made for that program, similar to how we have lots of custom ones in Blender. https://learn.microsoft.com/en-us/windows/win32/menurc/about-cursors

> Just noticed the Image Viewer actually has an open/close hand pointer. But probably made ad-hoc for the image viewer? Not sure which other Windows apps have such a feature to compare. Yes, we have the ability use custom cursors, but the OS doesn't supply many on its own. Those were just made for that program, similar to how we have lots of custom ones in Blender. https://learn.microsoft.com/en-us/windows/win32/menurc/about-cursors

ThinkingPolygons commented

2024-02-19 00:02:39 +01:00

First-time contributor

hands are cool, i know, but most of the time when dragging something in blender, the following cursor shows up:

so why not stick with it for consistency sake?

hands are cool, i know, but most of the time when dragging something in blender, the following cursor shows up: ![image](https://projects.blender.org/attachments/abaede05-3560-4f3c-83de-0c57ba36b93b) so why not stick with it for consistency sake?

Clipboard01.jpg

60 KiB

image.png

95 KiB

Harley Acheson commented

2024-02-19 00:37:16 +01:00

@ThinkingPolygons - so why not stick with it for consistency sake?

True. This PR is mostly looking at how we can make it more obvious to users that they can drag dialogs.

But not sure I could get used to seeing a hand cursor on Windows, no matter how they are redesigned - it just isn't something we normally see so looks a bit... "goofy". But we could easily make it so that a WM_CURSOR_MOVE becomes a IDC_SIZEALL on Windows while Mac users see their openHandCursor

> @ThinkingPolygons - so why not stick with it for consistency sake? True. This PR is mostly looking at how we can make it more obvious to users that they can drag dialogs. But not sure I could get used to seeing a hand cursor on Windows, no matter how they are redesigned - it just isn't something we normally see so looks a bit... "goofy". But we could easily make it so that a WM_CURSOR_MOVE becomes a IDC_SIZEALL on Windows while Mac users see their openHandCursor

Pablo Vazquez commented

2024-02-19 11:15:00 +01:00

so looks a bit... "goofy".

It looks goofy on Windows because of their oversized hand cursor. On Linux it will depend on the DE theme, and on macOS it looks native.

we could easily make it so that a WM_CURSOR_MOVE becomes a IDC_SIZEALL on Windows while Mac users see their openHandCursor

That could work as a trade-off. Shall we try it out if it's not too much work?

> so looks a bit... "goofy". It looks goofy on Windows because of their oversized hand cursor. On Linux it will depend on the DE theme, and on macOS it looks native. > we could easily make it so that a WM_CURSOR_MOVE becomes a IDC_SIZEALL on Windows while Mac users see their openHandCursor That could work as a trade-off. Shall we try it out if it's not too much work?

thorn-neverwake commented

2024-02-19 20:37:29 +01:00

First-time contributor

I'd prefer the 4-tri cursor that thinking polygons screenshoted ... Personally I've never liked cursors that look like a hand. Something just weird about it. It's like someone amputated Mickey mouse.

Merge conflict checking is in progress. Try again in few moments.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u DialogMoveHand:Harley-DialogMoveHand

git checkout Harley-DialogMoveHand

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI Test: Dialog Title Move Hand Cursor #118358

Checkout