Fix #94781: Getting stuck in an edit mode when object is disabled in viewport #118370

Closed

Christoph Lendenfeld wants to merge 4 commits from ChrisLend/blender:fix_stuck_in_pose_mode into blender-v4.1-release

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Christoph Lendenfeld commented

2024-02-16 12:10:16 +01:00

Member

When disabling objects in the viewport (using the monitor icon),
while in an edit mode you cannot leave the mode.
The bugreport mentions pose mode, but it really happens with all objects in all modes.

The fix I propose is to not disable mode switching based on visibility.
As far as I can tell, this only fixes the issue but doesn't allow going into edit mode on objects that are hidden.
This is because hidden objects cannot be active, and that is checked as well.

This also makes the behavior consistent with toggling visibility (eye icon).

When disabling objects in the viewport (using the monitor icon), while in an edit mode you cannot leave the mode. The bugreport mentions pose mode, but it really happens with all objects in all modes. The fix I propose is to not disable mode switching based on visibility. As far as I can tell, this only fixes the issue but doesn't allow going into edit mode on objects that are hidden. This is because hidden objects cannot be active, and that is checked as well. This also makes the behavior consistent with toggling visibility (eye icon).

Christoph Lendenfeld added the

Animation & Rigging

labels 2024-02-16 12:10:16 +01:00

Christoph Lendenfeld added 1 commit 2024-02-16 12:10:30 +01:00

6bc59c25c4 fix

Sergey Sharybin requested changes 2024-02-16 12:42:50 +01:00

Sergey Sharybin left a comment

Owner

This enables operators to modify objects which are not visible, which is against the design.

A lot of poll functions use function like ED_operator_object_active_editable. For example, with this change Make Parent without Inverse becomes available for active object which is restricted from viewport.

This enables operators to modify objects which are not visible, which is against the design. A lot of poll functions use function like `ED_operator_object_active_editable`. For example, with this change `Make Parent without Inverse` becomes available for active object which is restricted from viewport.

Christoph Lendenfeld added 1 commit 2024-02-16 12:58:18 +01:00

bb86916aef copy logic into poll function

Christoph Lendenfeld added 2 commits 2024-02-16 13:07:25 +01:00

5e01c0e787 remove comment

8dd279039c add new comment

Christoph Lendenfeld commented

2024-02-16 13:07:31 +01:00

Author

Member

thanks for the feedback
I've now moved the logic directly into the object_mode_set_poll function. This should remove side-effects when calling operators.

thanks for the feedback I've now moved the logic directly into the `object_mode_set_poll` function. This should remove side-effects when calling operators.

Christoph Lendenfeld requested review from Sergey Sharybin 2024-02-16 13:07:36 +01:00

Sergey Sharybin requested changes 2024-02-16 14:56:37 +01:00

Sergey Sharybin left a comment

Owner

You shouldn't be able to switch invisible objects to edit mode.

An argument can be made that it might be useful to switch from edit/pose to object mode. But then it sounds a bit arbitrary, and not very consistent with the rest of the mental model aboutedtiability of invisible objects.

You shouldn't be able to switch invisible objects to edit mode. An argument can be made that it might be useful to switch from edit/pose to object mode. But then it sounds a bit arbitrary, and not very consistent with the rest of the mental model aboutedtiability of invisible objects.

Sergey Sharybin commented

2024-02-16 14:57:16 +01:00

Owner

I forgot to mention, the reference to the report seems to be broken.

I forgot to mention, the reference to the report seems to be broken.

Christoph Lendenfeld changed title from ~~Fix #9478: Getting stuck in an edit mode when object is disabled in viewport~~ to Fix #94781: Getting stuck in an edit mode when object is disabled in viewport

2024-02-16 15:35:24 +01:00

Christoph Lendenfeld commented

2024-02-16 15:37:51 +01:00

Author

Member

I forgot to mention, the reference to the report seems to be broken.

sorry about that, fixed now

You shouldn't be able to switch invisible objects to edit mode.

Yes, that I am aware of. But the question is if you can do that, because the object needs to be active to take it into edit mode. And if it is hidden, it can't be active.

I am aware this is touching design basics of Blender, maybe there is a different solution that doesn't have people stuck in an edit mode?

> I forgot to mention, the reference to the report seems to be broken. sorry about that, fixed now > You shouldn't be able to switch invisible objects to edit mode. Yes, that I am aware of. But the question is if you can do that, because the object needs to be active to take it into edit mode. And if it is hidden, it can't be active. I am aware this is touching design basics of Blender, maybe there is a different solution that doesn't have people stuck in an edit mode?

Christoph Lendenfeld commented

2024-02-27 17:04:41 +01:00

Author

Member

dropping this PR since it's a bit too involved for me

dropping this PR since it's a bit too involved for me

Christoph Lendenfeld closed this pull request

2024-02-27 17:04:44 +01:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118370

No description provided.