blender/blender
149
475
Fork 700
Code Issues 6.7k Pull Requests 888 Projects 18 Wiki Activity

Video: Remove non-ffmpeg AVI support #118409

Merged
Aras Pranckevicius merged 7 commits from aras_p/blender:remove_avi into main 2024-02-20 13:15:59 +01:00
Conversation 5 Commits 7 Files Changed 33 +62 -3573
Aras Pranckevicius commented 2024-02-17 15:46:02 +01:00
Member
Copy Link

Blender had a very limited (only uncompressed or MJPEG frames) .avi file support, for both reading and writing. This is something that ffmpeg can fully do.

This is an experiment to remove all of that. 3500 lines of code gone, primary motivations being:

  • ffmpeg can read and write .avi files just fine, including ones with uncompressed or MJPEG frames.
  • Blender's ffmpeg integration could also be taught to produce uncompressed or MJPEG .avi files, but TBH I don't see a particular reason to do that. Modern formats like H264 are better in every way, and already support "lossless" option if needed.
  • Before starting to play back any movie strip within VSE, Blender today first does: 1) check if file exists (~1ms on Windows), 2) check if it's a video file understood by ffmpeg, or by avi (5-10ms), 3) actually open said file, in 99% cases via ffmpeg (5-10ms), 4) start decoding it. Doing steps 2) and 3) together is largely redundant, and removal of separate avi decoding codepath does allow to simplify step 2 a bit, i.e. reduce the stall that happens in VSE whenever a new movie strip starts playing.
  • The "Lite" blender build configuration was excluding both ffmpeg and avi anyway, so that config is something that can't read nor write any movies.

User visible changes:

  • In scene image output type, under Video section now there's only Ffmpeg Video (AVI Raw and AVI JPEG are gone)
  • Whenever loading an existing file, if output was one of AVI Raw / AVI JPEG, it is set to Ffmpeg Video.
    • Note: I have not tried to intelligently map previous AVI Raw / AVI Jpeg to some ffmpeg presets, just set to default (h264). Not sure if extra cleverness is needed.

Performance tests: I tested whether there's any measurable performance difference in rendering out a movie with ffmpeg vs the old AVI options. In short, I can't see any. Rendering out 2000 frames of Sprite Fright data set, on Windows/Ryzen5950X, all of these options take ~1 minute. Difference is in file sizes:

  • AVI RAW: 10301MB
  • AVI JPEG (default 90 quality): 654MB
  • ffmpeg H264 (all defaults): 54MB
  • ffmpeg H264 (lossless, keyframe interval 1): 2235MB
Blender had a very limited (only uncompressed or MJPEG frames) .avi file support, for both reading and writing. This is something that ffmpeg can fully do. This is an experiment to remove all of that. 3500 lines of code gone, primary motivations being: - ffmpeg can read and write .avi files just fine, including ones with uncompressed or MJPEG frames. - Blender's ffmpeg integration could also be taught to produce uncompressed or MJPEG .avi files, but TBH I don't see a particular reason to do that. Modern formats like H264 are better in every way, and already support "lossless" option if needed. - Before starting to play back any movie strip within VSE, Blender today first does: 1) check if file exists (~1ms on Windows), 2) check if it's a video file understood by ffmpeg, or by avi (5-10ms), 3) actually open said file, in 99% cases via ffmpeg (5-10ms), 4) start decoding it. Doing steps 2) and 3) together is largely redundant, and removal of separate avi decoding codepath does allow to simplify step 2 a bit, i.e. reduce the stall that happens in VSE whenever a new movie strip starts playing. - The "Lite" blender build configuration was excluding _both_ ffmpeg and avi anyway, so that config is something that can't read nor write any movies. User visible changes: - In scene image output type, under Video section now there's only Ffmpeg Video (AVI Raw and AVI JPEG are gone) - Whenever loading an existing file, if output was one of AVI Raw / AVI JPEG, it is set to Ffmpeg Video. - Note: I have not tried to intelligently map previous AVI Raw / AVI Jpeg to some ffmpeg presets, just set to default (h264). Not sure if extra cleverness is needed. Performance tests: I tested whether there's any measurable performance difference in rendering out a movie with ffmpeg vs the old AVI options. In short, I can't see any. Rendering out 2000 frames of Sprite Fright data set, on Windows/Ryzen5950X, all of these options take ~1 minute. Difference is in file sizes: - AVI RAW: 10301MB - AVI JPEG (default 90 quality): 654MB - ffmpeg H264 (all defaults): 54MB - ffmpeg H264 (lossless, keyframe interval 1): 2235MB
👀 1 🚀 6
Aras Pranckevicius added 3 commits 2024-02-17 15:46:12 +01:00
AVI: hide AVI Raw/Jpeg options
Some checks failed
buildbot/vexp-code-patch-linux-x86_64 Build done.
Details
buildbot/vexp-code-patch-lint Build done.
Details
buildbot/vexp-code-patch-darwin-x86_64 Build done.
Details
buildbot/vexp-code-patch-darwin-arm64 Build done.
Details
buildbot/vexp-code-patch-windows-amd64 Build done.
Details
buildbot/vexp-code-patch-coordinator Build done.
Details
f7e1613933 
Upon older file load, change video output to Ffmpeg video
Aras Pranckevicius added 1 commit 2024-02-17 15:59:24 +01:00 
"None" clashes with preprocessor macro defined by X11 headers, so
change that to NotAnim
Aras Pranckevicius added 1 commit 2024-02-17 16:00:57 +01:00
Fix debug build
Some checks failed
buildbot/vexp-code-patch-lint Build done.
Details
buildbot/vexp-code-patch-linux-x86_64 Build done.
Details
buildbot/vexp-code-patch-darwin-arm64 Build done.
Details
buildbot/vexp-code-patch-darwin-x86_64 Build done.
Details
buildbot/vexp-code-patch-windows-amd64 Build done.
Details
buildbot/vexp-code-patch-coordinator Build done.
Details
13e1c4026d
Aras Pranckevicius added 1 commit 2024-02-17 16:04:43 +01:00
Format
All checks were successful
buildbot/vexp-code-patch-lint Build done.
Details
buildbot/vexp-code-patch-linux-x86_64 Build done.
Details
buildbot/vexp-code-patch-darwin-x86_64 Build done.
Details
buildbot/vexp-code-patch-darwin-arm64 Build done.
Details
buildbot/vexp-code-patch-windows-amd64 Build done.
Details
buildbot/vexp-code-patch-coordinator Build done.
Details
556296ed5e
Aras Pranckevicius commented 2024-02-17 20:00:46 +01:00
Author
Member
Copy Link

@blender-bot build

@blender-bot build
Aras Pranckevicius changed title from WIP: Video: Remove non-ffmpeg AVI support to Video: Remove non-ffmpeg AVI support 2024-02-17 20:01:43 +01:00
Aras Pranckevicius added this to the Video Sequencer project 2024-02-17 20:01:54 +01:00
Campbell Barton commented 2024-02-18 23:52:50 +01:00
Owner
Copy Link

On balance I'd rather keep this functionality although I realize the case for doing so isn't all that strong.

  • I think it's good if we can maintain multiple "video" back-ends, it avoids being tied too closely to a single video codec implementation. When we remove a "generalized" interface making it FFMPEG only, typically going back the other way is much more difficult.
  • I mostly build with FFMPEG disabled, there is some minor benefit in being able to generate and read a "simple" video format.

The multiple back-end argument assumes we might need to add another in the future, or switch away from FFMPEG at some point - neither seem all that likely.

An alternative to your PR could be to set WITH_CODEC_AVI=OFF for release builds, it means we ensure multiple implementations are available and the down-sides you mention for release builds are gone.

Typically the overhead of maintaining additional code would be reason enough to remove code where possible, in practice I don't think this is such an issue for this area of the code.

On balance I'd rather keep this functionality although I realize the case for doing so isn't all that strong. - I think it's good if we can maintain multiple "video" back-ends, it avoids being tied too closely to a single video codec implementation. When we remove a "generalized" interface making it FFMPEG only, typically going back the other way is much more difficult. - I mostly build with FFMPEG disabled, there is some minor benefit in being able to generate and read a "simple" video format. The multiple back-end argument assumes we *might* need to add another in the future, or switch away from FFMPEG at some point - neither seem all that likely. An alternative to your PR could be to set `WITH_CODEC_AVI=OFF` for release builds, it means we ensure multiple implementations are available and the down-sides you mention for release builds are gone. Typically the overhead of maintaining additional code would be reason enough to remove code where possible, in practice I don't think this is such an issue for this area of the code.
Aras Pranckevicius commented 2024-02-19 08:36:32 +01:00
Author
Member
Copy Link

@ideasman42 I guess a counterpoint, is that just because something compiles (i.e. a "different video backend"), does not necessarily mean it actually works. Actual case in point: today, the existing non-ffmpeg AVI reading code, apparently produces garbage: see image, VLC window is how it's supposed to look like, but within blender without ffmpeg it is decoded wrong.

Clipboard01.png

@ideasman42 I guess a counterpoint, is that just because something compiles (i.e. a "different video backend"), does not necessarily mean it actually works. Actual case in point: today, the existing non-ffmpeg AVI reading code, apparently produces garbage: see image, VLC window is how it's supposed to look like, but within blender without ffmpeg it is decoded wrong. ![Clipboard01.png](/attachments/f183aaf4-b344-415d-ad50-315a69f36d63)
Clipboard01.png
127 KiB
❤️ 1
Brecht Van Lommel commented 2024-02-19 13:13:05 +01:00
Owner
Copy Link

My vote would be to remove this code. I think the abstraction mainly gets in the way and is not that difficult to restore in the unlikely event we switch to something else than ffmpeg. And leaving this as a feature for developers building without ffmpeg doesn't seem worth it.

My vote would be to remove this code. I think the abstraction mainly gets in the way and is not that difficult to restore in the unlikely event we switch to something else than ffmpeg. And leaving this as a feature for developers building without ffmpeg doesn't seem worth it.
👍 2
Sergey Sharybin commented 2024-02-19 15:30:07 +01:00
Owner
Copy Link

I am with Brecht here, but from a perspective who was deeper involved into maintenance of video IO: I too think the code is to be removed to simplify maintenance of the code.

I could have been convinced that compiling with FFmpeg could be problematic, but now their API is quite stable, and we do provide precompiled libraries for all platforms. And the cost of the FFmpeg enabled is not that big.

The UI level is also important. I'd rather to have a single Video output option, and make that to work as good as possible than to provide non-obvious choice.

I am with Brecht here, but from a perspective who was deeper involved into maintenance of video IO: I too think the code is to be removed to simplify maintenance of the code. I could have been convinced that compiling with FFmpeg could be problematic, but now their API is quite stable, and we do provide precompiled libraries for all platforms. And the cost of the FFmpeg enabled is not that big. The UI level is also important. I'd rather to have a single Video output option, and make that to work as good as possible than to provide non-obvious choice.
👍 1
Sergey Sharybin approved these changes 2024-02-20 10:34:25 +01:00
Aras Pranckevicius added 1 commit 2024-02-20 13:08:09 +01:00 
# Conflicts:
#	source/blender/blenloader/intern/versioning_400.cc
#	source/blender/io/avi/intern/avi_mjpeg.cc
Aras Pranckevicius merged commit f09c7dc4ba into main 2024-02-20 13:15:59 +01:00
Aras Pranckevicius deleted branch remove_avi 2024-02-20 13:16:02 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Sergey Sharybin
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Video Sequencer
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118409
No description provided.
Delete Branch "aras_p/blender:remove_avi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?