UI: Changes to Props Dialogs #118640

Harley Acheson · 2024-02-23T00:27:00+01:00

Harley Acheson commented

2024-02-23 00:27:00 +01:00

Improved titles and confirm button text for 15 props dialogs.

For example, the "Resize Image" Props dialog changes from the image on top to the one below, with better description and confirmation text:

All the changes:

GEOMETRY_OT_attribute_convert - "Convert Attribute Domain", "Convert"
GEOMETRY_OT_color_attribute_convert - "Convert Color Attribute Domain", "Convert"
GPENCIL_OT_bake_grease_pencil_animation - "Bake Object Transform to Grease Pencil", "Bake"
GPENCIL_OT_bake_mesh_animation - "Bake Mesh Animation to Grease Pencil", "Bake"
ED_gpencil_new_layer_dialog - "Add New Layer", "Add"
OBJECT_OT_paths_calculate - "Calculate Object Motion Paths", "Calculate"
OBJECT_OT_move_to_collection (when new) - "Move to New Collection", "Create"
PAINT_OT_add_texture_paint_slot - "Add Paint Slot", "Add"
IMAGE_OT_resize - "Scale Image to New Size", "Resize"
IMAGE_OT_tile_add - "Add Tile to Image", "Add"
IMAGE_OT_tile_fill - "Fill Tile With Generated Image", "Fill"
OUTLINER_OT_id_remap - "Remap Data ID" "Remap"
SEQUENCER_OT_enable_proxies - "Set Selected Strip Proxies", "Set"
WM_OT_debug_menu - "Set Debug Value", "Set"
WM_OT_stereo3d_set - "Set Stereo 3D", "Set"

Improved titles and confirm button text for 15 props dialogs. --- For example, the "Resize Image" Props dialog changes from the image on top to the one below, with better description and confirmation text: ![image](/attachments/518e3c00-1acc-42ba-a212-493c645add7a) All the changes: * GEOMETRY_OT_attribute_convert - "Convert Attribute Domain", "Convert" * GEOMETRY_OT_color_attribute_convert - "Convert Color Attribute Domain", "Convert" * GPENCIL_OT_bake_grease_pencil_animation - "Bake Object Transform to Grease Pencil", "Bake" * GPENCIL_OT_bake_mesh_animation - "Bake Mesh Animation to Grease Pencil", "Bake" * ED_gpencil_new_layer_dialog - "Add New Layer", "Add" * OBJECT_OT_paths_calculate - "Calculate Object Motion Paths", "Calculate" * OBJECT_OT_move_to_collection (when new) - "Move to New Collection", "Create" * PAINT_OT_add_texture_paint_slot - "Add Paint Slot", "Add" * IMAGE_OT_resize - "Scale Image to New Size", "Resize" * IMAGE_OT_tile_add - "Add Tile to Image", "Add" * IMAGE_OT_tile_fill - "Fill Tile With Generated Image", "Fill" * OUTLINER_OT_id_remap - "Remap Data ID" "Remap" * SEQUENCER_OT_enable_proxies - "Set Selected Strip Proxies", "Set" * WM_OT_debug_menu - "Set Debug Value", "Set" * WM_OT_stereo3d_set - "Set Stereo 3D", "Set"

image.png

28 KiB

Harley Acheson added 1 commit 2024-02-23 00:27:04 +01:00

f1a2d334ba UI: Changes to Props Dialogs

Improved titles and confirm button text for 15 props dialogs.

Harley Acheson added this to the User Interface project 2024-02-23 00:27:25 +01:00

Harley Acheson requested review from Pablo Vazquez 2024-02-23 00:27:33 +01:00

Hadrien commented

2024-02-23 03:36:24 +01:00

First-time contributor

Why rephrase "Resize image"? It seems to me that "Scale image to new size" suggests using a scaling factor or percentage, but the dialog expects absolute pixel numbers. I'm not sure the new title is more accurate in that regard?

Either way these look pleasantly communicative. A bit more verbose and a lot less cryptic

Why rephrase "Resize image"? It seems to me that "Scale image to new size" suggests using a scaling factor or percentage, but the dialog expects absolute pixel numbers. I'm not sure the new title is more accurate in that regard? Either way these look pleasantly communicative. A bit more verbose and a lot less cryptic

Harley Acheson commented

2024-02-23 04:09:26 +01:00

@HadrienBrissaud

I'm not wedded to any of this phrasing and appreciate any and all suggestions for improvement.

My thinking with "Scale image to new size", right or wrong, was my feeling that "resize" on its own can imply non-scale changes. Like a canvas can be resized larger than the image inside it, or an image can be resized by clipping. So I just liked the combination of "Scale Image", "New Size" and "Resize" making it clear the image will scaled to the new size.

But again, open to all suggestions. You would prefer a title of just "Resize Image" and button text of "Resize"?

@HadrienBrissaud I'm not wedded to any of this phrasing and appreciate any and all suggestions for improvement. My thinking with "Scale image to new size", right or wrong, was my feeling that "resize" on its own can imply non-scale changes. Like a canvas can be resized larger than the image inside it, or an image can be resized by clipping. So I just liked the combination of "Scale Image", "New Size" and "Resize" making it clear the image will scaled to the new size. But again, open to all suggestions. You would prefer a title of just "Resize Image" and button text of "Resize"?

Hadrien commented

2024-02-23 04:26:24 +01:00

First-time contributor

Right, I didn't realize there is potential for ambiguity. One program I use call these "Resize image" and "Resize canvas" respectively, and Krita calls them "Scale image to new size" and "Resize canvas". I don't think there's a notion of canvas anywhere in Blender, and we're not introducing one now, so your initial suggestion seems good !

thorn-neverwake commented

2024-02-23 17:50:15 +01:00

First-time contributor

"Scale" is a better description of an operation on an image that is interpolated (via scaling) to a new dimension, than "resize".

Scale implies a destructive pixel action (ie, you are changing the actual pixels), while Resize implies a non-destructive action (such as making a vector graphic larger, or increasing the size of a canvas.)

"Scale" is a better description of an operation on an image that is interpolated (via scaling) to a new dimension, than "resize". Scale implies a destructive pixel action (ie, you are changing the actual pixels), while Resize implies a non-destructive action (such as making a vector graphic larger, or increasing the size of a canvas.)

Harley Acheson commented

2024-02-23 17:57:23 +01:00

"Scale" is a better description of an operation on an image that is interpolated (via scaling) to a new dimension, than "resize".

Part of my feeling that the dialog needs to be clear is that I find the menu item name to be unclear on this.

So if we changed this item to say "Scale..." then I wouldn't care as much about the dialog text.

@HadrienBrissaud's comment about "scale" suggesting a scaling factor or percentage is true, in that you can read that word as a verb or a noun. Gimp solves that by showing it as "Scale Image..." even though, like us, it seems redundant to use "image" again for an item on the "Image" menu.

> "Scale" is a better description of an operation on an image that is interpolated (via scaling) to a new dimension, than "resize". Part of my feeling that the dialog needs to be clear is that I find the menu item name to be unclear on this. ![image](/attachments/8243a0b3-8d6c-4a2f-a394-618cf6eac5d0) So if we changed this item to say "Scale..." then I wouldn't care as much about the dialog text. @HadrienBrissaud's comment about "scale" suggesting a scaling factor or percentage is true, in that you can read that word as a verb or a noun. Gimp solves that by showing it as "Scale Image..." even though, like us, it seems redundant to use "image" again for an item on the "Image" menu.

image.png

17 KiB

thorn-neverwake commented

2024-02-23 20:32:37 +01:00

First-time contributor

So if we changed this item to say "Scale..." then I wouldn't care as much about the dialog text.

Sorry, i may have made my point poorly - i thought your original image up above was fine. Headline doesn't match the button text, but i thought the headline made the situation clear enough and is a good idea.

(IE, I don't know that "resize" needs to be renamed across the full software in every possible use, that seems outside the scope of good minor UX improvement as you're approaching here)

>So if we changed this item to say "Scale..." then I wouldn't care as much about the dialog text. Sorry, i may have made my point poorly - i thought your original image up above was fine. Headline doesn't match the button text, but i thought the headline made the situation clear enough and is a good idea. (IE, I don't know that "resize" needs to be renamed across the full software in every possible use, that seems outside the scope of good minor UX improvement as you're approaching here)

Brecht Van Lommel approved these changes 2024-02-27 14:06:29 +01:00

Harley Acheson added 1 commit 2024-02-27 20:16:57 +01:00

3c3d29a75e Merge branch 'main' of projects.blender.org:blender/blender into PropsDialogsTitles

Harley Acheson merged commit da378e4d30 into main

2024-02-27 20:19:43 +01:00

Harley Acheson referenced this issue from a commit

2024-02-27 20:19:44 +01:00

UI: Changes to Props Dialogs

Harley Acheson deleted branch PropsDialogsTitles

2024-02-27 20:19:45 +01:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Changes to Props Dialogs #118640