GPv3: Switch back to the GPv2 render engine #118664

Merged
Falk David merged 51 commits from filedescriptor/blender:gpv3-roll-back-renderer into main 2024-03-18 12:01:26 +01:00
Member

This makes it so GPv3 objects are rendered using the current grease pencil render engine.

Removes the gpencil_next engine as it is no longer used. The current status has been pushed to the gpencil-next branch on the blender repository.

Fixes #115467 #116347.

TODOs

  • viewlayer string property on layers. This makes sure a layer is only rendered on that viewlayer. See !119422
  • Layer Masks. These exist already, but need more helper functions and a UI to be useful. See !119422
  • Fix fill triangles not rendering properly.
  • Stroke ordering (2d/3d)
  • Onion Skinning. Will be its own PR.
This makes it so GPv3 objects are rendered using the current grease pencil render engine. Removes the `gpencil_next` engine as it is no longer used. The current status has been pushed to the `gpencil-next` branch on the `blender` repository. Fixes #115467 #116347. TODOs - [x] `viewlayer` string property on layers. This makes sure a layer is only rendered on that viewlayer. See !119422 - [x] Layer Masks. These exist already, but need more helper functions and a UI to be useful. See !119422 - [x] Fix fill triangles not rendering properly. - [x] Stroke ordering (2d/3d) - [ ] ~~Onion Skinning.~~ Will be its own PR.
Falk David added 7 commits 2024-02-23 15:10:34 +01:00
Falk David added this to the Module: Grease Pencil project 2024-02-23 15:18:09 +01:00
Falk David added 1 commit 2024-02-23 15:39:18 +01:00
Falk David added 4 commits 2024-02-26 18:45:07 +01:00
Falk David added 8 commits 2024-02-29 18:19:24 +01:00
Falk David added 3 commits 2024-03-04 12:00:47 +01:00
Falk David added 9 commits 2024-03-12 16:15:48 +01:00
Falk David added 1 commit 2024-03-12 17:07:41 +01:00
Incrementing the offset was missed in the early return
Falk David added 1 commit 2024-03-12 17:39:08 +01:00
Falk David added 1 commit 2024-03-13 14:46:52 +01:00
Falk David added 1 commit 2024-03-13 15:13:24 +01:00
Falk David added 3 commits 2024-03-14 15:26:21 +01:00
Falk David added 1 commit 2024-03-14 16:32:03 +01:00
Falk David added 1 commit 2024-03-14 16:46:12 +01:00
Falk David added 1 commit 2024-03-14 16:56:16 +01:00
Falk David added 2 commits 2024-03-14 17:28:46 +01:00
Falk David changed title from WIP: GPv3: Switch back to the GPv2 render engine to GPv3: Switch back to the GPv2 render engine 2024-03-14 17:29:08 +01:00
Falk David requested review from Clément Foucault 2024-03-14 17:29:16 +01:00
Hans Goudey reviewed 2024-03-14 17:36:10 +01:00
Hans Goudey left a comment
Member

Seems fairly straightforward

Seems fairly straightforward
@ -592,0 +687,4 @@
const bke::CurvesGeometry &curves = info.drawing.strokes();
const OffsetIndices<int> points_by_curve = curves.points_by_curve();
bke::AttributeAccessor attributes = curves.attributes();
VArray<int> stroke_materials = *attributes.lookup_or_default<int>(
Member

Declare these three variables const

Declare these three variables const
Member

attributes too ;)

`attributes` too ;)
filedescriptor marked this conversation as resolved
@ -276,0 +318,4 @@
const bke::CurvesGeometry &curves = info.drawing.strokes();
const OffsetIndices<int> points_by_curve = curves.points_by_curve();
bke::AttributeAccessor attributes = curves.attributes();
VArray<int> stroke_materials = *attributes.lookup_or_default<int>(
Member

Same here

Same here
filedescriptor marked this conversation as resolved
Falk David added 1 commit 2024-03-14 17:46:00 +01:00
Falk David added 1 commit 2024-03-14 18:00:46 +01:00
Falk David added 1 commit 2024-03-14 18:03:11 +01:00
Make bke::AttributeAccessor const
Some checks reported errors
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
f956a15b5d
Author
Member

@blender-bot build

@blender-bot build
Falk David added 1 commit 2024-03-14 18:06:02 +01:00
Formatting
Some checks failed
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
43bfea4128
Author
Member

@blender-bot build

@blender-bot build
Falk David added 1 commit 2024-03-15 11:09:07 +01:00
Formatting
Some checks failed
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
b4a9306fb0
Author
Member

@blender-bot build

@blender-bot build
Clément Foucault approved these changes 2024-03-18 11:04:47 +01:00
Falk David force-pushed gpv3-roll-back-renderer from 4de22299f3 to ebf606c8b3 2024-03-18 11:16:42 +01:00 Compare
Falk David added 1 commit 2024-03-18 11:18:24 +01:00
Update submodule hash
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
a34b354b91
Author
Member

@blender-bot build

@blender-bot build
Falk David merged commit a3243172bf into main 2024-03-18 12:01:26 +01:00
Falk David deleted branch gpv3-roll-back-renderer 2024-03-18 12:01:29 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118664
No description provided.