WIP: Fix #117408: only take speakers into account that are visible on evaluated objects #118800

Jacques Lucke · 2024-02-27T14:00:09+01:00

Jacques Lucke commented

2024-02-27 14:00:09 +01:00

Iterating over all the duplis here is fairly expensive in some cases. Once we know the behavior we want, we could also implement a more optimized iteration mechanism that skips many unnecessary objects.

It's also the first time I'm touching anything related to the speaker objects, so not entirely sure what the expected behavior is.

This patch also allows outputting multiple instances of a speaker.

Iterating over all the duplis here is fairly expensive in some cases. Once we know the behavior we want, we could also implement a more optimized iteration mechanism that skips many unnecessary objects. It's also the first time I'm touching anything related to the speaker objects, so not entirely sure what the expected behavior is. This patch also allows outputting multiple instances of a speaker.

Jacques Lucke added 1 commit 2024-02-27 14:00:18 +01:00

ed1dc864ab only take speakers into account that are visible on evaluated objects

Jacques Lucke commented

2024-02-27 14:02:18 +01:00

Adding Sergey as an initial reviewer here, not sure who knows this stuff. Feel free to suggest someone else.

Jacques Lucke requested review from Sergey Sharybin 2024-02-27 14:02:26 +01:00

Sergey Sharybin reviewed 2024-02-27 14:27:51 +01:00

source/blender/blenkernel/intern/sound.cc Outdated

						
				@ -1193,2 +1191,3 @@

				                              DEG_ITER_OBJECT_FLAG_LINKED_VIA_SET;

				    deg_iter_settings.flags = DEG_OBJECT_ITER_FOR_RENDER_ENGINE_FLAGS;

				    DEG_OBJECT_ITER_BEGIN (&deg_iter_settings, object) {

				      if (object->visibility_flag & OB_HIDE_VIEWPORT) {

Sergey Sharybin commented

2024-02-27 14:27:07 +01:00

Intuitively this check should only be done for viewport mode of the depsgraph, and the final render should ignore the viewport visibility.

JacquesLucke marked this conversation as resolved

Jacques Lucke added 2 commits 2024-02-28 10:58:38 +01:00

aa11730b2f Merge branch 'blender-v4.1-release' into invisible-speaker

1b251bd62c also use render visibility

Jacques Lucke commented

2024-02-28 11:02:08 +01:00

Unfortunately, this doesn't seem to work with the "Render Audio"/"Mixdown" operator yet. It ignores anything I do in geometry nodes.
I tried to dynamically enable/disable a speaker. It does work with normal playback in the viewport though.

Unfortunately, this doesn't seem to work with the "Render Audio"/"Mixdown" operator yet. It ignores anything I do in geometry nodes. I tried to dynamically enable/disable a speaker. It does work with normal playback in the viewport though. ![image](/attachments/d6be8733-69e6-40e9-a08b-0bcb34f88af6)

image.png

179 KiB

Sergey Sharybin commented

2024-02-28 11:14:27 +01:00

@JacquesLucke I don't think the Mixdown operator actually takes care of dependency graph updates. It just gets the state of audio at the invokation, and mixes that down. That'd probably be nice to address, but sounds like a bigger scope that this PR.

Jacques Lucke commented

2024-02-28 11:16:37 +01:00

It does some to take the depsgraph into account a little bit in sound_bake_animation_exec but not sure how that relates to the rest exactly...

It does some to take the depsgraph into account a little bit in `sound_bake_animation_exec` but not sure how that relates to the rest exactly...

Sergey Sharybin commented

2024-02-28 11:38:28 +01:00

It is only done to access evaluated scene, and from there scene_eval->sound_scene. The rest happens in the Audaspace, which does not take care of the Blender's scene updates.

It is only done to access evaluated scene, and from there `scene_eval->sound_scene`. The rest happens in the Audaspace, which does not take care of the Blender's scene updates.

This pull request is marked as a work in progress.

This branch is out-of-date with the base branch

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u invisible-speaker:JacquesLucke-invisible-speaker

git checkout JacquesLucke-invisible-speaker

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Fix #117408: only take speakers into account that are visible on evaluated objects #118800

Checkout