Fix: Small changes to USD and Alembic curves import #118829

Hans Goudey · 2024-02-28T03:52:26+01:00

Hans Goudey commented

2024-02-28 03:52:26 +01:00

Make both importers work the same way: first building an array
of the new offsets, then comparing the offsets to check if the
topology changed. Previously the USD importer incorrectly
compared curve offsets to USD point counts.

Also:

Don't unnecessarily set the resolution to the incorrect default.
The default for the curves system is 12. But it's unnecessary to
fill the attribute to the default value anyway.
Use some helper methods to iterate over all curves.
Use float literal instead of integer.
Use cast and copy_from for positions copy

Make both importers work the same way: first building an array of the new offsets, then comparing the offsets to check if the topology changed. Previously the USD importer incorrectly compared curve offsets to USD point counts. Also: - Don't unnecessarily set the resolution to the incorrect default. The default for the curves system is 12. But it's unnecessary to fill the attribute to the default value anyway. - Use some helper methods to iterate over all curves. - Use float literal instead of integer. - Use cast and `copy_from` for positions copy

Hans Goudey added 1 commit 2024-02-28 03:52:35 +01:00

2adbc2afc0 Fix: Small changes to USD and Alembic curves import

Make both importers work the same way: first building an array
of the new offsets, then comparing the offsets to check if the
topology changed. Previously the USD importer incorrectly
compared curve offsets to USD point counts.

Also:
- Don't unnecessarily set the resolution to the incorrect default.
  The default for the curves system is 12. But it's unnecessary to
  fill the attribute to the default value anyway.
- Use some helper methods to iterate over all curves.
- Use float literal instead of integer.

Hans Goudey requested review from Jesse Yurkovich 2024-02-28 03:52:47 +01:00

Hans Goudey added this to the Pipeline, Assets & IO project 2024-02-28 03:52:53 +01:00

Hans Goudey added 1 commit 2024-02-28 04:01:47 +01:00

2c01509810 More float literals

Jesse Yurkovich approved these changes 2024-02-28 04:49:10 +01:00

Jesse Yurkovich left a comment

Thanks for taking a look here. calc_curve_offsets makes things a lot nicer. In the future you can punt this work back to me if you like; just nudge me in the direction you want and I'll try to take care of it.

While you're in here, do you mind dropping the reference from line 62:
const Span<pxr::GfVec3f> &usdPoints

Thanks for taking a look here. `calc_curve_offsets` makes things _a lot_ nicer. In the future you can punt this work back to me if you like; just nudge me in the direction you want and I'll try to take care of it. While you're in here, do you mind dropping the reference from line 62: `const Span<pxr::GfVec3f> &usdPoints`

Hans Goudey added 1 commit 2024-02-28 05:00:30 +01:00

ded394b4a6 Pass Span argument by value

Hans Goudey commented

2024-02-28 05:01:02 +01:00

In the future you can punt this work back to me if you like; just nudge me in the direction you want and I'll try to take care of it.

Thanks! I'll keep that in mind! This time this was just stuff I noticed reading through the code as a refresher.

>In the future you can punt this work back to me if you like; just nudge me in the direction you want and I'll try to take care of it. Thanks! I'll keep that in mind! This time this was just stuff I noticed reading through the code as a refresher.

Hans Goudey merged commit 5c5089d651 into main

2024-02-28 05:06:02 +01:00

Hans Goudey referenced this issue from a commit

2024-02-28 05:06:02 +01:00

Fix: Small changes to USD and Alembic curves import

Hans Goudey deleted branch cleanup-usd-abc-curves-import

2024-02-28 05:06:04 +01:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix: Small changes to USD and Alembic curves import #118829