Fix #117515: Geometry Nodes: Count of unique face neighbors #118848
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#118848
Loading…
Reference in New Issue
No description provided.
Delete Branch "mod_moder/blender:tmp_change_face_neighboards_num"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Regular topology mapping does not care about deduplication of relations. And
this is correct for a lot of the case where we expect creating difference of this
relations in next operations. But this is not the case for users, since this should
be actually trivial info. Due to this reason, construct full topology map and count
number of unique connections. Performance side: difference linear check and
hash set for different sizes of connections set.
Fix #1133939: Geometry Nodes: Count of unique face neighborsto Fix #117515: Geometry Nodes: Count of unique face neighbors@ -34,1 +33,3 @@
face_count[face_index] += edge_count[edge] - 1;
Array<int> face_count(face_edges.size());
threading::parallel_for(face_edges.index_range(), 2048, [&](const IndexRange range) {
Set<int, 16> faces;
Can you if this is faster if you use a
Vector<int, 16>
withappend_non_duplicates
as long as there are only very few edges? Might even be worth to optimize this for the case of triangles and quads to completely remove the need for the temporary set.100-face connected edge stars still can be there, it is really faster to do not use Set in such case?
No, but that's why I'm saying that there can be an optimized code path for the case when a face has few edges.
Timer 'build_edge_to_face_map': (Average: 94.76 ms, Min: 87.78 ms, Last: 91.32 ms)
Timer 'face_count: Set': (Average: 45.45 ms, Min: 43.29 ms, Last: 44.13 ms)
Timer 'face_count: Vector': (Average: 30.72 ms, Min: 26.79 ms, Last: 27.73 ms)
Timer 'face_count: unique_num': (Average: 37.44 ms, Min: 34.96 ms, Last: 36.54 ms)
@ -21,3 +24,3 @@
}
static VArray<int> construct_neighbor_count_varray(const Mesh &mesh, const AttrDomain domain)
static bool enught_large_total(const GroupedSpan<int> values,
Grammar:
large_enough_total_size
@ -38,0 +46,4 @@
}
return unique_values.size();
}
else {
else after return is unnecessary
Looks like this isn't resolved right now
@ -38,0 +64,4 @@
GroupedSpan<int> edge_to_faces_map;
{
SCOPED_TIMER_AVERAGED("build_edge_to_face_map");
I guess these timers can be removed now
3b2aa03d93
to2a5b5a4123
@blender-bot build
c52461f7ab
toaa04229ddc