Fix: Relative "Temporary Files" preference cause trouble (can crash) #118856
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#118856
Loading…
Reference in New Issue
No description provided.
Delete Branch "lichtwerk/blender:95411"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
An assert for this was added in
28c34d332f
But basically specifying "//" was still accepted in release builds.
This caused the following warning:
WARN (bke.appdir): source/blender/blenkernel/intern/appdir.cc:1168 tempdir_session_create: Could not generate a temp file name for '// blender_FkRpQj', falling back to '//'
And then made all sorts of operators fail (most using
BKE_tempdir_base
/
BKE_tempdir_session
e.g. autosave or clipboard operators):Unable to save '//297042_autosave.blend': Permission denied
Exporting to Collada would even crash because
COLLADASW::StreamWriter
does not handle relative paths.
So fixes #95411.
Now only use the provided userdir if it is not relative (and fallback to
BLI_temp_directory_path_get
otherwise).NOTE: making this more obvious in the UI would probably be nice, too
(but it seems setting
alert
on a filepath row does not work properly-- so this is skipped in this PR)
@ -1122,3 +1122,3 @@
tempdir[0] = '\0';
if (userdir && userdir[0] != '\0' && BLI_is_dir(userdir)) {
if (userdir && userdir[0] != '\0' && BLI_is_dir(userdir) && !BLI_path_is_rel(userdir)) {
This check should be added to
BLI_temp_directory_path_get
where "//" values could be passed in via environment variables.While skipping these directories prevents the error, they can also be set via environment variables where they are valid paths:
ls //usr/lib
on Linux for e.g. gives the same results asls /usr/lib
.When reviewing this patch I was going to suggest to skip the "//" instead of ignoring the paths but it turned out to be a different enough that I ended up submitting a separate PR !118872.
Will close in favor of !118872
(Since that will still crash collada on specific input, will make a PR of that separately)
Pull request closed