WM: explicitly skip auto-save when in modes that don't support it #118892

Jacques Lucke · 2024-02-29T10:22:05+01:00

Jacques Lucke commented

2024-02-29 10:22:05 +01:00

This implements the first part of what was discussed here.

Auto-save currently only really works in modes that use the MemFile undo step, that excludes things like mesh edit and sculpt mode. Previously, Blender would attempt to auto-save in those modes, but it would only save the last state from before the mode was entered, which is useless when staying in the mode for longer. This problem is not fixed here. However, the code now explicitly skips auto-saving in order to avoid unnecessary short freezes in these modes when Blender auto-saves. Furthermore, the auto-save will happen when changing modes.

This reduces the impact of save-time-regressions with #106903.

This implements the first part of what was discussed [here](https://devtalk.blender.org/t/remove-support-for-saving-memfile-undo-steps-as-blend-files-proposal/33544/12?u=jacqueslucke). Auto-save currently only really works in modes that use the `MemFile` undo step, that excludes things like mesh edit and sculpt mode. Previously, Blender would attempt to auto-save in those modes, but it would only save the last state from before the mode was entered, which is useless when staying in the mode for longer. This problem is *not* fixed here. However, the code now explicitly skips auto-saving in order to avoid unnecessary short freezes in these modes when Blender auto-saves. Furthermore, the auto-save will happen when changing modes. This reduces the impact of save-time-regressions with #106903.

Jacques Lucke added 3 commits 2024-02-29 10:22:16 +01:00

bac5384abb update auto-save

041c4106bf fix

9a349ad592 add comment

Jacques Lucke requested review from Brecht Van Lommel 2024-02-29 10:23:29 +01:00

Brecht Van Lommel commented

2024-02-29 10:30:04 +01:00

Does this now autosave when exiting modes?

To me that's an important part, because previously while in edit/sculpt modes it would still autosave changes that were flushed by switching modes.

Does this now autosave when exiting modes? To me that's an important part, because previously while in edit/sculpt modes it would still autosave changes that were flushed by switching modes.

Jacques Lucke commented

2024-02-29 10:36:25 +01:00

Ah, right now the patch only auto-saves (almost) immediately after going to a mode that uses MemFile, but not when switching between edit and sculpt mode. Will fix.

Ah, right now the patch only auto-saves (almost) immediately after going to a mode that uses `MemFile`, but not when switching between edit and sculpt mode. Will fix.

Jacques Lucke added 1 commit 2024-02-29 11:08:18 +01:00

de05f60e27 auto save on mode change

Jacques Lucke commented

2024-02-29 11:09:47 +01:00

It should auto-save on mode changes now, if the auto-save timer was up while in a mode that didn't support it.
I couldn't verify that Blender would auto-save when switching between edit/sculpt mode before though.

It should auto-save on mode changes now, if the auto-save timer was up while in a mode that didn't support it. I couldn't verify that Blender would auto-save when switching between edit/sculpt mode before though.

Brecht Van Lommel requested changes 2024-02-29 11:34:11 +01:00

Dismissed

source/blender/blenkernel/BKE_global.hh Outdated

						
				@ -160,1 +160,4 @@

				  int opengl_deprecation_usage_lineno;

				  /** Auto-save timer was up, but it wasn't possible to auto-save in the current mode. */

				  bool autosave_scheduled;

Brecht Van Lommel commented

2024-02-29 11:32:40 +01:00

I would put this autosave_schedule in wm next to wm->autosavetimer, and then have a WM_autosave_if_scheduled function.

Seems better to me to me than spreading this state across more places.

I would put this `autosave_schedule` in `wm` next to `wm->autosavetimer`, and then have a `WM_autosave_if_scheduled` function. Seems better to me to me than spreading this state across more places.

JacquesLucke marked this conversation as resolved

source/blender/windowmanager/intern/wm_files.cc

						
				@ -2139,0 +2141,4 @@

				  BlendFileWriteParams params{};

				  BLO_write_file(bmain, filepath, fileflags, &params, nullptr);

				  G.autosave_scheduled = false;