blender/blender

Fix: Crash when using compositor debugger #118904

Merged

Omar Emara merged 2 commits from OmarEmaraDev/blender:fix-compositor-debug-names into main

2024-03-01 08:45:49 +01:00

Omar Emara commented

2024-02-29 14:09:38 +01:00

Member

Blender crashes when using the compositor debugger. That's because it
assumes the names of the operation classes will be demangled and will
proceed to slice them causing crashes. The standard makes no guarantees
about the form of the returned type_info::name, and it is implementation
defined.

While it is possible to demangle those names and return something that
is more human readable, it doesn't seem worth it as this is only used by
developers who should have no problem identifying mangled names. So we
just display the name as is.

Blender crashes when using the compositor debugger. That's because it assumes the names of the operation classes will be demangled and will proceed to slice them causing crashes. The standard makes no guarantees about the form of the returned type_info::name, and it is implementation defined. While it is possible to demangle those names and return something that is more human readable, it doesn't seem worth it as this is only used by developers who should have no problem identifying mangled names. So we just display the name as is.

Omar Emara added the

labels 2024-02-29 14:09:38 +01:00

Omar Emara added 1 commit 2024-02-29 14:09:48 +01:00

Fix: Crash when using compositor debugger 3d4df2a7b6

Blender crashes when using the compositor debugger. That's because it
assumes the names of the operation classes will be demangled and will
proceed to slice them causing crashes. The standard makes no guarantees
about the form of the returned type_info::name, and it is implementation
defined.

While it is possible to demangle those names and return something that
is more human readable, it doesn't seem worth it as this is only used by
developers who should have no problem identifying mangled names. So we
just display the name as is.

Omar Emara requested review from Sergey Sharybin 2024-02-29 14:10:04 +01:00

Sergey Sharybin approved these changes 2024-02-29 14:24:26 +01:00

Sergey Sharybin left a comment

Owner

Can do something like

fi (pos == std::string::npos) {
  return full_name;
}

but I do not have strong preference for that.

Can do something like ``` fi (pos == std::string::npos) { return full_name; } ``` but I do not have strong preference for that.

Omar Emara added 1 commit 2024-03-01 08:43:59 +01:00

Handle both mangled and demangled names 21196d83ca

Omar Emara merged commit bcb0d6ef9f into main

2024-03-01 08:45:49 +01:00

Omar Emara referenced this issue from a commit

2024-03-01 08:45:49 +01:00

Fix: Crash when using compositor debugger

Omar Emara deleted branch fix-compositor-debug-names

2024-03-01 08:45:51 +01:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118904

No description provided.