Fix #117795: Refactor code from 9 years ago forgot to cleanup flags of embedded IDs. #118921

Merged
Bastien Montagne merged 2 commits from mont29/blender:tmp-117795 into blender-v4.1-release 2024-03-01 11:28:49 +01:00

In 3fcf535d2e, the ID.flag data was split, keeping persisten flags in
ID.flag, and moving runtime ones into a new ID.tag data.

Some versioning code was then added to cleanup the existing ID.flag
on file read, but embedded IDs (root node trees only, back then) are not
stored in Main data-base, and were skipped.

Some additional 'sanity check' was also added to fix the specific case
reported in #117795 (embedded IDs falsely flagged as embedded
liboverrides), however there is no general reliable way to fix all potential
issues caused by this mistake, when a pre-2.76 blendfile is open by a
pre-4.1 blender and saved again.

In 3fcf535d2e, the `ID.flag` data was split, keeping persisten flags in `ID.flag`, and moving runtime ones into a new `ID.tag` data. Some versioning code was then added to cleanup the existing `ID.flag` on file read, but embedded IDs (root node trees only, back then) are not stored in Main data-base, and were skipped. Some additional 'sanity check' was also added to fix the specific case reported in #117795 (embedded IDs falsely flagged as embedded liboverrides), however there is no general reliable way to fix all potential issues caused by this mistake, when a pre-2.76 blendfile is open by a pre-4.1 blender and saved again.
Bastien Montagne force-pushed tmp-117795 from 7c4d0e0ed2 to 1b19405df8 2024-03-01 10:45:49 +01:00 Compare
Author
Owner

@blender-bot build

@blender-bot build
Bastien Montagne merged commit 71df742eb4 into blender-v4.1-release 2024-03-01 11:28:49 +01:00
Bastien Montagne deleted branch tmp-117795 2024-03-01 11:28:55 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118921
No description provided.