Fix #117795: Refactor code from 9 years ago forgot to cleanup flags of embedded IDs. #118921

Bastien Montagne · 2024-02-29T18:35:49+01:00

Bastien Montagne commented

2024-02-29 18:35:49 +01:00

In 3fcf535d2e, the ID.flag data was split, keeping persisten flags in
ID.flag, and moving runtime ones into a new ID.tag data.

Some versioning code was then added to cleanup the existing ID.flag
on file read, but embedded IDs (root node trees only, back then) are not
stored in Main data-base, and were skipped.

Some additional 'sanity check' was also added to fix the specific case
reported in #117795 (embedded IDs falsely flagged as embedded
liboverrides), however there is no general reliable way to fix all potential
issues caused by this mistake, when a pre-2.76 blendfile is open by a
pre-4.1 blender and saved again.

In 3fcf535d2e, the `ID.flag` data was split, keeping persisten flags in `ID.flag`, and moving runtime ones into a new `ID.tag` data. Some versioning code was then added to cleanup the existing `ID.flag` on file read, but embedded IDs (root node trees only, back then) are not stored in Main data-base, and were skipped. Some additional 'sanity check' was also added to fix the specific case reported in #117795 (embedded IDs falsely flagged as embedded liboverrides), however there is no general reliable way to fix all potential issues caused by this mistake, when a pre-2.76 blendfile is open by a pre-4.1 blender and saved again.

Bastien Montagne referenced this pull request

2024-02-29 18:37:34 +01:00

Crash when opening the Compositor in an old file #117795

Bastien Montagne force-pushed tmp-117795 from 7c4d0e0ed2 to 1b19405df8

2024-03-01 10:45:49 +01:00

Compare

Bastien Montagne commented

2024-03-01 10:50:04 +01:00

@blender-bot build

Bastien Montagne merged commit 71df742eb4 into blender-v4.1-release

2024-03-01 11:28:49 +01:00

Bastien Montagne referenced this issue from a commit