WIP: Vulkan: Prototype Rendergraph #118963

Jeroen Bakker · 2024-03-01T14:05:40+01:00

Jeroen Bakker commented

2024-03-01 14:05:40 +01:00

This is a render graph implementation for optimizing GPU tasks based on resource usage
and task similarity.

Current State: Early Development
Currently has some black box test cases and GPU_storage_buffer_clear/read_back is in the making.
When ready this rework will be split in several smaller patches.
I expect this to land after 1 month of active development and 1 month of testing and platform validation.

classDiagram
    class VKNode {
        set_data(node, data)
        free_data(data)
        build_resource_dependencies
        build_commands
    }

    class VKResources
    class VKResourceDependencies
    class VKCommandBufferInterface

References

#118330 - Vulkan Rendergraph design to solve synchronization issues.

TODO:

Use single .hh file per node.
Add Super class for node.
Split render graph and resources. render graph will become a context owned instance.
VKTexture/Buffer will contain a render graph resource handle.
Move some generics to a GPU super class.
Missing render graph nodes
- VKIndirectDispatchNode
- VkCopyBufferToImageNode
- VkCopyImageToBufferNode
- VkCopyImageNode
- VkBlitNode
- VkDrawNode
- VkDrawInstancedNode
- VkDrawIndirectNode
- VkDrawInstancedIndirectNode
Image resources are not automatically tracked.
Add support for push constants
Use a code generator for debugging and command wrappers
Add header documentation about scope, responsibility usage.
Adding Debug groups Perhaps per pipeline like metal does.
What to document
- Resource life cycle management.

classDiagram
    class VKRenderGraph
    class VKRenderGraphResources
    class VKRenderGraphNodes
    class VKRenderGraphCommandBuilder
    class VKRenderGraphCommandBuffer
    class VKRenderGraphScheduler
    class VKPipelines {
        get_or_create_compute_pipeline(): VkPipeline
    }

    VKRenderGraph *--> VKRenderGraphResources: resources
    VKRenderGraph *--> VKRenderGraphNodes: nodes
    VKRenderGraph *--> VKRenderGraphCommandBuilder: command_builder
    VKRenderGraph *--> VKRenderGraphCommandBuffer: command_buffer
    VKRenderGraph *--> VKRenderGraphScheduler: scheduler
    VKDevice *--> VKRenderGraph: render_graph
    VKDevice *--> VKPipelines: pipelines

Commit Split

Rendergraph base classes + test cases
rest?

Cleanups

Some areas that can be committed to main as they are clean ups and might break other patches in development. Also makes reviewing the essential parts of this PR easier.

vk_to_string
MoltenVK - is mentioned as a cleanup as we used to support it, but was disabled due to lacking support from MoltenVK.
introduce AddToDescriptorSetData
VKDescriptorSetLayouts

This is a render graph implementation for optimizing GPU tasks based on resource usage and task similarity. **Current State**: *Early Development* Currently has some black box test cases and GPU_storage_buffer_clear/read_back is in the making. When ready this rework will be split in several smaller patches. I expect this to land after 1 month of active development and 1 month of testing and platform validation. ```mermaid classDiagram class VKNode { set_data(node, data) free_data(data) build_resource_dependencies build_commands } class VKResources class VKResourceDependencies class VKCommandBufferInterface ``` ## References - #118330 - Vulkan Rendergraph design to solve synchronization issues. **TODO:** - [x] Use single .hh file per node. - [ ] Add Super class for node. - [x] Split render graph and resources. render graph will become a context owned instance. - [ ] VKTexture/Buffer will contain a render graph resource handle. - [ ] Move some generics to a GPU super class. - [ ] Missing render graph nodes - [ ] `VKIndirectDispatchNode` - [x] `VkCopyBufferToImageNode` - [x] `VkCopyImageToBufferNode` - [x] `VkCopyImageNode` - [x] `VkBlitNode` - [ ] `VkDrawNode` - [ ] `VkDrawInstancedNode` - [ ] `VkDrawIndirectNode` - [ ] `VkDrawInstancedIndirectNode` - [x] Image resources are not automatically tracked. - [x] Add support for push constants - [x] Use a code generator for debugging and command wrappers - [ ] Add header documentation about scope, responsibility usage. - [ ] Adding Debug groups Perhaps per pipeline like metal does. - [ ] What to document - [ ] Resource life cycle management. ```mermaid classDiagram class VKRenderGraph class VKRenderGraphResources class VKRenderGraphNodes class VKRenderGraphCommandBuilder class VKRenderGraphCommandBuffer class VKRenderGraphScheduler class VKPipelines { get_or_create_compute_pipeline(): VkPipeline } VKRenderGraph *--> VKRenderGraphResources: resources VKRenderGraph *--> VKRenderGraphNodes: nodes VKRenderGraph *--> VKRenderGraphCommandBuilder: command_builder VKRenderGraph *--> VKRenderGraphCommandBuffer: command_buffer VKRenderGraph *--> VKRenderGraphScheduler: scheduler VKDevice *--> VKRenderGraph: render_graph VKDevice *--> VKPipelines: pipelines ``` **Commit Split** - [ ] Rendergraph base classes + test cases - [ ] rest? **Cleanups** Some areas that can be committed to main as they are clean ups and might break other patches in development. Also makes reviewing the essential parts of this PR easier. - [x] vk_to_string - [ ] MoltenVK - is mentioned as a cleanup as we used to support it, but was disabled due to lacking support from MoltenVK. - [ ] introduce `AddToDescriptorSetData` - [ ] `VKDescriptorSetLayouts`

👍 1

Jeroen Bakker added this to the 4.3 milestone 2024-03-01 14:05:40 +01:00

Jeroen Bakker added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Vulkan: Prototype Rendergraph #118963

References

Pull request closed