UI: Props Dialog Default Properties #119007

Harley Acheson · 2024-03-02T18:47:19+01:00

Harley Acheson commented

2024-03-02 18:47:19 +01:00

Allow activating numerical buttons upon opening of props dialogs. Set
defaults for some dialogs where appropriate.

When props dialogs open we can currently set that a particular input should be active right away by setting the property as default. Unfortunately this currently only works for text inputs. This PR adds code to allow setting a numerical input as activated on open and then also sets four defaults where appropriate:

For ARMATURE_OT_move_to_collection when adding to a new bone collection, this PR changes the title slightly to include "Bone Collection". Otherwise this dialog you get when hitting "M" in pose mode looks exactly the same as hitting "M" in object mode, which are very different. This also adds "Bones" as the default bone collection name as it is in the list itself.

Allow activating numerical buttons upon opening of props dialogs. Set defaults for some dialogs where appropriate. --- When props dialogs open we can currently set that a particular input should be active right away by setting the property as default. Unfortunately this currently only works for text inputs. This PR adds code to allow setting a numerical input as activated on open and then also sets four defaults where appropriate: ![image](/attachments/e17ac827-0125-4626-84df-e1cbfa3bc859) ![image](/attachments/4c4709f3-95bc-4abb-95ac-077ade8a271a) ![image](/attachments/03d0b356-a74b-4bc0-985a-44f2c4e6fc62) For `ARMATURE_OT_move_to_collection` when adding to a new bone collection, this PR changes the title slightly to include "Bone Collection". Otherwise this dialog you get when hitting "M" in pose mode looks exactly the same as hitting "M" in object mode, which are very different. This also adds "Bones" as the default bone collection name as it is in the list itself. ![image](/attachments/136aa90e-8aab-47c8-a2de-a59cd2d31ec0)

image.png

9.6 KiB

image.png

12 KiB

image.png

12 KiB

image.png

32 KiB

❤️ 2

Harley Acheson added 1 commit 2024-03-02 18:47:29 +01:00

2925524857 UI: Props Dialog Default Properties

Allow activating numerical buttons upon opening of props dialogs. Set
defaults for some dialogs where appropriate.

Harley Acheson added this to the User Interface project 2024-03-02 18:47:57 +01:00

Hans Goudey reviewed 2024-03-02 20:12:13 +01:00

source/blender/editors/armature/bone_collections.cc

						
				@ -1166,8 +1166,9 @@ static int move_to_collection_regular_invoke(bContext *C, wmOperator *op)

				static int move_to_new_collection_invoke(bContext *C, wmOperator *op)

				{

				  RNA_string_set(op->ptr, "new_collection_name", IFACE_("Bones"));

Hans Goudey commented

2024-03-02 20:12:10 +01:00

Could this be done by giving the string property a default value? That seems better than potentially overridint a value remembered from last time or a value set explicitly

Harley marked this conversation as resolved

source/blender/editors/space_image/image_ops.cc Outdated

						
				@ -2622,6 +2622,7 @@ static int image_new_invoke(bContext *C, wmOperator *op, const wmEvent * /*event

				  /* Better for user feedback. */

				  RNA_string_set(op->ptr, "name", DATA_(IMA_DEF_NAME));

				  op->type->prop = RNA_struct_find_property(op->ptr, "name");

Hans Goudey commented

2024-03-02 20:10:17 +01:00

Feels like this should be done when defining the property. I think the operator type should basically be considered const after it is registered

Harley marked this conversation as resolved

Harley Acheson commented

2024-03-02 21:02:17 +01:00

@HooglyBoogly Feels like this should be done when defining the property. I think the operator type should basically be considered const after it is registered

Yes, makes sense. I actually only just noticed that op->type->prop is meant for this use. Looks messy though, probably needs a helper like RNA_property_set_default?

> @HooglyBoogly Feels like this should be done when defining the property. I think the operator type should basically be considered const after it is registered Yes, makes sense. I actually only just noticed that `op->type->prop` is meant for this use. Looks messy though, probably needs a helper like `RNA_property_set_default`?

Hans Goudey commented

2024-03-02 21:10:46 +01:00

Yes, makes sense. I actually only just noticed that op->type->prop is meant for this use. Looks messy though, probably needs a helper like RNA_property_set_default?

It's usually written like ot->prop = RNA_def_* which isn't so bad. It's really more related to the operator system than RNA. So if we had something, WM_operator_set_default_prop might be better. But I'd probably wait for something like a different API for registering operators.

> Yes, makes sense. I actually only just noticed that `op->type->prop` is meant for this use. Looks messy though, probably needs a helper like `RNA_property_set_default`? It's usually written like `ot->prop = RNA_def_*` which isn't so bad. It's really more related to the operator system than RNA. So if we had something, `WM_operator_set_default_prop` might be better. But I'd probably wait for something like a different API for registering operators.

Harley Acheson commented

2024-03-02 21:23:43 +01:00

@HooglyBoogly - It's usually written like ot->prop = RNA_def_* which isn't so bad...

OMG, I didn't recognize that this is what that was doing. Just because we have so many instances where we assign to it multiple times - like in ANIM_OT_channels_view_selected for example.

But I see that now. Finally makes sense. LOL.

> @HooglyBoogly - It's usually written like `ot->prop = RNA_def_*` which isn't so bad... OMG, I didn't recognize that this is what that was doing. Just because we have so many instances where we assign to it multiple times - like in ANIM_OT_channels_view_selected for example. But I see that now. Finally makes sense. LOL.

😆 1

Harley Acheson added 2 commits 2024-03-02 22:07:10 +01:00

6dd770c4c8 Merge branch 'main' of projects.blender.org:blender/blender into ProDialogDefProps

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

0863bcf8cc changes requested by review.

Harley Acheson commented

2024-03-02 22:10:22 +01:00

Could this be done by giving the string property a default value? That seems better than potentially overriding a value remembered from last time or a value set explicitly

I don't think so? The property would then just have that value in times when it could otherwise be blank. Setting the default name or value there fits with similar uses in image_new_invoke, move_to_collection_invoke.

> Could this be done by giving the string property a default value? That seems better than potentially overriding a value remembered from last time or a value set explicitly I don't think so? The property would then just have that value in times when it could otherwise be blank. Setting the default name or value there fits with similar uses in image_new_invoke, move_to_collection_invoke.

Harley Acheson commented

2024-03-03 00:50:59 +01:00

@HooglyBoogly

Testing the idea of just adding these as property defaults, I am seeing odd things to do with translation. As in if I make the default string "Bones", IFACE_("Bones"), N_("Bones"), etc it works in English, but in Spanish I only ever see the word "Bones". Even though I know that this word is translated because I see "Huesos" if add one in the Bone Collections list.

But does work where I have it in the invoke.

@HooglyBoogly Testing the idea of just adding these as property defaults, I am seeing odd things to do with translation. As in if I make the default string `"Bones"`, ` IFACE_("Bones")`, `N_("Bones")`, etc it works in English, but in Spanish I only ever see the word "Bones". Even though I know that this word is translated because I see "Huesos" if add one in the Bone Collections list. But does work where I have it in the invoke.

Hans Goudey commented

2024-03-03 01:33:46 +01:00

Great point, didn't think of that!