Fix #119047: Avoid copying captured attribute to itself #119063

Hans Goudey · 2024-03-04T21:36:18+01:00

Hans Goudey commented

2024-03-04 21:36:18 +01:00

The "capture field on geometry" utility is used in many places to store
the result of field evaluation as an attribute. There is a special case
for when an attribute already exists with the same name, data type, and
domain. But when exactly the same attribute was stored, it would assert
because it ended up copying an array to itself. Arguments for those copy
functions aren't supposed to alias each other.

As a fix, clarify the logic a bit to return earlier in this case.
Also remove a redundant case handling the same thing later on in
the function.

The "capture field on geometry" utility is used in many places to store the result of field evaluation as an attribute. There is a special case for when an attribute already exists with the same name, data type, and domain. But when exactly the same attribute was stored, it would assert because it ended up copying an array to itself. Arguments for those copy functions aren't supposed to alias each other. As a fix, clarify the logic a bit to return earlier in this case. Also remove a redundant case handling the same thing later on in the function.

Hans Goudey added 1 commit 2024-03-04 21:36:28 +01:00

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

49cb1772bd Fix #119047 : Avoid copying captured attribute to itself

The "capture field on geometry" utility is used in many places to store
the result of field evaluation as an attribute. There is a special case
for when an attribute already exists with the same name, data type, and
domain. But when exactly the same attribute was stored to itself, the
code would assert because it ended up copying an array to itself.
Arguments for those copy functions aren't supposed to alias each other.

As a fix, clarify the logic a bit to return earlier in this case.
Also remove a redundant case handling the same thing later on in
the function.

Hans Goudey requested review from Jacques Lucke 2024-03-04 21:37:20 +01:00

Hans Goudey added this to the Nodes & Physics project 2024-03-04 21:37:29 +01:00

Hans Goudey added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #119047: Avoid copying captured attribute to itself #119063