Fix #119055: GPv3: Eraser changes cap type in unrelated strokes #119079

Pratik Borhade · 2024-03-05T11:17:31+01:00

Pratik Borhade commented

2024-03-05 11:17:31 +01:00

End cap of stroke changes to flat when first point of next stroke is
removed. Avoid changing the end_cap when source and destination curve
count is same.

End cap of stroke changes to `flat` when first point of next stroke is removed. Avoid changing the `end_cap` when source and destination curve count is same.

Pratik Borhade added 1 commit 2024-03-05 11:17:40 +01:00

837507d6ba Fix #119055 : GPv3: Eraser changes cap type in unrelated strokes

End cap of stroke changes to `flat` when first point of next stroke is
removed. Avoid changing the `end_cap` when source and destination curve
count is same.

Pratik Borhade requested review from Lukas Tönne 2024-03-05 11:17:56 +01:00

Pratik Borhade requested review from Falk David 2024-03-05 11:17:56 +01:00

Pratik Borhade referenced this pull request

2024-03-05 11:20:31 +01:00

GPv3: Eraser changes cap type in unrelated strokes #119055

Pratik Borhade added the

Module

Grease Pencil

label 2024-03-05 11:28:01 +01:00

Lukas Tönne commented

2024-03-05 12:29:32 +01:00

I don't think this works as-is: It prevents changes to any end cap when the curves count doesn't change. This includes erasing the end of a stroke which should make it flat.

I'm pretty sure i've also still seen some unrelated strokes getting affected by cap changes after applying the patch, but i can't repro this reliably yet.

I don't think this works as-is: It prevents changes to _any_ end cap when the curves count doesn't change. This includes erasing the end of a stroke which should make it flat. I'm pretty sure i've also still seen some unrelated strokes getting affected by cap changes after applying the patch, but i can't repro this reliably yet.

Pratik Borhade commented

2024-03-05 12:40:30 +01:00

This includes erasing the end of a stroke which should make it flat.

This is true even without PR :)
is_cut is not set to true for curve end points (only done for first point of strokes)

I'm pretty sure i've also still seen some unrelated strokes getting affected by cap changes after applying the patch, but i can't repro this reliably yet.

Oh, okay. But I didn't notice in any other case apart from the case mentioned in the .blend file and explained in the PR (just erase inside circled area)

> This includes erasing the end of a stroke which should make it flat. This is true even without PR :) `is_cut` is not set to true for curve end points (only done for first point of strokes) > I'm pretty sure i've also still seen some unrelated strokes getting affected by cap changes after applying the patch, but i can't repro this reliably yet. Oh, okay. But I didn't notice in any other case apart from the case mentioned in the .blend file and explained in the PR (just erase inside circled area)

#119055.blend

938 KiB

Lukas Tönne commented

2024-03-05 16:20:43 +01:00

Here's a test demonstrating that the solution is incomplete: There are 3 curves with 2 points each. The eraser would miss one stroke entirely, cut the second stroke in half, and completely remove the third stroke.

Because the 3rd stroke is removed the overall number of curves changes, so it will pass the new condition and still set the end cap of the first stroke, which should remain untouched. We need a way to determine if the source point corresponding to the last point of the stroke is actually the last of its curve.

Here's a test demonstrating that the solution is incomplete: There are 3 curves with 2 points each. The eraser would miss one stroke entirely, cut the second stroke in half, and completely remove the third stroke. Because the 3rd stroke is removed the overall number of curves changes, so it will pass the new condition and still set the end cap of the first stroke, which should remain untouched. We need a way to determine if the source point corresponding to the last point of the stroke is actually the last of its curve. ![image](/attachments/5d0dd592-6859-432a-a141-0d785b96ea3d)

image.png

162 KiB

Pratik Borhade commented

2024-03-06 11:40:04 +01:00

Indeed, it fails in other cases as well. but at least now we know why end_cap of prior stroke is changing :)
Maybe @amelief know how to fix this.

Indeed, it fails in other cases as well. but at least now we know why `end_cap` of prior stroke is changing :) Maybe @amelief know how to fix this.

Pratik Borhade commented

2024-03-07 10:48:27 +01:00

#119151 🙂

https://projects.blender.org/blender/blender/pulls/119151 🙂

Pratik Borhade closed this pull request

2024-03-07 10:48:29 +01:00

Pratik Borhade deleted branch 119055-erase-start-point

2024-03-07 11:47:24 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #119055: GPv3: Eraser changes cap type in unrelated strokes #119079

Pull request closed