Refactor: ui_draw_popover_back Impossible Null Dereference #119092

Harley Acheson · 2024-03-05T17:32:51+01:00

Harley Acheson commented

2024-03-05 17:32:51 +01:00

The function ui_draw_popover_back has a "block" argument, that is
checked for null, but then has an "else" that would require it and
cause a null pointer dereference. This is an internal function that has
one caller, in response to a condition on that same block's flag.
Therefore this PR removes this function's check for null and the else
code as this condition is not possible.

This code section is mentioned in "Fragment N5" here: https://pvs-studio.com/en/blog/posts/cpp/1106/

The function ui_draw_popover_back has a "block" argument, that is checked for null, but then has an "else" that would require it and cause a null pointer dereference. This is an internal function that has one caller, in response to a condition on that same block's flag. Therefore this PR removes this function's check for null and the else code as this condition is not possible. --- This code section is mentioned in "Fragment N5" here: https://pvs-studio.com/en/blog/posts/cpp/1106/

Harley Acheson added 1 commit 2024-03-05 17:33:02 +01:00

a738c18c34 Fix: ui_draw_popover_back Impossible Null Dereference

The function ui_draw_popover_back has a "block" argument, that is
checked for null, but then has an "else" that would require it and
cause a null pointer dereference. This is an internal function that has
one caller, in response to a condition on that same block's flag.
Therefore this PR removes this function's check for null and the else
code as this condition is not possible.

Harley Acheson merged commit a1f92f5820 into main

2024-03-05 17:39:45 +01:00

Harley Acheson referenced this issue from a commit

2024-03-05 17:39:46 +01:00

Refactor: ui_draw_popover_back Impossible Null Dereference

Harley Acheson deleted branch MenuBackui_draw_popover_backNullBlock

2024-03-05 17:39:48 +01:00

Harley Acheson added this to the User Interface project 2024-03-05 21:54:08 +01:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Refactor: ui_draw_popover_back Impossible Null Dereference #119092