GPv3: Create weights on draw for new strokes. #119302

Open

casey-bianco-davis wants to merge 9 commits from casey-bianco-davis/blender:GPv3-Create-weights-on-draw into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

casey-bianco-davis commented

2024-03-11 01:54:10 +01:00

Member

Implements the legacy weight_data_add button for GPv3.

Note: This PR properly accounts for the bone's transformation when applying so that the stroke does not appear to teleport after drawing, unlike the legacy system.

Implements the legacy `weight_data_add` button for GPv3. Note: This PR properly accounts for the bone's transformation when applying so that the stroke does not appear to teleport after drawing, unlike the legacy system.

casey-bianco-davis added the

labels 2024-03-11 01:54:10 +01:00

casey-bianco-davis added 1 commit 2024-03-11 01:54:15 +01:00

0d4c9b5e81 GPv3: Create weights on draw.

casey-bianco-davis added this to the Grease Pencil project 2024-03-11 01:54:18 +01:00

casey-bianco-davis requested review from Falk David 2024-03-11 01:59:46 +01:00

casey-bianco-davis added 1 commit 2024-03-11 02:07:14 +01:00

4c1e01efa0 Cleanup: Skip invisible modifiers.

casey-bianco-davis added 1 commit 2024-03-11 03:14:14 +01:00

281e79d656 Merge branch 'main' into GPv3-Create-weights-on-draw

casey-bianco-davis added 1 commit 2024-03-13 04:17:00 +01:00

d094c8bfac Merge branch 'main' into GPv3-Create-weights-on-draw

Sietse Brouwer reviewed 2024-03-13 19:49:47 +01:00

Sietse Brouwer left a comment

Member

You are really on fire, I see a lot of great PRs from your hand – very nice!

A few tiny remarks from a fellow community contributor.

Btw, I like the addition of compensating for the bone transformation. It's one of those smart little things that make Grease Pencil artist-friendly.

You are really on fire, I see a lot of great PRs from your hand – very nice! A few tiny remarks from a fellow community contributor. Btw, I like the addition of compensating for the bone transformation. It's one of those smart little things that make Grease Pencil artist-friendly.

source/blender/editors/sculpt_paint/grease_pencil_paint.cc Outdated

						
				@ -596,0 +616,4 @@

				  const bDeformGroup *defgroup = static_cast<const bDeformGroup *>(

				      BLI_findlink(BKE_object_defgroup_list(object), def_nr));

Sietse Brouwer commented

2024-03-13 19:03:32 +01:00

Member

In case there is no vertex group:

if (def_nr == -1) {
  return;
}

In case there is no vertex group: ``` if (def_nr == -1) { return; } ```

casey-bianco-davis marked this conversation as resolved

source/blender/editors/sculpt_paint/grease_pencil_paint.cc

						
				@ -596,0 +620,4 @@

				  const StringRef vertex_group_name = defgroup->name;

				  blender::bke::greasepencil::assign_to_vertex_group_from_selection(

				      curves, IndexMask(points), vertex_group_name, 1.0f);

Sietse Brouwer commented

2024-03-13 19:13:38 +01:00

Member

Any reason to switch here from IndexRange to IndexMask? Ignore my question when there is 🔕

And at first glance I thought this function had something to do with the .selection attribute. So perhaps something like assign_to_vertex_group_from_range is a better name?

Any reason to switch here from `IndexRange` to `IndexMask`? Ignore my question when there is :no_bell: And at first glance I thought this function had something to do with the `.selection` attribute. So perhaps something like `assign_to_vertex_group_from_range` is a better name?

casey-bianco-davis marked this conversation as resolved

source/blender/editors/sculpt_paint/grease_pencil_paint.cc Outdated

						
				@ -596,0 +623,4 @@

				      curves, IndexMask(points), vertex_group_name, 1.0f);

				  /* Loop through all modifiers trying to find the pose channel for the vertex group name. */

				  bPoseChannel *channel = NULL;

Sietse Brouwer commented

2024-03-13 19:14:21 +01:00

Member

Here and below: NULL -> nullptr

Here and below: `NULL` -> `nullptr`

casey-bianco-davis marked this conversation as resolved

source/blender/editors/sculpt_paint/grease_pencil_paint.cc Outdated

						
				@ -596,0 +635,4 @@

				      continue;

				    }

				    GreasePencilArmatureModifierData *amd = (GreasePencilArmatureModifierData *)md;

Sietse Brouwer commented

2024-03-13 19:17:40 +01:00

Member

reinterpret_cast<GreasePencilArmatureModifierData *>(md)

`reinterpret_cast<GreasePencilArmatureModifierData *>(md)`

casey-bianco-davis marked this conversation as resolved

source/blender/editors/sculpt_paint/grease_pencil_paint.cc

						
				@ -596,0 +655,4 @@

				    break;

				  }

				  /* nothing valid was found. */

Sietse Brouwer commented

2024-03-13 19:18:17 +01:00

Member

Nitpick: Capital N.

Nitpick: Capital N.

casey-bianco-davis marked this conversation as resolved

casey-bianco-davis added 5 commits 2024-03-13 21:25:34 +01:00

eebb4bea80 Cleanup: Add safety check.

1add516398 Cleanup: Use `nullpty` rather than `NULL`

c01d397066 Cleanup: Fix grammar.

936fdc0905 Cleanup: Use a `reinterpret_cast`.

e1ca95a115 Cleanup: Rename `assign_to_vertex_group_from_selection` to `assign_to_vertex_group_from_mask`

casey-bianco-davis referenced this pull request

2024-03-24 22:13:06 +01:00

GPv3: Draw Mode #119741

Falk David requested changes 2024-03-29 12:56:25 +01:00

Falk David left a comment

Member

Thanks for looking into this. One concern I have is about trying to inverse the deformation of modifiers in the paint tool. From what I could find, this wasn't done in GPv2? Generally, if we wanted to support this, we should be using the get_evaluated_grease_pencil_drawing_deformation API. This would allow you to get a matrix per curve/point with the deformation. And each modifier that supports this deformed space, would write into the edit component.

Thanks for looking into this. One concern I have is about trying to inverse the deformation of modifiers in the paint tool. From what I could find, this wasn't done in GPv2? Generally, if we wanted to support this, we should be using the `get_evaluated_grease_pencil_drawing_deformation` API. This would allow you to get a matrix per curve/point with the deformation. And each modifier that supports this deformed space, would write into the edit component.

casey-bianco-davis commented

2024-03-29 21:35:55 +01:00

Author

Member

The legacy system did not convert the points when applying the weights.

I will look in to using get_evaluated_grease_pencil_drawing_deformation but currently it does not work with deform_mats

The legacy system did not convert the points when applying the weights. I will look in to using `get_evaluated_grease_pencil_drawing_deformation` but currently it does not work with `deform_mats`

This pull request has changes conflicting with the target branch.

scripts/startup/bl_ui/space_view3d.py
source/blender/blenkernel/intern/grease_pencil_vertex_groups.cc
source/blender/editors/sculpt_paint/grease_pencil_paint.cc

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u GPv3-Create-weights-on-draw:casey-bianco-davis-GPv3-Create-weights-on-draw

git checkout casey-bianco-davis-GPv3-Create-weights-on-draw

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119302

No description provided.