Fix #117798: "Nothing to Bake" when pose object is not selected #119317

Merged

Use context.pose_object when baking a pose, on on top of the objects
in context.selected_editable_objects. When in pose mode, it's expected
that the pose of the active will be baked, regardless of whether the
pose object is selected itself.

Use `context.pose_object` when baking a pose, on on top of the objects in `context.selected_editable_objects`. When in pose mode, it's expected that the pose of the active will be baked, regardless of whether the pose object is selected itself.
Sybren A. Stüvel added this to the 4.1 milestone 2024-03-11 11:54:39 +01:00
Sybren A. Stüvel added the
Module
Animation & Rigging
label 2024-03-11 11:54:39 +01:00
Christoph Lendenfeld was assigned by Sybren A. Stüvel 2024-03-11 11:54:39 +01:00
Nate Rupsis was assigned by Sybren A. Stüvel 2024-03-11 11:54:40 +01:00
Sybren A. Stüvel added 1 commit 2024-03-11 11:54:47 +01:00
Use `context.pose_object` when baking a pose, on on top of the objects
in `context.selected_editable_objects`. When in pose mode, it's expected
that the pose of the active will be baked, regardless of whether the
pose object is selected itself.
Sybren A. Stüvel requested review from Christoph Lendenfeld 2024-03-11 14:13:38 +01:00
Sybren A. Stüvel requested review from Nate Rupsis 2024-03-11 14:13:46 +01:00
Nate Rupsis reviewed 2024-03-11 15:24:01 +01:00
@ -292,0 +293,4 @@
if pose_object and pose_object not in objects:
# The active object might not be selected, but it is the one in pose mode,
# and thus it can be assumed that this is the pose that needs baking.
objects.append(context.pose_object)
Member

Slight comment conciseness suggestion:

# The active object might not be selected, but it is the one in pose mode.
# It can be assumed this pose needs baking.
Slight comment conciseness suggestion: ``` # The active object might not be selected, but it is the one in pose mode. # It can be assumed this pose needs baking. ```
dr.sybren marked this conversation as resolved
Nate Rupsis approved these changes 2024-03-11 15:24:04 +01:00
Sybren A. Stüvel added 1 commit 2024-03-11 17:10:50 +01:00
Sybren A. Stüvel merged commit 5531a191e8 into blender-v4.1-release 2024-03-11 17:11:25 +01:00
Sybren A. Stüvel deleted branch pr/fix-117798-bake-unselected-pose 2024-03-11 17:11:31 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119317
No description provided.