blender
/
blender
134
398
Fork 580
Code Issues 6.3k Pull Requests 757 Projects 19 Wiki Activity

GPv3: Initial sculpt mode #119338

Merged
Lukas Tönne merged 28 commits from LukasTonne/blender:gp3-sculpt-mode into main 2024-04-11 09:40:00 +02:00
Conversation 3 Commits 28 Files Changed 23 +469 -75
Lukas Tönne commented 2024-03-11 18:31:55 +01:00
Member
Copy Link

Adds an (empty) sculpt mode for Grease Pencil v3 objects.

The object SCULPT_GPENCIL mode is re-used for Grease Pencil object types.
A SCULPT_GREASE_PENCIL context mode has been added, which is specific
to grease pencil objects. This is necessary for polling tools and
keymaps.

Adds an (empty) sculpt mode for Grease Pencil v3 objects. The object `SCULPT_GPENCIL` mode is re-used for Grease Pencil object types. A `SCULPT_GREASE_PENCIL` context mode has been added, which is specific to grease pencil objects. This is necessary for polling tools and keymaps.
👍 1
Lukas Tönne added 3 commits 2024-03-11 18:32:06 +01:00
Lukas Tönne added this to the Grease Pencil project 2024-03-11 18:32:10 +01:00
Hans Goudey changed title from GPv3 sculpt mode to GPv3: Initial sculpt mode 2024-03-11 19:01:19 +01:00
Lukas Tönne added 1 commit 2024-03-11 19:41:04 +01:00
Lukas Tönne added 1 commit 2024-03-12 09:46:09 +01:00
Lukas Tönne added 1 commit 2024-03-12 09:50:13 +01:00
Falk David requested changes 2024-03-12 15:04:52 +01:00
Dismissed
Falk David left a comment
Member
Copy Link

Added some comments.

Added some comments.
source/blender/blenkernel/intern/paint.cc Outdated
@ -625,6 +625,7 @@ PaintMode BKE_paintmode_get_from_tool(const bToolRef *tref)
if (tref->space_type == SPACE_VIEW3D) {
switch (tref->mode) {
case CTX_MODE_SCULPT:
case CTX_MODE_SCULPT_GREASE_PENCIL:
Falk David commented 2024-03-12 15:04:06 +01:00
Member
Copy Link

This should probably return PaintMode::SculptGPencil

This should probably return `PaintMode::SculptGPencil`
Lukas Tönne commented 2024-03-12 19:24:53 +01:00
Author
Member
Copy Link

I've been adding this in my followup branch that adds the first actual tool:
f805497286/source/blender/blenkernel/BKE_paint.hh (L106)
f805497286/source/blender/blenkernel/intern/paint.cc (L665)

I've been adding this in my followup branch that adds the first actual tool: https://projects.blender.org/LukasTonne/blender/src/commit/f805497286cf50004e498bd931a0e92aa3913717/source/blender/blenkernel/BKE_paint.hh#L106 https://projects.blender.org/LukasTonne/blender/src/commit/f805497286cf50004e498bd931a0e92aa3913717/source/blender/blenkernel/intern/paint.cc#L665
👍 1
LukasTonne marked this conversation as resolved
source/blender/windowmanager/intern/wm_toolsystem.cc Outdated
@ -718,6 +718,7 @@ static const char *toolsystem_default_tool(const bToolKey *tkey)
case CTX_MODE_PAINT_TEXTURE:
case CTX_MODE_PAINT_GPENCIL_LEGACY:
case CTX_MODE_PAINT_GREASE_PENCIL:
case CTX_MODE_SCULPT_GREASE_PENCIL:
Falk David commented 2024-03-12 15:02:57 +01:00
Member
Copy Link

Looks like this should be below case CTX_MODE_SCULPT_GPENCIL_LEGACY:

Looks like this should be below `case CTX_MODE_SCULPT_GPENCIL_LEGACY:`
LukasTonne marked this conversation as resolved
Lukas Tönne added 2 commits 2024-03-12 19:29:32 +01:00
Lukas Tönne added 1 commit 2024-03-13 11:35:50 +01:00
Lukas Tönne added 2 commits 2024-03-14 15:46:15 +01:00
Lukas Tönne added 1 commit 2024-03-14 15:48:07 +01:00
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
c5379f55d7 Removed unused parameters when creating GPv3 strokes.
Lukas Tönne requested review from Falk David 2024-03-14 15:49:13 +01:00
Lukas Tönne commented 2024-03-14 15:49:24 +01:00
Author
Member
Copy Link

@blender-bot build

@blender-bot build
Lukas Tönne added 1 commit 2024-03-14 15:58:11 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
d73680f819 Remove unused code.
Lukas Tönne commented 2024-03-14 15:58:51 +01:00
Author
Member
Copy Link

@blender-bot build

@blender-bot build
Lukas Tönne added 1 commit 2024-03-19 10:47:13 +01:00
Lukas Tönne added 2 commits 2024-03-19 17:11:32 +01:00
Lukas Tönne added 1 commit 2024-03-20 10:12:25 +01:00
Lukas Tönne added 1 commit 2024-03-21 09:44:43 +01:00
Lukas Tönne added 1 commit 2024-03-21 10:20:15 +01:00
Lukas Tönne added 1 commit 2024-03-22 15:29:02 +01:00
Lukas Tönne added 2 commits 2024-03-26 15:45:33 +01:00
7715a41431 Revert usage of the OB_SCULPT mode for grease pencil v3. 
Use the legacy OB_MODE_SCULPT_GPENCIL_LEGACY instead.
Lukas Tönne added 1 commit 2024-03-26 16:15:59 +01:00
Lukas Tönne added 1 commit 2024-03-26 16:53:30 +01:00
Lukas Tönne added 1 commit 2024-04-04 09:07:14 +02:00
Lukas Tönne added 1 commit 2024-04-08 09:44:59 +02:00
Falk David requested changes 2024-04-08 10:52:15 +02:00
Dismissed
Falk David left a comment
Member
Copy Link

Just got two questions:

Just got two questions:
scripts/modules/bl_keymap_utils/keymap_from_toolbar.py Outdated
@ -173,3 +173,3 @@
if item.data_block:
# PAINT_OT_brush_select
mode = context.active_object.mode
ob = context.active_object
Falk David commented 2024-04-08 10:44:48 +02:00
Member
Copy Link

Looks like this change is no longer needed?

Looks like this change is no longer needed?
LukasTonne marked this conversation as resolved
scripts/startup/bl_ui/space_view3d.py Outdated
@ -420,0 +473,4 @@
)
# direction
if not capabilities.has_direction:
Falk David commented 2024-04-08 10:34:08 +02:00
Member
Copy Link

Isn't this condition backwards?

Isn't this condition backwards?
Lukas Tönne commented 2024-04-08 11:26:37 +02:00
Author
Member
Copy Link

I copied this from the SCULPT case, i don't know what it does ...

I copied this from the [SCULPT](https://projects.blender.org/blender/blender/src/commit/538a470040c513ae6991e8f5f317ec0017ded09f/scripts/startup/bl_ui/space_view3d.py#L287) case, i don't know what it does ...
Falk David commented 2024-04-08 11:28:38 +02:00
Member
Copy Link

Ah I think I get it now. Just confusing.

Ah I think I get it now. Just confusing.
LukasTonne marked this conversation as resolved
Falk David reviewed 2024-04-08 10:56:42 +02:00
source/blender/editors/sculpt_paint/grease_pencil_draw_ops.cc Outdated
@ -52,4 +37,1 @@
case GPAINT_TOOL_ERASE:
operation = greasepencil::new_erase_operation().release();
break;
case GPAINT_TOOL_TINT:
Falk David commented 2024-04-08 10:56:42 +02:00
Member
Copy Link

Looks like a merge mistake here. This case should be moved further down to grease_pencil_brush_stroke_operation.

Looks like a merge mistake here. This case should be moved further down to `grease_pencil_brush_stroke_operation`.
Lukas Tönne commented 2024-04-08 11:30:40 +02:00
Author
Member
Copy Link

Thanks for the catch.

Thanks for the catch.
LukasTonne marked this conversation as resolved
Lukas Tönne added 2 commits 2024-04-08 11:31:00 +02:00
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
eacc0b2760 Fix merge error.
Falk David commented 2024-04-08 11:32:01 +02:00
Member
Copy Link

@blender-bot build

@blender-bot build
Falk David approved these changes 2024-04-08 14:48:07 +02:00
Falk David requested review from Hans Goudey 2024-04-09 11:51:14 +02:00
Hans Goudey approved these changes 2024-04-10 22:12:07 +02:00
Hans Goudey left a comment
Member
Copy Link

OB_MODE_SCULPT_GPENCIL_LEGACY should be renamed to remove _LEGACY next.

`OB_MODE_SCULPT_GPENCIL_LEGACY` should be renamed to remove `_LEGACY` next.
Lukas Tönne merged commit 658a9ac3a9 into main 2024-04-11 09:39:59 +02:00
Lukas Tönne deleted branch gp3-sculpt-mode 2024-04-11 09:40:02 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Falk David
Hans Goudey
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Grease Pencil
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119338
No description provided.
Delete Branch "LukasTonne/blender:gp3-sculpt-mode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?