Fix #119505: artifacts in VSE vectorscope #119512

Merged
Aras Pranckevicius merged 1 commits from aras_p/blender:vse_scopes_workaround into blender-v4.1-release 2024-03-15 15:53:34 +01:00

On some GPUs/drivers (seemingly nvidia) and screen sizes, VSE
vectorscope and sometimes waveform have "garbage" artifacts around
them.

Root cause unknown (driver bug?), for now similar fix as a while ago
in #112665: explicitly draw opaque background (with alpha=1), and then
use alpha blending for the scopes texture display on top of that.

On some GPUs/drivers (seemingly nvidia) and screen sizes, VSE vectorscope and sometimes waveform have "garbage" artifacts around them. Root cause unknown (driver bug?), for now similar fix as a while ago in #112665: explicitly draw opaque background (with alpha=1), and then use alpha blending for the scopes texture display on top of that.
Aras Pranckevicius added 1 commit 2024-03-15 14:04:29 +01:00
Fix #119505: artifacts in VSE vectorscope
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
f15b452d4f
On some GPUs/drivers (seemingly nvidia) and screen sizes, VSE
vectorscope and sometimes waveform have "garbage" artifacts around
them.

Root cause unknown (driver bug?), for now similar fix as a while ago
in #112665: explicitly draw opaque background (with alpha=1), and then
use alpha blending for the scopes texture display on top of that.
Aras Pranckevicius requested review from Philipp Oeser 2024-03-15 14:04:47 +01:00
Author
Member

@blender-bot build

@blender-bot build
Member

Checking now, but would prefer if @Jeroen-Bakker was the primary reviewer here...

Checking now, but would prefer if @Jeroen-Bakker was the primary reviewer here...
Philipp Oeser requested review from Jeroen Bakker 2024-03-15 14:30:09 +01:00
Philipp Oeser approved these changes 2024-03-15 14:43:42 +01:00
Philipp Oeser left a comment
Member

works fine for me

works fine for me
Member

Yeah, this driver bug is haunting Blender for the last 6 months at least. So pre-drawing a quad is a fine solution for now.

Yeah, this driver bug is haunting Blender for the last 6 months at least. So pre-drawing a quad is a fine solution for now.
Jeroen Bakker approved these changes 2024-03-15 15:08:36 +01:00
Jeroen Bakker added this to the 4.1 milestone 2024-03-15 15:08:44 +01:00
Jeroen Bakker added this to the Viewport & EEVEE project 2024-03-15 15:08:47 +01:00
Aras Pranckevicius was assigned by Jeroen Bakker 2024-03-15 15:08:52 +01:00
Jeroen Bakker removed this from the Viewport & EEVEE project 2024-03-15 15:09:03 +01:00
Aras Pranckevicius merged commit 52a8bea237 into blender-v4.1-release 2024-03-15 15:53:34 +01:00
Aras Pranckevicius deleted branch vse_scopes_workaround 2024-03-15 15:53:41 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119512
No description provided.