WIP: Fix #119211: GPU Compositor: Masks are not updating correctly in Backdrop/Viewer Node #119561

Habib Gahbiche · 2024-03-16T16:52:50+01:00

Habib Gahbiche commented

2024-03-16 16:52:50 +01:00

Mask operators typically call DEG_id_tag_update(&mask->id, ID_RECALC_GEOMETRY); to update the mask and they do not invalidate some GPU drawing state. This means CachedMask should query changes directly from the mask.

Downsides of this patch is that masks are currently always recalculated, even for changes that don't require it, e.g. disconnect an unrelated compositor node. This will be addressed by using more targeted ID_RECALC_* flags, should we choose to move on with this approach

Mask operators typically call `DEG_id_tag_update(&mask->id, ID_RECALC_GEOMETRY);` to update the mask and they do not invalidate some GPU drawing state. This means `CachedMask` should query changes directly from the mask. Downsides of this patch is that masks are currently always recalculated, even for changes that don't require it, e.g. disconnect an unrelated compositor node. This will be addressed by using more targeted `ID_RECALC_*` flags, should we choose to move on with this approach

Habib Gahbiche added 2 commits 2024-03-16 16:52:58 +01:00

9c1f31bfa8 Fix #119211 : GPU Compositor: Masks are not updating correctly in Backdrop/Viewer Node

e1aa85cb19 Merge remote-tracking branch 'origin/main' into com-fix-mask-not-updating

Habib Gahbiche added this to the Compositing project 2024-03-16 16:53:11 +01:00

Habib Gahbiche commented

2024-03-16 16:56:53 +01:00

@OmarEmaraDev Is this approach fine in principle? I don't understand why images and textures get their recalc flags through DrawEngine and not directly through their id...

@OmarEmaraDev Is this approach fine in principle? I don't understand why images and textures get their `recalc` flags through `DrawEngine` and not directly through their `id`...

Omar Emara commented

2024-03-18 08:56:40 +01:00

@zazizizou This approach is not fine unfortunately.

Note that the ID->recalc flags will eventually be accumulated in the DrawData->reclac in flush_engine_data_update during dependency graph evaluation. So using DrawData->reclac instead of ID->recalc shouldn't be an issue.

The reason why every "engine" have its own reclac flags for every ID is that they will be able to clear the flags once they have handled the changes. On the other hand, if you clear the flag in the ID itself like your code currently do, other engines will miss those changes.

To debug this, we need to figure out why the flags don't propogate to the draw data. Maybe start by looking at the depsgraph log, looking for Accumulated recalc bits for?

@zazizizou This approach is not fine unfortunately. Note that the `ID->recalc` flags will eventually be accumulated in the `DrawData->reclac` in `flush_engine_data_update` during dependency graph evaluation. So using `DrawData->reclac` instead of `ID->recalc` shouldn't be an issue. The reason why every "engine" have its own reclac flags for every ID is that they will be able to clear the flags once they have handled the changes. On the other hand, if you clear the flag in the ID itself like your code currently do, other engines will miss those changes. To debug this, we need to figure out why the flags don't propogate to the draw data. Maybe start by looking at the depsgraph log, looking for `Accumulated recalc bits for`?

This pull request is marked as a work in progress.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u com-fix-mask-not-updating:zazizizou-com-fix-mask-not-updating

git checkout zazizizou-com-fix-mask-not-updating

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Fix #119211: GPU Compositor: Masks are not updating correctly in Backdrop/Viewer Node #119561

Checkout